From: Akinobu Mita <akinobu.mita@gmail.com>
To: Eugen Hristev <Eugen.Hristev@microchip.com>
Cc: Lubomir Rintel <lkundrak@v3.sk>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH 0/2] media: ov7670: fix regressions caused by "hook s_power onto v4l2 core"
Date: Tue, 19 Mar 2019 22:38:00 +0900 [thread overview]
Message-ID: <CAC5umyhjXbP9cUnGHew6wsHMDadUKfFo0MGnMWS6D0f=QsdPGg@mail.gmail.com> (raw)
In-Reply-To: <1900bcf1-a5b7-b4b3-d275-03117e6c87ef@microchip.com>
2019年3月19日(火) 18:14 <Eugen.Hristev@microchip.com>:
>
>
>
> On 13.03.2019 23:05, Sakari Ailus wrote:
>
> > On Tue, Mar 12, 2019 at 06:16:08PM +0100, Lubomir Rintel wrote:
> >> On Tue, 2019-03-12 at 00:36 +0900, Akinobu Mita wrote:
> >>> This patchset fixes the problems introduced by recent change to ov7670.
> >>>
> >>> Akinobu Mita (2):
> >>> media: ov7670: restore default settings after power-up
> >>> media: ov7670: don't access registers when the device is powered off
> >>>
> >>> drivers/media/i2c/ov7670.c | 32 +++++++++++++++++++++++++++-----
> >>> 1 file changed, 27 insertions(+), 5 deletions(-)
> >>>
> >>> Cc: Lubomir Rintel <lkundrak@v3.sk>
> >>> Cc: Jonathan Corbet <corbet@lwn.net>
> >>> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> >>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> >>
> >> For the both patches in the set:
> >>
> >> Reviewed-by: Lubomir Rintel <lkundrak@v3.sk>
> >> Tested-by: Lubomir Rintel <lkundrak@v3.sk>
> >
> > Thanks, guys!
> >
>
> Hi Akinobu,
>
> I am having issues with this sensor, and your patches do not fix them
> for me ( maybe they are not supposed to )
>
> My issues are like this: once I set a format and start streaming, if I
> stop streaming and reconfigure the format , for example YUYV after RAW,
> or RGB565 after RAW and viceversa, the sensor looks to have completely
> messed up settings: images obtained are very bad.
> This did not happen for me with older kernel version (4.14 stable for
> example).
> I can help with testing patches if you need.
I'd suggest identifying which commit introduced your problem.
prev parent reply other threads:[~2019-03-19 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 15:36 [PATCH 0/2] media: ov7670: fix regressions caused by "hook s_power onto v4l2 core" Akinobu Mita
2019-03-11 15:36 ` [PATCH 1/2] media: ov7670: restore default settings after power-up Akinobu Mita
2019-03-11 15:36 ` [PATCH 2/2] media: ov7670: don't access registers when the device is powered off Akinobu Mita
2019-03-12 17:16 ` [PATCH 0/2] media: ov7670: fix regressions caused by "hook s_power onto v4l2 core" Lubomir Rintel
2019-03-13 21:05 ` Sakari Ailus
2019-03-19 9:14 ` Eugen.Hristev
2019-03-19 13:38 ` Akinobu Mita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC5umyhjXbP9cUnGHew6wsHMDadUKfFo0MGnMWS6D0f=QsdPGg@mail.gmail.com' \
--to=akinobu.mita@gmail.com \
--cc=Eugen.Hristev@microchip.com \
--cc=corbet@lwn.net \
--cc=linux-media@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).