linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set
@ 2019-07-04  9:35 YueHaibing
  2019-07-04 12:24 ` Applied "regmap: select CONFIG_REGMAP while REGMAP_SCCB is set" to the regmap tree Mark Brown
  2019-07-04 13:49 ` [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set Akinobu Mita
  0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-07-04  9:35 UTC (permalink / raw)
  To: broonie, gregkh, rafael, akinobu.mita, wsa+renesas, sakari.ailus,
	mchehab+samsung, jacopo, khoroshilov
  Cc: linux-kernel, linux-media, YueHaibing

REGMAP_SCCB is selected by ov772x and ov9650 drivers,
but CONFIG_REGMAP may not, so building will fails:

rivers/media/i2c/ov772x.c: In function ov772x_probe:
drivers/media/i2c/ov772x.c:1360:22: error: variable ov772x_regmap_config has initializer but incomplete type
  static const struct regmap_config ov772x_regmap_config = {
                      ^~~~~~~~~~~~~
drivers/media/i2c/ov772x.c:1361:4: error: const struct regmap_config has no member named reg_bits

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 5bbf32217bf9 ("media: ov772x: use SCCB regmap")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/base/regmap/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index c8bbf53..a498413 100644
--- a/drivers/base/regmap/Kconfig
+++ b/drivers/base/regmap/Kconfig
@@ -4,7 +4,7 @@
 # subsystems should select the appropriate symbols.
 
 config REGMAP
-	default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_I3C)
+	default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C)
 	select IRQ_DOMAIN if REGMAP_IRQ
 	bool
 
-- 
2.7.4



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-04 13:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04  9:35 [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set YueHaibing
2019-07-04 12:24 ` Applied "regmap: select CONFIG_REGMAP while REGMAP_SCCB is set" to the regmap tree Mark Brown
2019-07-04 13:49 ` [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set Akinobu Mita

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).