From: Karol Herbst <kherbst@redhat.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "Jeremy Kolb" <jkolb@brandeis.edu>,
"David Airlie" <airlied@linux.ie>,
nouveau <nouveau@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
linaro-mm-sig@lists.linaro.org, "Ben Skeggs" <bskeggs@redhat.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Christian König" <christian.koenig@amd.com>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [Nouveau] [PATCH 07/40] drm/nouveau/nouveau_bo: Remove unused variables 'dev'
Date: Mon, 19 Apr 2021 13:44:15 +0200 [thread overview]
Message-ID: <CACO55tvQ=dvDbwzWmwn7ZOwqyStEXn3=8zab6rQSiau3OkKktQ@mail.gmail.com> (raw)
In-Reply-To: <20210416143725.2769053-8-lee.jones@linaro.org>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
On Fri, Apr 16, 2021 at 4:37 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_populate’:
> drivers/gpu/drm/nouveau/nouveau_bo.c:1228:17: warning: variable ‘dev’ set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_unpopulate’:
> drivers/gpu/drm/nouveau/nouveau_bo.c:1252:17: warning: variable ‘dev’ set but not used [-Wunused-but-set-variable]
>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Jeremy Kolb <jkolb@brandeis.edu>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index 3e09df0472ce4..37b3d2c10f5c5 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -1255,7 +1255,6 @@ nouveau_ttm_tt_populate(struct ttm_device *bdev,
> {
> struct ttm_tt *ttm_dma = (void *)ttm;
> struct nouveau_drm *drm;
> - struct device *dev;
> bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
>
> if (ttm_tt_is_populated(ttm))
> @@ -1268,7 +1267,6 @@ nouveau_ttm_tt_populate(struct ttm_device *bdev,
> }
>
> drm = nouveau_bdev(bdev);
> - dev = drm->dev->dev;
>
> return ttm_pool_alloc(&drm->ttm.bdev.pool, ttm, ctx);
> }
> @@ -1278,14 +1276,12 @@ nouveau_ttm_tt_unpopulate(struct ttm_device *bdev,
> struct ttm_tt *ttm)
> {
> struct nouveau_drm *drm;
> - struct device *dev;
> bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
>
> if (slave)
> return;
>
> drm = nouveau_bdev(bdev);
> - dev = drm->dev->dev;
>
> return ttm_pool_free(&drm->ttm.bdev.pool, ttm);
> }
> --
> 2.27.0
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2021-04-19 11:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 14:36 [PATCH 00/40] [Set 16] Rid W=1 warnings from GPU! Lee Jones
2021-04-16 14:36 ` [PATCH 07/40] drm/nouveau/nouveau_bo: Remove unused variables 'dev' Lee Jones
2021-04-19 11:44 ` Karol Herbst [this message]
2021-04-16 14:37 ` [PATCH 19/40] drm/omapdrm/omap_gem: Properly document omap_gem_dumb_map_offset() Lee Jones
2021-04-23 12:12 ` Tomi Valkeinen
2021-04-16 14:37 ` [PATCH 23/40] drm/ttm/ttm_bo: Fix incorrectly documented function 'ttm_bo_cleanup_refs' Lee Jones
2021-04-16 15:31 ` Christian König
2021-04-20 21:27 ` Alex Deucher
2021-04-21 7:02 ` Christian König
2021-04-16 14:37 ` [PATCH 24/40] drm/scheduler/sched_entity: Fix some function name disparity Lee Jones
2021-04-16 14:37 ` [PATCH 26/40] drm/amd/amdgpu/amdgpu_device: Remove unused variable 'r' Lee Jones
2021-04-20 23:53 ` Alex Deucher
2021-04-16 14:37 ` [PATCH 29/40] drm/amd/amdgpu/amdgpu_fence: Provide description for 'sched_score' Lee Jones
2021-04-16 15:52 ` Christian König
2021-04-20 23:57 ` Alex Deucher
2021-04-16 14:37 ` [PATCH 30/40] drm/vgem/vgem_drv: Demote kernel-doc abuse Lee Jones
2021-04-16 14:37 ` [PATCH 32/40] drm/amd/amdgpu/amdgpu_ttm: Fix incorrectly documented function 'amdgpu_ttm_copy_mem_to_mem()' Lee Jones
2021-04-16 15:53 ` Christian König
2021-04-21 0:00 ` Alex Deucher
2021-04-16 14:37 ` [PATCH 33/40] drm/amd/amdgpu/amdgpu_ring: Provide description for 'sched_score' Lee Jones
2021-04-16 15:54 ` Christian König
2021-04-21 0:01 ` Alex Deucher
2021-04-16 14:37 ` [PATCH 35/40] drm/amd/amdgpu/amdgpu_cs: Repair some function naming disparity Lee Jones
2021-04-16 15:54 ` Christian König
2021-04-21 0:03 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACO55tvQ=dvDbwzWmwn7ZOwqyStEXn3=8zab6rQSiau3OkKktQ@mail.gmail.com' \
--to=kherbst@redhat.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jkolb@brandeis.edu \
--cc=lee.jones@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).