From: Dongliang Mu <mudongliangabcd@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Dongliang Mu <mudongliangabcd@gmail.com>
Cc: linux-media@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: usb: fix memory leak in stk_camera_probe
Date: Fri, 23 Jul 2021 18:11:36 +0800 [thread overview]
Message-ID: <CAD-N9QXWHeNvR06wyg3Pym8xUb27TsuFKKKG=tZ0-x5ZGCr-Hw@mail.gmail.com> (raw)
In-Reply-To: <20210714032340.504836-1-mudongliangabcd@gmail.com>
On Wed, Jul 14, 2021 at 11:23 AM Dongliang Mu <mudongliangabcd@gmail.com> wrote:
>
> stk_camera_probe mistakenly execute usb_get_intf and increase the
> refcount of interface->dev.
>
> Fix this by removing the execution of usb_get_intf.
Any idea about this patch?
>
> Reported-by: Dongliang Mu <mudongliangabcd@gmail.com>
> Fixes: 0aa77f6c2954 ("[media] move the remaining USB drivers to drivers/media/usb")
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
> drivers/media/usb/stkwebcam/stk-webcam.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c
> index a45d464427c4..5bd8e85b9452 100644
> --- a/drivers/media/usb/stkwebcam/stk-webcam.c
> +++ b/drivers/media/usb/stkwebcam/stk-webcam.c
> @@ -1311,7 +1311,6 @@ static int stk_camera_probe(struct usb_interface *interface,
>
> dev->udev = udev;
> dev->interface = interface;
> - usb_get_intf(interface);
>
> if (hflip != -1)
> dev->vsettings.hflip = hflip;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-07-23 10:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 3:23 [PATCH] media: usb: fix memory leak in stk_camera_probe Dongliang Mu
2021-07-23 10:11 ` Dongliang Mu [this message]
2021-09-02 10:23 ` Dongliang Mu
2021-09-02 10:39 ` Greg KH
2021-09-02 10:54 ` Mauro Carvalho Chehab
2021-09-02 10:59 ` Dongliang Mu
2021-09-02 11:10 ` Dongliang Mu
2021-09-02 11:15 ` Hans Verkuil
2021-09-02 11:22 ` Dongliang Mu
2021-09-02 18:14 ` Pavel Skripkin
2021-09-02 23:51 ` Dongliang Mu
2021-09-02 10:49 ` Hans Verkuil
2021-09-02 11:06 ` Dongliang Mu
2021-09-02 14:17 ` Dan Carpenter
2021-09-02 23:45 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD-N9QXWHeNvR06wyg3Pym8xUb27TsuFKKKG=tZ0-x5ZGCr-Hw@mail.gmail.com' \
--to=mudongliangabcd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).