From: Sergey Zakharchenko <doublef.mobile@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sergey Zakharchenko <szakharchenko@digital-loggers.com>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Martin Bodo <martin@digital-loggers.com>,
"Logan, Peter" <peter.logan@intel.com>,
Auke Kok <auke-jan.h.kok@intel.com>
Subject: Re: [PATCH v2] media: uvcvideo: Add a quirk to force GEO GC6500 Camera bits-per-pixel value
Date: Wed, 2 Oct 2019 23:29:40 +0400 [thread overview]
Message-ID: <CADYCxoMAD_scAwGE89oULPgOWOjji6ADTXkG30oRwNLjPdAJrw@mail.gmail.com> (raw)
In-Reply-To: <20191002190805.GG5262@pendragon.ideasonboard.com>
Laurent,
> Would it make sense to split the calculation from v4l2_fill_pixfmt() to
> a helper function that the UVC driver could call ?
It would of course be possible, and would benefit v4l2-common.c as it
would be common between v4l2_fill_pixfmt() and v4l2_fill_pixfmt_mp(),
but as I noted before that approach would leave the bpp struct member,
used elsewhere, possibly incorrect. I'm also not sure where
multi-planar formats fit in (probably not related to the problem at
hand).
> > I'm going to send v3 in an hour unless there are other suggestions.
Till tomorrow, then...
Best regards,
--
Sergey Zakharchenko
Digital Loggers, Inc.
next prev parent reply other threads:[~2019-10-02 19:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 8:47 [PATCH] media: uvcvideo: Add a quirk to force GEO GC6500 Camera bits-per-pixel value Sergey Zakharchenko
2019-10-02 12:00 ` kbuild test robot
2019-10-02 13:01 ` [PATCH v2] " Sergey Zakharchenko
2019-10-02 14:08 ` Laurent Pinchart
2019-10-02 14:54 ` Sergey Zakharchenko
2019-10-02 17:15 ` Sergey Zakharchenko
2019-10-02 19:08 ` Laurent Pinchart
2019-10-02 19:29 ` Sergey Zakharchenko [this message]
2019-10-03 9:31 ` [PATCH v3] " Sergey Zakharchenko
2019-12-18 18:00 ` Laurent Pinchart
2019-12-18 18:46 ` Sergey Zakharchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADYCxoMAD_scAwGE89oULPgOWOjji6ADTXkG30oRwNLjPdAJrw@mail.gmail.com \
--to=doublef.mobile@gmail.com \
--cc=auke-jan.h.kok@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=martin@digital-loggers.com \
--cc=mchehab@kernel.org \
--cc=peter.logan@intel.com \
--cc=szakharchenko@digital-loggers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).