From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58985C2D0A3 for ; Mon, 16 Nov 2020 20:14:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E62BB217A0 for ; Mon, 16 Nov 2020 20:14:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WT0sw49x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731985AbgKPUOK (ORCPT ); Mon, 16 Nov 2020 15:14:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731956AbgKPUOJ (ORCPT ); Mon, 16 Nov 2020 15:14:09 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DD39C0613CF; Mon, 16 Nov 2020 12:14:09 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id b6so20213594wrt.4; Mon, 16 Nov 2020 12:14:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tlFFgICp87GKZs6ppYHW2rMrLGlJH6xaYF8VswIu2r8=; b=WT0sw49xTmzfyuepsj8KVXsdlk1NQkHaKlUQDvqqCND8FHQvwhpnn5uYP+2zZFQqwM KNWPU3FwKRP61VymQxCJZHLZV0dAJ45Cps+OhCDc0YK+sXtLuue6vP7BpskUJX7ZUJ57 qL0/dBLUyqYtQGcva88qLlsGCsI/FuxjDlaUSGLArXtDdLZLUZOBRv2vzC6grY8K6OMs wFTCh0+FP/0N8Qt8QntAZM8DbbxAZMinOAJwQN7fck93Z4Nht3bFmEmOoWlJuZ+59Kjd 6K7gXi2b1wLdOin94HV94OP7+jPb7hOVzRao03uMhSd5WCv9In1zGKphSqfKSpBoH0E/ kwTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tlFFgICp87GKZs6ppYHW2rMrLGlJH6xaYF8VswIu2r8=; b=iYb8IYbbgVAJdkBGPOecPItE+HUs2xgqOcK3Od0n8Kbs5BMKXxVLPuIN3ux1zJikFF hZSmfO4ek7WFISa0f1R9kHEiCMAYJDepiGwBxNmY0CJuaB8Y3RODq2ZqGup1GIMJQZmT W+M9pHsHgLjOh+bh3a+8JLMagl/MGQvtdcXkLwf88aOin5muJx60veaDqQPXTKsUGA3X 1DS/T+B91stO3qtohl5Rb3vJQCZgNZuBV0LXkpTrpv+Ad8+p5b9YjirtVqcSbxdXB0ww itK4ATfRIDDrO4aEcHRBVCWf2tJKEAJBYx0H6cLjFtw/2AhaUUMJvoyw8hHQC5wYQsnh a4WQ== X-Gm-Message-State: AOAM530WWbTHi+2LEI0q5IPqlyxMmxbiOe50XtySgMIW/OP2JIJQLQOg bu2NjslPsKrrz2IAJqlfVfXwZ0gmFnsG+wARDDg= X-Google-Smtp-Source: ABdhPJyhVjBfB4XwW22p2f67Xq+c+n49ESvD/mLBvHttBW5MOL3/bbo6s1Z+aAzlKoUDvKA9FP/lfmG14QOnR/KpvmY= X-Received: by 2002:adf:9144:: with SMTP id j62mr4516760wrj.419.1605557647980; Mon, 16 Nov 2020 12:14:07 -0800 (PST) MIME-Version: 1.0 References: <20201116173700.1830487-1-lee.jones@linaro.org> <20201116173700.1830487-22-lee.jones@linaro.org> In-Reply-To: <20201116173700.1830487-22-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 16 Nov 2020 15:13:56 -0500 Message-ID: Subject: Re: [PATCH 21/43] drm/radeon/r600_dma: Move 'r600_gpu_check_soft_reset()'s prototype to shared location To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , =?UTF-8?Q?Christian_K=C3=B6nig?= , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Maling list - DRI developers , Alex Deucher , linux-media Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/radeon/r600.c:1615:5: warning: no previous prototype for= =E2=80=98r600_gpu_check_soft_reset=E2=80=99 [-Wmissing-prototypes] > 1615 | u32 r600_gpu_check_soft_reset(struct radeon_device *rdev) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones Applied with minor changes. Thanks! Alex > --- > drivers/gpu/drm/radeon/r600.c | 1 + > drivers/gpu/drm/radeon/r600.h | 35 +++++++++++++++++++++++++++++++ > drivers/gpu/drm/radeon/r600_dma.c | 3 +-- > 3 files changed, 37 insertions(+), 2 deletions(-) > create mode 100644 drivers/gpu/drm/radeon/r600.h > > diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.= c > index f09b6dc5cbeb3..94e8815e5067d 100644 > --- a/drivers/gpu/drm/radeon/r600.c > +++ b/drivers/gpu/drm/radeon/r600.c > @@ -39,6 +39,7 @@ > > #include "atom.h" > #include "avivod.h" > +#include "r600.h" > #include "r600d.h" > #include "rv770.h" > #include "radeon.h" > diff --git a/drivers/gpu/drm/radeon/r600.h b/drivers/gpu/drm/radeon/r600.= h > new file mode 100644 > index 0000000000000..2a3915f0039e4 > --- /dev/null > +++ b/drivers/gpu/drm/radeon/r600.h > @@ -0,0 +1,35 @@ > +/* r600.h -- Private header for radeon driver -*- linux-c -*- > + * > + * Copyright 1999 Precision Insight, Inc., Cedar Park, Texas. > + * Copyright 2000 VA Linux Systems, Inc., Fremont, California. > + * All rights reserved. > + * > + * Permission is hereby granted, free of charge, to any person obtaining= a > + * copy of this software and associated documentation files (the "Softwa= re"), > + * to deal in the Software without restriction, including without limita= tion > + * the rights to use, copy, modify, merge, publish, distribute, sublicen= se, > + * and/or sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice (including the = next > + * paragraph) shall be included in all copies or substantial portions of= the > + * Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE= SS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILI= TY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SH= ALL > + * PRECISION INSIGHT AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAG= ES OR > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR= OTHER > + * DEALINGS IN THE SOFTWARE. > + * > + */ > + > +#ifndef __R600_H__ > +#define __R600_H__ > + > +struct radeon_device; > + > +u32 r600_gpu_check_soft_reset(struct radeon_device *rdev); > + > +#endif /* __R600_H__ */ > diff --git a/drivers/gpu/drm/radeon/r600_dma.c b/drivers/gpu/drm/radeon/r= 600_dma.c > index af6c0da45f28a..89ca2738c5d4c 100644 > --- a/drivers/gpu/drm/radeon/r600_dma.c > +++ b/drivers/gpu/drm/radeon/r600_dma.c > @@ -24,10 +24,9 @@ > > #include "radeon.h" > #include "radeon_asic.h" > +#include "r600.h" > #include "r600d.h" > > -u32 r600_gpu_check_soft_reset(struct radeon_device *rdev); > - > /* > * DMA > * Starting with R600, the GPU has an asynchronous > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel