From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C38C8C73C69 for ; Wed, 10 Jul 2019 04:12:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9721520645 for ; Wed, 10 Jul 2019 04:12:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bWsVGu9Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726129AbfGJEMR (ORCPT ); Wed, 10 Jul 2019 00:12:17 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:43830 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbfGJEMR (ORCPT ); Wed, 10 Jul 2019 00:12:17 -0400 Received: by mail-vs1-f68.google.com with SMTP id j26so595892vsn.10 for ; Tue, 09 Jul 2019 21:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jsT84thXZgrjljKWPHUjY7JeFgImc9+U4hEoxyiTJcc=; b=bWsVGu9ZtrSBJl4JbELamsoGGvbUEuoJyLkzEdD/lBLkOe2SuDywqNJvjhLcdkFQIV uQzhsHZfClHSSErFS8YngoK5icUK/zOzfk2MyJE77f/EpBtLGiDl5OLXwZaYMg1H4xvi 8bZw2KyzNEgXQhxeZxd3j43hSpSd9KAK3Vxwk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jsT84thXZgrjljKWPHUjY7JeFgImc9+U4hEoxyiTJcc=; b=d7sms4b7Ec8ebRI+xdZwpR24fuQB7K3ABftajzo/Jj7lLJy5WW3oWLYX67veGawv9E SF+Fz4tj7Z0KOdo9RzE0UVyChPkD1RROPaijeej78ytWQAT2PK5ALy7cWSfyF2ekeZ4X ENHBfHtmHGc6BAhafZ74tC6FPqZJqY7wFFV1P3lfy96ZDDXCBuhPtStbxWAYRn4MUCjx Il8KHxPumV0D3stvG13wcLPc5jvfZrZJOTGvDjiUhy5Rab6HaFBel6YS0+Hc/DbZ/kP1 KRJF/SRvXH2NV0vud8p2A2qI+mXaJSTg1pKAb0YY3ph55ucPmCPZiUSQteZ4XlWjJ+g3 z55Q== X-Gm-Message-State: APjAAAVdt2/WWh7Hpmg5AOtynn2oKvUMOJccyLXf2gXMBcc3TDWU0u0P 3ZdpAwhJimxw7hSZis4ew6/C75HOKgliJTymy7M/XA== X-Google-Smtp-Source: APXvYqwRDoiekjMfVg1dAkd95CbZGZ3jhAzyHEQ1N/LeXKKIJksHQNLAm0BnKpQtXYeH+ZnDwbVN+JmCCFjQkCNhqMc= X-Received: by 2002:a67:f7cd:: with SMTP id a13mr14190782vsp.163.1562731935844; Tue, 09 Jul 2019 21:12:15 -0700 (PDT) MIME-Version: 1.0 References: <20190603043251.226549-1-cychiang@chromium.org> <20190603043251.226549-6-cychiang@chromium.org> <20190709200121.GA19118@bogus> In-Reply-To: <20190709200121.GA19118@bogus> From: Cheng-yi Chiang Date: Wed, 10 Jul 2019 12:11:48 +0800 Message-ID: Subject: Re: [PATCH 5/7] ASoC: rockchip: rockchip-max98090: Add node for HDMI To: Rob Herring Cc: linux-kernel , Hans Verkuil , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Philipp Zabel , Mark Brown , Liam Girdwood , Takashi Iwai , Jaroslav Kysela , Russell King , Andrzej Hajda , Laurent Pinchart , David Airlie , Daniel Vetter , Heiko Stuebner , Doug Anderson , Dylan Reid , tzungbi@chromium.org, linux-media@vger.kernel.org, "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Jul 10, 2019 at 4:01 AM Rob Herring wrote: > > On Mon, Jun 03, 2019 at 12:32:49PM +0800, Cheng-Yi Chiang wrote: > > Let user specify HDMI node so machine driver can use it to let codec > > driver register callback on correct hdmi-notifier. > > > > Signed-off-by: Cheng-Yi Chiang > > --- > > Documentation/devicetree/bindings/sound/rockchip-max98090.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > index a805aa99ad75..dae57c14864e 100644 > > --- a/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > +++ b/Documentation/devicetree/bindings/sound/rockchip-max98090.txt > > @@ -7,6 +7,7 @@ Required properties: > > connected to the CODEC > > - rockchip,audio-codec: The phandle of the MAX98090 audio codec > > - rockchip,headset-codec: The phandle of Ext chip for jack detection > > +- rockchip,hdmi: The phandle of HDMI node for HDMI jack detection > > > > Example: > > > > @@ -16,4 +17,5 @@ sound { > > rockchip,i2s-controller = <&i2s>; > > rockchip,audio-codec = <&max98090>; > > rockchip,headset-codec = <&headsetcodec>; > > + rockchip,hdmi= <&hdmi>; > > space ^ > > With that, > > Acked-by: Rob Herring > Hi Rob, Thank you for the review. But I have changed the approach in v2 so there is no need for machine driver to expose this property. Thanks! > > }; > > -- > > 2.22.0.rc1.257.g3120a18244-goog > >