From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06378C43331 for ; Tue, 31 Mar 2020 13:37:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF6BF20786 for ; Tue, 31 Mar 2020 13:37:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f6egg8JB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730947AbgCaNhh (ORCPT ); Tue, 31 Mar 2020 09:37:37 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:39756 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730216AbgCaNhg (ORCPT ); Tue, 31 Mar 2020 09:37:36 -0400 Received: by mail-ot1-f66.google.com with SMTP id x11so22017498otp.6 for ; Tue, 31 Mar 2020 06:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BPQgN4wp/xTiSdMQdV45T5G+Dpby0aslGWWXLQEqKs8=; b=f6egg8JB2oXmb5ZDcYSi37IoKdai/7O4iwDdS9tB5EdjG1fdejo+ualHWyXatNehYR MzuHVPjLmDt6I3mEnAV5vFbzaEDV3VPFLNpNOh9u1Y40GU1HMTPq3hWa6Ce+M6GQiG4b mneV32UAu3ydLOrO+Z4VV8rcPZmrygUm8uZsnmj/Te1Ef8SFeyqA5s845DdfJ+euHwLY NeaZljdmTifBJtQuuV/ekejxCON62UGXsMwWI8Sc7UbD5+iHUWdzyxY3T4ka19793baM Nl/S/m+Mys1Ba6C0/1gDd20aGwIa+3Sko7XR8PvXx54mJfhNJ4jofvoAtgq17f+5ntL1 uQ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BPQgN4wp/xTiSdMQdV45T5G+Dpby0aslGWWXLQEqKs8=; b=gbani+5Swlnk0WsOv/sLaOCNI26ZpaS09WWzEIKqLnJTNG4YKQ4TlXzMwNSrCOPIWf mC1PUB3K2mmDM/naKtu9MzmQoO01e4z29+ywf3HcOJ4ONrCLXgSH3LBCSe3W+fy8EhRp C+ZhAXt6rCGbM46+8uhJyGYVdAAxGknQL/fME9xXYVIQr1NL+OutMCgKNlQB0wWMjNvm BZ1ncrEc5CwsSVnKGqPkX61H6L0+0Zn4xLKYxvXiSTwz7C9zrWWjBwNymb9nXP8nGFK/ 897ti3pZrQGBMAzXaMGzH5PAvVNWggnGNfA1FNJnx3QyX8g75sBEw5u5DN3gZ11D4mC2 78sA== X-Gm-Message-State: ANhLgQ2qJqB6a0iH73eoLzcVg5yBCydoav7tsL+AAZUFFH8KEUKQ2pn7 JjjiT/xcvlhEFwI+7a/WSIzJ279dHZh1t8VpI2yLDA== X-Google-Smtp-Source: ADFU+vt5IKuc9tkmr+ASuJda0bZuWGWC0a0b+1r6JL9yr89+s9e71Nso2ucKWJ4k0ClJnzYWXoG2EP313c1QbdzqZj8= X-Received: by 2002:a9d:6c88:: with SMTP id c8mr12319517otr.272.1585661854175; Tue, 31 Mar 2020 06:37:34 -0700 (PDT) MIME-Version: 1.0 References: <20200313110350.10864-1-robert.foss@linaro.org> <20200313110350.10864-3-robert.foss@linaro.org> In-Reply-To: From: Robert Foss Date: Tue, 31 Mar 2020 15:37:22 +0200 Message-ID: Subject: Re: [v2 2/3] media: ov8856: Add devicetree support To: Fabio Estevam Cc: Dongchun Zhu , Andy Shevchenko , Sakari Ailus , Tomasz Figa , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, 26 Mar 2020 at 13:18, Robert Foss wrote: > > Hey Fabio, > > On Fri, 13 Mar 2020 at 14:15, Fabio Estevam wrote: > > > > Hi Robert, > > > > On Fri, Mar 13, 2020 at 8:04 AM Robert Foss wrote: > > > > > +static int __ov8856_power_on(struct ov8856 *ov8856) > > > +{ > > > + struct i2c_client *client = v4l2_get_subdevdata(&ov8856->sd); > > > + int ret; > > > + > > > + ret = clk_prepare_enable(ov8856->xvclk); > > > + if (ret < 0) { > > > + dev_err(&client->dev, "failed to enable xvclk\n"); > > > + return ret; > > > + } > > > + > > > + gpiod_set_value_cansleep(ov8856->reset_gpio, GPIOD_OUT_HIGH); > > > > The parameter of gpiod_set_value_cansleep() is typically 0 (inactive > > state) or 1 (active state), so: > > > > gpiod_set_value_cansleep(ov8856->reset_gpio, 1); > > Ack After testing this change, it breaks the driver during probing. I had a quick look into GPIOD_OUT_HIGH & LOW definitions, and they seem to never be 0 or 1. https://elixir.bootlin.com/linux/latest/source/include/linux/gpio/consumer.h#L38 GPIOD_ASIS = 0, GPIOD_IN = 1, GPIOD_OUT_LOW = 3 GPIOD_OUT_HIGH = 7