From: Robert Foss <robert.foss@linaro.org>
To: kholk11@gmail.com
Cc: Todor Tomov <todor.too@gmail.com>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
marijns95@gmail.com, konradybcio@gmail.com,
martin.botka1@gmail.com, linux-arm-msm@vger.kernel.org,
linux-media <linux-media@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] Add support for SDM630/660 Camera Subsystem
Date: Tue, 20 Oct 2020 14:01:36 +0200 [thread overview]
Message-ID: <CAG3jFyvY1Uq=3V=tkCzRwOK0Zpqy+wEd=tjjr04w8pHrz=LARg@mail.gmail.com> (raw)
In-Reply-To: <20201018125237.16717-1-kholk11@gmail.com>
Hey Angelo,
Thanks for submitting this, and fixing other issues as you went.
I sent out some SoBs which should have been Reviewed-bys, so if you
add them to your commit please replace the SoBs with RBs.
Rob.
On Sun, 18 Oct 2020 at 14:52, <kholk11@gmail.com> wrote:
>
> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>
> This patch series implements support for the entire camera subsystem
> found in SDM630/636/660 and SDA variants, including CSIPHY 3-Phase,
> CSID v5.0, ISPIF 3.0 (though it didn't need any adaptation) and
> VFE 4.8.
>
> One small note about VFE4.8, even if I wrote it in the commit that
> adds support for it: I know, the VFE support here is split in
> multiple files having the name of the actual VFE version that it is
> targeting... but it didn't feel right to commonize the VFE 4.7 file
> and make another one only for VFE4.8, when it's just about something
> like 3 small differences.
> That VFE 4.8 seems to be just a minor revision of VFE 4.7.
>
> While at it, also fix a small issue when using two VFEs: only one
> of them was being resetted (always VFE0) so, after the first usage
> of VFE1, in case we leave it in a bad state, it would not properly
> start again. Now... it's fine :)))
>
> P.S.: SDM630/660's camss seems to be *very* similar to MSM8998, so
> likely 90% of this series should be reusable on that one, too!
>
> Tested on:
> - Sony Xperia XA2 (IMX300 on CSI0/PHY0/VFE0, IMX219 on CSI2,PHY2,VFE1)
> * VFE0/1 RDI only, as the VIDEO one does not work with SRGGB Bayer
> formats yet. As far as I can see, that color format hasn't been
> implemented yet in the video interface.
>
> AngeloGioacchino Del Regno (6):
> media: camss: csiphy-3ph: Add support for SDM630/660
> media: camss: ispif: Correctly reset based on the VFE ID
> media: camss: vfe: Add support for VFE 4.8
> media: camss: Add support for SDM630/636/660 camera subsystem
> media: dt-bindings: media: qcom,camss: Add bindings for SDM660 camss
> media: camss: csiphy: Set rate on csiX_phy clock on SDM630/660
>
> .../devicetree/bindings/media/qcom,camss.txt | 7 +
> .../media/platform/qcom/camss/camss-csid.c | 9 +-
> .../qcom/camss/camss-csiphy-3ph-1-0.c | 7 +-
> .../media/platform/qcom/camss/camss-csiphy.c | 25 ++-
> .../media/platform/qcom/camss/camss-csiphy.h | 1 +
> .../media/platform/qcom/camss/camss-ispif.c | 100 ++++++---
> .../media/platform/qcom/camss/camss-ispif.h | 2 +-
> .../media/platform/qcom/camss/camss-vfe-4-7.c | 129 ++++++++++-
> drivers/media/platform/qcom/camss/camss-vfe.c | 19 +-
> drivers/media/platform/qcom/camss/camss-vfe.h | 1 +
> .../media/platform/qcom/camss/camss-video.c | 3 +-
> drivers/media/platform/qcom/camss/camss.c | 206 +++++++++++++++++-
> drivers/media/platform/qcom/camss/camss.h | 1 +
> 13 files changed, 448 insertions(+), 62 deletions(-)
>
> --
> 2.28.0
>
prev parent reply other threads:[~2020-10-20 12:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 12:52 [PATCH 0/6] Add support for SDM630/660 Camera Subsystem kholk11
2020-10-18 12:52 ` [PATCH 1/6] media: camss: csiphy-3ph: Add support for SDM630/660 kholk11
2020-10-20 8:52 ` Robert Foss
2020-10-18 12:52 ` [PATCH 2/6] media: camss: ispif: Correctly reset based on the VFE ID kholk11
2020-10-20 8:59 ` Robert Foss
2020-10-20 9:02 ` Robert Foss
2020-10-22 17:08 ` AngeloGioacchino Del Regno
2020-10-18 12:52 ` [PATCH 3/6] media: camss: vfe: Add support for VFE 4.8 kholk11
2020-10-20 9:14 ` Robert Foss
2020-10-18 12:52 ` [PATCH 4/6] media: camss: Add support for SDM630/636/660 camera subsystem kholk11
2020-10-20 10:26 ` Robert Foss
2020-10-18 12:52 ` [PATCH 5/6] media: dt-bindings: media: qcom,camss: Add bindings for SDM660 camss kholk11
2020-10-20 10:34 ` Robert Foss
2020-10-18 12:52 ` [PATCH 6/6] media: camss: csiphy: Set rate on csiX_phy clock on SDM630/660 kholk11
2020-10-20 10:35 ` Robert Foss
2020-10-20 12:01 ` Robert Foss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG3jFyvY1Uq=3V=tkCzRwOK0Zpqy+wEd=tjjr04w8pHrz=LARg@mail.gmail.com' \
--to=robert.foss@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kholk11@gmail.com \
--cc=konradybcio@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marijns95@gmail.com \
--cc=martin.botka1@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).