From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B9FC77B73 for ; Tue, 30 May 2023 10:14:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229718AbjE3KOE (ORCPT ); Tue, 30 May 2023 06:14:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbjE3KOB (ORCPT ); Tue, 30 May 2023 06:14:01 -0400 Received: from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com [IPv6:2607:f8b0:4864:20::a34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9382B130 for ; Tue, 30 May 2023 03:13:46 -0700 (PDT) Received: by mail-vk1-xa34.google.com with SMTP id 71dfb90a1353d-457080dc902so1255855e0c.2 for ; Tue, 30 May 2023 03:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685441626; x=1688033626; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hZ0BJZ8SmdZjdj+zn8FxFAZpMTTsRd9o+hpEFn6fp34=; b=RBBWzQ8HEW+9Ib3a8FhJhb7FYys7zwdEFNmdgcI7F5skhmV2LX9SyfMfN2P/VqSG4B XHHINCDVjtKyi6EFACg4gOn0kT9la/m1FLdlFjCItqtAC7lLcbtZg0M7ZXJE/s0fPYcE WnkkEu9TcEkazWD+Lx00lIhvQUkPQFzDILi20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685441626; x=1688033626; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hZ0BJZ8SmdZjdj+zn8FxFAZpMTTsRd9o+hpEFn6fp34=; b=V/ULeYDhyvA599dq6cVab/SnHE6wGMCImn4keKQYibkkxXaEkcazlvEsXVeqxuKRRP RA9YD+AqTFD8TloJA5o13y9qnnYt96T7MkPUZs/hcHQG8FviSx/k5O8zp1fBWyKvF7vU XiYIhkC35p1s/LgFu3jo5bs8l/DjK2jJxv22/SB+cTjnfBqmCNP5aYS4t/eTI1MBRble HfzVFYqFpFfa/p+hAc3col1gVid2wgVT/fTvETZjkJBB3Fr7XUvP0xnCPaJGrZL+jWS1 MFh4b0Pq63hkV7erA/E64wKRqXv4P4pENZadiZB+wBLsX/JZbC2C4E+eWy8Z+49PTG9l xflw== X-Gm-Message-State: AC+VfDz1d/zTxSZ3wzVRQu20j3sDilaRbZxC+RKIz+hNXHzW7F4VKlFW Azc7RowGx5FL7qJbXeIifI9Lb7nvfVakhuPIJxY2iQ== X-Google-Smtp-Source: ACHHUZ7bdeDqEKSO8uuf8TcSdZrCbpL1tSVPRVUVUmGf74rTT2eVhIui40uKYx4bjCTsIWoYlRWwreTsGzdE2XuIez0= X-Received: by 2002:a1f:5fd2:0:b0:43f:8928:151c with SMTP id t201-20020a1f5fd2000000b0043f8928151cmr392643vkb.11.1685441625957; Tue, 30 May 2023 03:13:45 -0700 (PDT) MIME-Version: 1.0 References: <20230525021219.23638-1-yunfei.dong@mediatek.com> In-Reply-To: <20230525021219.23638-1-yunfei.dong@mediatek.com> From: Chen-Yu Tsai Date: Tue, 30 May 2023 18:13:34 +0800 Message-ID: Subject: Re: [PATCH v5,0/8] media: mediatek: vcodec: Add debugfs file for decode and encode To: Yunfei Dong Cc: Nicolas Dufresne , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= , Nathan Hebert , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, May 25, 2023 at 10:12=E2=80=AFAM Yunfei Dong wrote: > > Need to change kernel driver to open decode and encode debug log at curre= nt period, > it's very unreasonable. Adding debugfs common interface to support decode= and encode, > using echo command to control debug log level and getting useful informat= ion for each > instance. > > patch 1 add dbgfs common interface. > patch 2~5 support decode. > patch 6~7 support encode > patch 8 add help function I find the interface kind of weird. A lot of debugfs usage in other places just dumps out the current state. Here you are writing to it to ask it to do a snapshot, and then you read it later. This ends up requiring manual management of a buffer, instead of using seq_file, which is commonly used for virtual files. ChenYu > --- > changed with v4: > - rebase to the top of media stage header. > > changed with v3: > - add help function for patch 8 > - remove append '\0' and enlarge buffer size for patch 4 > > changed with v2: > - using pr_debug and dev_dbg instead of pr_info for patch 2. > - fix word fail: informatiaoin -> information for patch 3. > - used to print each instance format information for patch 5. > > changed with v1: > - add new patch 4 and 5. > - using cmd 'cat vdec' to show debug information instead of pr_info direc= tly. > --- > Yunfei Dong (8): > media: mediatek: vcodec: Add debugfs interface to get debug > information > media: mediatek: vcodec: Add debug params to control different log > level > media: mediatek: vcodec: Add a debugfs file to get different useful > information > media: mediatek: vcodec: Get each context resolution information > media: mediatek: vcodec: Get each instance format type > media: mediatek: vcodec: Change dbgfs interface to support encode > media: mediatek: vcodec: Add encode to support dbgfs > media: mediatek: vcodec: Add dbgfs help function > > .../media/platform/mediatek/vcodec/Makefile | 6 + > .../mediatek/vcodec/mtk_vcodec_dbgfs.c | 216 ++++++++++++++++++ > .../mediatek/vcodec/mtk_vcodec_dbgfs.h | 72 ++++++ > .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + > .../platform/mediatek/vcodec/mtk_vcodec_drv.h | 4 + > .../mediatek/vcodec/mtk_vcodec_enc_drv.c | 2 + > .../mediatek/vcodec/mtk_vcodec_util.c | 8 + > .../mediatek/vcodec/mtk_vcodec_util.h | 26 ++- > 8 files changed, 335 insertions(+), 3 deletions(-) > create mode 100644 drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbg= fs.c > create mode 100644 drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbg= fs.h > > -- > 2.25.1 >