From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F49C4338F for ; Wed, 25 Aug 2021 02:14:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9AE761368 for ; Wed, 25 Aug 2021 02:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237062AbhHYCPU (ORCPT ); Tue, 24 Aug 2021 22:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235700AbhHYCPR (ORCPT ); Tue, 24 Aug 2021 22:15:17 -0400 Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1C78C061764 for ; Tue, 24 Aug 2021 19:14:27 -0700 (PDT) Received: by mail-oo1-xc29.google.com with SMTP id j11-20020a4a92cb000000b002902ae8cb10so1820361ooh.7 for ; Tue, 24 Aug 2021 19:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EqCJDw6pwwqcA3u963UfsU6r31LKcgwNEuHo0x3pVt4=; b=PHELEcFGD+KCRb+ykFErfan7cTCGvFBynYZyiUM07izhx1J9Dq48E13dItIRSbzf9x mmKfAhGY3hJVqpeCLG7FVGeNzdNi/MugPEQFQqpNWcXzD6B7Ab7VXgW/PicyapTAAyF9 DdnTKClFljT2/ZCX45WzsUVpEA8I0CaevOmLhY9joRwuYZR/jJ3VAevFyest4vAK3eSn 1BXS9KeFieeeVlpfVRdUeYDe1U9Gk9y+zjK+V0TAaeOjhnkDK4SIrWetY4U0kHnQKIZc mFJsFVl8X5oia0wgoD0RwQRu2rVd3CtAVyWR9pr6G5fcbfdN+wNY830dyECo+EuBM7UE CX4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EqCJDw6pwwqcA3u963UfsU6r31LKcgwNEuHo0x3pVt4=; b=EfXcFh34+EA1j/821heIbRFQwC2/APcsWGw1t19XGZkt11qDusI/QOXyninqeeUUE3 lOwgAKEj/Gqteg0YMKz6YsPc5ZGxAs1Apjwn9n/Ub+9y+TdmeYQoJ+Cqgf8Rb9Fr1Unc M0DyGL1qeum+hmEUEmDTAKcuF6Dl7e1esKyDQqQaBkZeC7vnhf0Kgonvc7sQDMdz2qTo QisJk/7Aa94PwdFZMHxMUL0G6ZlaHSdv+2YqYab21Yc7tkDBhFer7FnaA8FejTf6y6gT GTzjX809Pg90/1OLHH59p8DoaPFmSQeMz87UC63aV+ZHdikjalHsvuhRBCD9PlnnNl6t viZg== X-Gm-Message-State: AOAM533Tt4sn0Btwautgiu4ooPyK6ROrnx+r4jSvC9lTowQRN1S/QeWC YhDrd36ol4AR+isOkaome0p5WHeE5zhqNF15eet0Gw== X-Google-Smtp-Source: ABdhPJwGdyLaOrvtYRVGttPSukOVCRVyx+hg8mPlVBNhC/K0UG/FYc5Wa1O4T8axKx/aN0mDFUp1YoufiSBg5dsuJnI= X-Received: by 2002:a4a:754b:: with SMTP id g11mr32762267oof.10.1629857667201; Tue, 24 Aug 2021 19:14:27 -0700 (PDT) MIME-Version: 1.0 References: <20210617220229.7352-1-zev@bewilderbeest.net> In-Reply-To: <20210617220229.7352-1-zev@bewilderbeest.net> From: Lei Yu Date: Wed, 25 Aug 2021 10:14:16 +0800 Message-ID: Subject: Re: [Phishing Risk] [External] [PATCH v3] media: aspeed-video: ignore interrupts that aren't enabled To: Zev Weiss Cc: Eddie James , "moderated list:ARM/ASPEED MACHINE SUPPORT" , openbmc , open list , Mauro Carvalho Chehab , "moderated list:ARM/ASPEED MACHINE SUPPORT" , linux-media@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Jun 18, 2021 at 6:02 AM Zev Weiss wrote: > > As partially addressed in commit 65d270acb2d6 ("media: aspeed: clear > garbage interrupts"), the ASpeed video engine sometimes asserts > interrupts that the driver hasn't enabled. In addition to the > CAPTURE_COMPLETE and FRAME_COMPLETE interrupts dealt with in that > patch, COMP_READY has also been observed. Instead of playing > whack-a-mole with each one individually, we can instead just blanket > ignore everything we haven't explicitly enabled. > > Signed-off-by: Zev Weiss > --- > > Changes since v2 [1]: > - minor commit message improvements > > Changes since v1 [0]: > - dropped error message > - switched to a blanket-ignore approach as suggested by Ryan > > [0] https://lore.kernel.org/linux-arm-kernel/20201215024542.18888-1-zev@bewilderbeest.net/ > [1] https://lore.kernel.org/openbmc/20210506234048.3214-1-zev@bewilderbeest.net/ > > drivers/media/platform/aspeed-video.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > index 7bb6babdcade..77611c296a25 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -563,6 +563,12 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) > struct aspeed_video *video = arg; > u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS); > > + /* > + * Hardware sometimes asserts interrupts that we haven't actually > + * enabled; ignore them if so. > + */ > + sts &= aspeed_video_read(video, VE_INTERRUPT_CTRL); > + Without the patch, the driver gets an unhandled IRQ in a few hours after the KVM page is opened. This patch is tested on Bytedance's OpenBMC system and the issue has not been reproduced anymore. Tested-by: Lei YU -- BRs, Lei YU