From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 297ECC2D0BF for ; Thu, 5 Dec 2019 07:31:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3367206DB for ; Thu, 5 Dec 2019 07:31:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=qtec.com header.i=@qtec.com header.b="bsN/dzuV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726243AbfLEHbO (ORCPT ); Thu, 5 Dec 2019 02:31:14 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:41253 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725926AbfLEHbO (ORCPT ); Thu, 5 Dec 2019 02:31:14 -0500 Received: by mail-ed1-f66.google.com with SMTP id c26so1753348eds.8 for ; Wed, 04 Dec 2019 23:31:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtec.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5bZTVLB6SlZZvHSZ52IQ5R9DgapBKk835vt1/NqLuFM=; b=bsN/dzuVIYXI1ejuF6K83PYcEMFOMOeUaB9u1lISiTkBdZZHwNYggeimMOG9be7uOD 9wCQM0eAY3DUWwfgeDzrcFCzL4GnUrsKlDaczEPOHAV1GjxsDV1MkV6VkOAmorbuhymL kwMhThITg49GiY2StsdjLBlt5N5cukkLp/ydQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5bZTVLB6SlZZvHSZ52IQ5R9DgapBKk835vt1/NqLuFM=; b=C3AgxQN15exSABvErx9J99Z+1big+5J7pPz6jlRMCCGgjTdjx7zsFkHPPuGoclX0FH iKTAPA7WQtlOX41KRnTqmkE58QyyTnyAdjoaVuWIPJ1AGUcjS54yiZijZu4w7U2qfiDc eehsAZMhe3B0fttupGCtXxFNWZAqBKgrlQCcKWU1Bu5Dt0ESkuGaUFh5Y6CsMHSWqOp+ hd2ewAiDFF//OLEMSZX52S+lXuc13q4eXd40jKpk0goTIRO7DOGuFsWZfuBaM0eL1QmS 1Meo2zndlBMBQ0ued29mANQrsH64ggWQYCPUSDATGRAFdSgIuVnWTY9L/lBT7XZxREcy e4Bg== X-Gm-Message-State: APjAAAUZCVO3l04/2bBq65/uH2rQdWBZwEN4tJQGYxAEn3pdHeBhEbm1 OCEoBMC2rNqhAE7Fb0EMZMGQXAd15OQaTt0R4/UEPA== X-Google-Smtp-Source: APXvYqzzYaQTO/FR95xhPh9Wrn+4C+E8T1axiWOzdH3Skzt6J/P5+5UvQfwaBbkT2D+o1N25fFQjgCHPEMcNWQkZds0= X-Received: by 2002:a17:906:82ca:: with SMTP id a10mr7937423ejy.40.1575531071920; Wed, 04 Dec 2019 23:31:11 -0800 (PST) MIME-Version: 1.0 References: <20191203151202.18081-1-daniel@qtec.com> <20191204113046.GF5282@valkosipuli.retiisi.org.uk> In-Reply-To: <20191204113046.GF5282@valkosipuli.retiisi.org.uk> From: Daniel Gomez Date: Thu, 5 Dec 2019 08:31:00 +0100 Message-ID: Subject: Re: [PATCH] media: v4l2: Fix fourcc names for BAYER12P To: Sakari Ailus Cc: Mauro Carvalho Chehab , Linux Media Mailing List , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Sakari, On Wed, 4 Dec 2019 at 12:31, Sakari Ailus wrote: > > Hi Daniel, > > On Tue, Dec 03, 2019 at 04:12:00PM +0100, Daniel Gomez wrote: > > Fix documentation fourcc names for the 12-bit packed Bayer formats. > > > > Signed-off-by: Daniel Gomez > > --- > > Documentation/media/uapi/v4l/pixfmt-srggb12p.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst b/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst > > index 960851275f23..7060a4ffad08 100644 > > --- a/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst > > +++ b/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst > > @@ -13,7 +13,7 @@ > > .. _v4l2-pix-fmt-sgrbg12p: > > > > ******************************************************************************************************************************* > > -V4L2_PIX_FMT_SRGGB12P ('pRAA'), V4L2_PIX_FMT_SGRBG12P ('pgAA'), V4L2_PIX_FMT_SGBRG12P ('pGAA'), V4L2_PIX_FMT_SBGGR12P ('pBAA'), > > +V4L2_PIX_FMT_SRGGB12P ('pBCC'), V4L2_PIX_FMT_SGRBG12P ('pgCC'), V4L2_PIX_FMT_SGBRG12P ('pGCC'), V4L2_PIX_FMT_SBGGR12P ('pBCC'), > > ******************************************************************************************************************************* > > Thanks for the patch. > > There's a bug there, but this doesn't still seem entirely correct. For > instance, V4L2_PIX_FMT_SRGGB12P is defined as follows in videodev2.h: > > #define V4L2_PIX_FMT_SRGGB12P v4l2_fourcc('p', 'R', 'C', 'C') > > Could you fix that, and check the rest? Thanks for the review. I'll send a new patch with the proper names: include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SBGGR12P v4l2_fourcc('p', 'B', 'C', 'C') include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SGBRG12P v4l2_fourcc('p', 'G', 'C', 'C') include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SGRBG12P v4l2_fourcc('p', 'g', 'C', 'C') include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SRGGB12P v4l2_fourcc('p', 'R', 'C', 'C') > > Please also set the To: header to a valid value; not setting it sometimes > ends up replies being only sent to the original sender of the patch, > omitting the list and others cc'd. > okay. > -- > Kind regards, > > Sakari Ailus