From: Adam Ford <aford173@gmail.com>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: linux-media <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Steve Longerbeam <slongerbeam@gmail.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Adam Ford <adam.ford@logicpd.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: ov5640: Fix check for PLL1 exceeding max allowed rate
Date: Thu, 28 Nov 2019 08:28:49 -0600 [thread overview]
Message-ID: <CAHCN7xJpa68bB+acaywq+ca0sG0gYXM2wBiK=50KWLVp6e-9FA@mail.gmail.com> (raw)
In-Reply-To: <20191128102141.beq7wzdu5vxwx7wk@uno.localdomain>
On Thu, Nov 28, 2019 at 4:19 AM Jacopo Mondi <jacopo@jmondi.org> wrote:
>
> Hi Adam,
>
> On Tue, Nov 26, 2019 at 08:08:05PM -0600, Adam Ford wrote:
> > On Tue, Oct 29, 2019 at 7:42 AM Adam Ford <aford173@gmail.com> wrote:
> > >
> > > The variable _rate is by ov5640_compute_sys_clk() which returns
> > > zero if the PLL exceeds 1GHz. Unfortunately, the check to see
> > > if the max PLL1 output is checking 'rate' and not '_rate' and
> > > 'rate' does not ever appear to be 0.
>
> This seems a bit convoluted. What about:
>
> "The PLL calculation routine checks the wrong variable 'rate' to
> verify that the calculated PLL1 output frequency does not exceed
> 1GHz. Fix this by using the correct '_rate' one."
>
> Or something against these lines
That makes sense.
I'll do a V2 for this patch and change the description and add your
'acked-by' note to it.
I probably won't get to it until this weekend, since today is a
holiday in the US, and I am traveling.
adam
>
> > >
> > > This patch changes the check against the returned value of
> > > '_rate' to determine if the PLL1 output exceeds 1GHz.
> > >
> > > Fixes: aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate")
> > >
> >
> > I haven't seen any responses to this patch. Has anyone had a chance
> > to review this? It's been nearly a month.
>
> You're totally right! Sorry about this
>
> > I think it would be appropriate to backport to stable if deemed acceptable.
> >
>
> Indeed! This fixes a real issue
>
> Acked-by: Jacopo Mondi <jacopo@jmondi.org>
>
> Thanks
> j
>
> > adam
> >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > >
> > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> > > index 5e495c833d32..bb968e764f31 100644
> > > --- a/drivers/media/i2c/ov5640.c
> > > +++ b/drivers/media/i2c/ov5640.c
> > > @@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
> > > * We have reached the maximum allowed PLL1 output,
> > > * increase sysdiv.
> > > */
> > > - if (!rate)
> > > + if (!_rate)
> > > break;
> > >
> > > /*
> > > --
> > > 2.17.1
> > >
prev parent reply other threads:[~2019-11-28 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 12:42 [PATCH] media: ov5640: Fix check for PLL1 exceeding max allowed rate Adam Ford
2019-11-27 2:08 ` Adam Ford
2019-11-28 10:21 ` Jacopo Mondi
2019-11-28 14:28 ` Adam Ford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHCN7xJpa68bB+acaywq+ca0sG0gYXM2wBiK=50KWLVp6e-9FA@mail.gmail.com' \
--to=aford173@gmail.com \
--cc=adam.ford@logicpd.com \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).