From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1809DC43603 for ; Wed, 4 Dec 2019 13:38:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E10E9205ED for ; Wed, 4 Dec 2019 13:37:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bTlKA8wS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbfLDNhz (ORCPT ); Wed, 4 Dec 2019 08:37:55 -0500 Received: from mail-il1-f193.google.com ([209.85.166.193]:42268 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727530AbfLDNhz (ORCPT ); Wed, 4 Dec 2019 08:37:55 -0500 Received: by mail-il1-f193.google.com with SMTP id f6so6681138ilh.9; Wed, 04 Dec 2019 05:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+b0g+KEhsGSbMr8f59QsRUNDcK99rmsk3xClHRajYv8=; b=bTlKA8wS/DozQEHHB74GZRbgit+aAQ2EVrDJt4zQLpUQVHEF8Wdt6zUpqlZBJTHZ1W uXsNxfknQ6aRLAHOheTyuDb3+Rfrn02TZqFpV90i9NSNrWWbOiHiE9jWiq5kdoPe5CJC iGWeaabMNepDBWuR7WT+hdRSeVZ3UlVdLb0b+5p03aAmt6FFMTTqj1JD7DESZEZe9d00 CYG6NmzJ2CuTPyuA4jk5lVXpt/EOY/tEdeXjccSUf+NEk/W6DsMv348e6TIl2TeMTKns e5iK6Yn/+yxd2pZYda7EB4SSfiAm3bO0Llp31CL/minmalQ17DDKbOEEBlOYoKbtQyk0 4hYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+b0g+KEhsGSbMr8f59QsRUNDcK99rmsk3xClHRajYv8=; b=hMrY3jQPl3UYXWDBI+taWWkVs14ynXJ0b3t3drZsYkMUVXnTqKYsVIxxEBUIQBVEav LFCJNTW5Cpm0mUquvJEZELYGSG1mEfmVp6NZxdDqW0cKjSMgKpsmq2CiMJWo165yXo3+ Mv3L/RFZg4TEfiIujENZ00+mCZBVtatelq7S8UtSubQfzew4+taWSLaN3cGHslq6HmTB /ikbDhHdrWpLd41FXs8umJJqc4hYZ7jjHr8zktlFpEwKuoea2nTY5jR+9BPAQjsye5rC dYmfh0KjksEEPGIXCK2yga45pmozCh5ZuJCccmQNufXE3co4/mUhOxxYb0n9LNNkgdl3 lkKA== X-Gm-Message-State: APjAAAWxp5SYLOAii12iAMEdKtqfV6hqdvzK7mgIyMAJ5Rv1bMKKFMuI oewKv+8lGncXrZXhc7Z2vautaLS+zXenaQ5/SdJ4Fq6z X-Google-Smtp-Source: APXvYqz+4eY7fzeIA115HzD2/HdBg2qM64eGapJRh5UfVXMSymTEddhoTmqudiohtFS9r9NQfo+tWtwY5jBi/vYua+E= X-Received: by 2002:a05:6e02:c2c:: with SMTP id q12mr3496269ilg.205.1575466674334; Wed, 04 Dec 2019 05:37:54 -0800 (PST) MIME-Version: 1.0 References: <20191204130907.19799-1-aford173@gmail.com> <20191204132557.pl6rwfprtcwewato@uno.localdomain> In-Reply-To: <20191204132557.pl6rwfprtcwewato@uno.localdomain> From: Adam Ford Date: Wed, 4 Dec 2019 07:37:43 -0600 Message-ID: Subject: Re: [PATCH V2] media: ov5640: Fix check for PLL1 exceeding max allowed rate To: Jacopo Mondi Cc: linux-media , Adam Ford , Steve Longerbeam , Mauro Carvalho Chehab , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Dec 4, 2019 at 7:23 AM Jacopo Mondi wrote: > > Hi Adam, > > On Wed, Dec 04, 2019 at 07:09:07AM -0600, Adam Ford wrote: > > The PLL calculation routine checks the wrong variable name 'rate' > > when it should be called '_rate' when checking to see whether or > > not the PLL1 output frequency exceeds 1GHz. > > > > This patch changes it to the correct variable '_rate' > > > > Acked-by: Jacopo Mondi > > Signed-off-by: Adam Ford > > Why have you dropped the fixes tag you had in v1? > > Fixes: aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate") > > I'm not the one who collects patches, so maybe wait for Sakari or Hans > to tell you if you need to resend or not :) It wasn't intentional. I couldn't find the original patch nor could I find it in patchwork, so I re-did it from scratch and forgot. (I have too many different computers) I already sent a V3 before I read your e-mail. Sorry about that. adam > > Thanks > j > > > --- > > V2: No code change. Only change commit description to be less confusing. > > > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > > index 5e495c833d32..bb968e764f31 100644 > > --- a/drivers/media/i2c/ov5640.c > > +++ b/drivers/media/i2c/ov5640.c > > @@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor, > > * We have reached the maximum allowed PLL1 output, > > * increase sysdiv. > > */ > > - if (!rate) > > + if (!_rate) > > break; > > > > /* > > -- > > 2.20.1 > >