From: Tomasz Figa <tfiga@chromium.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Ezequiel Garcia <ezequiel@collabora.com>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Jonas Karlman <jonas@kwiboo.se>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Sasha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag
Date: Thu, 5 Sep 2019 19:31:37 +0900 [thread overview]
Message-ID: <CAHD77H=q48Zx=dWMOMT527au8FzKZdQ9SrRr4sos8oNfCeCzQw@mail.gmail.com> (raw)
In-Reply-To: <20190905101533.525-1-p.zabel@pengutronix.de>
On Thu, Sep 5, 2019 at 7:15 PM Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> This flag tells the kernel whether the slice header contained the
> num_ref_idx_l[01]_active_minus1 syntax elements, or whether the
> num_ref_idx_l[01]_default_active_minus1 from PPS should be used
> instead.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 3 +++
> include/media/h264-ctrls.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> index bc5dd8e76567..451a5b0f2a35 100644
> --- a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> +++ b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> @@ -1860,6 +1860,9 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type -
> * - ``V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH``
> - 0x00000008
> -
> + * - ``V4L2_H264_SLICE_FLAG_NUM_REF_IDX_ACTIVE_OVERRIDE
> + - 0x00000010
> + - Corresponds to the num_ref_idx_active_override_flag syntax element.
>
As far as I remember, the idea was for the userspace to always put the
right num_ref_idx in the slice_params and the drivers always use that.
Was there any problem with that?
Best regards,
Tomasz
> ``Prediction Weight Table``
>
> diff --git a/include/media/h264-ctrls.h b/include/media/h264-ctrls.h
> index e877bf1d537c..dab519aea9bf 100644
> --- a/include/media/h264-ctrls.h
> +++ b/include/media/h264-ctrls.h
> @@ -133,6 +133,7 @@ struct v4l2_h264_pred_weight_table {
> #define V4L2_H264_SLICE_FLAG_BOTTOM_FIELD 0x02
> #define V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED 0x04
> #define V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH 0x08
> +#define V4L2_H264_SLICE_FLAG_NUM_REF_IDX_ACTIVE_OVERRIDE 0x10
>
> struct v4l2_ctrl_h264_slice_params {
> /* Size in bytes, including header */
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-09-05 10:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 10:15 [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag Philipp Zabel
2019-09-05 10:15 ` [PATCH 2/2] media: hantro: h264: per-slice num_ref_idx_l[01]_active override Philipp Zabel
2019-09-05 10:34 ` Tomasz Figa
2019-09-05 11:04 ` Philipp Zabel
2019-09-05 10:31 ` Tomasz Figa [this message]
2019-09-05 10:39 ` [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag Philipp Zabel
2019-09-05 14:17 ` Nicolas Dufresne
2019-09-09 7:09 ` Tomasz Figa
2019-09-09 7:30 ` Philipp Zabel
2019-09-09 9:40 ` Tomasz Figa
2019-10-03 21:06 ` Paul Kocialkowski
2019-10-03 21:07 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHD77H=q48Zx=dWMOMT527au8FzKZdQ9SrRr4sos8oNfCeCzQw@mail.gmail.com' \
--to=tfiga@chromium.org \
--cc=boris.brezillon@collabora.com \
--cc=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).