From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C48C4361B for ; Thu, 10 Dec 2020 13:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3055423D6C for ; Thu, 10 Dec 2020 13:06:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387816AbgLJNEz (ORCPT ); Thu, 10 Dec 2020 08:04:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731240AbgLJNEy (ORCPT ); Thu, 10 Dec 2020 08:04:54 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABF3FC0613D6; Thu, 10 Dec 2020 05:04:14 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id o4so4179122pgj.0; Thu, 10 Dec 2020 05:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=92Wh2LQtBXzTX4NkNdCAHhIqaKi2BFUPf+cbDuzZ2dM=; b=FBMPE2JaoBmrOk3y40Mrmo8b1Mvkmv7ogxXi/Fxml/kMrLZjoWb3g6V1eeHeaSuBf6 lpP6yv9RhhduV0xpST+COmF6of3lXMi9gdBpiz16bzy7tscOk2EdY8Oa5EJll5qrMII7 rMGmNJmTsIg+86qlY0EF9tEuPhIopz0sTxiYSrPJFA6wQi510LFJQxKGBH90CVlOjT6T 8wisBOIVM8xpVLOUpvDc7PeJTu5hKYlpznhQVb0wdXzBuzeI9ZnTyEII/X+zoEuZTOmy e0q+nZlanVaFzW9lBFv9yM/QNrG+7Fhf+HYGlM59T7cJlFye0iospfsZZ+1JLXWmD0Sp t2IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=92Wh2LQtBXzTX4NkNdCAHhIqaKi2BFUPf+cbDuzZ2dM=; b=H3tWHBd0rSkIVcg99qFd6KcJNbxHElVdKAoHnyeNgu3afc1dwxAJlOb7wyNUWsu0nL jU/tn1T7+sPYLlfG2MxrKgFAsHTzdGCJXjn6gq2Nu/31VPgzWV9rj7VX9O1hgcm0H+NL GNR8/unGpqJL+ujpWdX/vdXvSWN98WBJPrI7ixDf6KOJiMF1nyDGc1z/rQVVWLXfZHu+ kF1bVXI7zqXlfaiZd6lpdbBgc6+Qk7LtditmVuH5w4X1XG4h0eOJR3o08FrlF0dEnvTu WUvX8Eb1+k0qbncQUVtoVrmhH8ZkjEb7aGeGND05v18uysXokeLkPMYuDtLfIRGGfpxG lOFA== X-Gm-Message-State: AOAM5331z9D9CVBytrM7oyo9y48+HxNqGmvohqUVYCeD+6uXkOUqOrYR VsG3JBlQZzoY59YdXA29/Av2//c7CGCyWc5MBj0= X-Google-Smtp-Source: ABdhPJx6pQh8UTUI6wTm+2am3BYMKhPGQWSY4Ulu5ZwL6w0nVgmYWZh7f4gx79f7WBvYQAFphvYasrY2UUg54Dkc8U8= X-Received: by 2002:a17:90a:34cb:: with SMTP id m11mr7555981pjf.181.1607605454205; Thu, 10 Dec 2020 05:04:14 -0800 (PST) MIME-Version: 1.0 References: <20201113105441.1427-1-sakari.ailus@linux.intel.com> In-Reply-To: From: Andy Shevchenko Date: Thu, 10 Dec 2020 15:05:02 +0200 Message-ID: Subject: Re: [PATCH v5 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs To: Petr Mladek Cc: Sakari Ailus , Linux Kernel Mailing List , Linux Media Mailing List , Andy Shevchenko , Dave Stevenson , dri-devel , Hans Verkuil , Laurent Pinchart , Mauro Carvalho Chehab , Sergey Senozhatsky , Steven Rostedt , Joe Perches , Jani Nikula , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Dec 10, 2020 at 2:16 PM Petr Mladek wrote: > On Fri 2020-11-13 12:54:41, Sakari Ailus wrote: > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by fourccs. The fourcc encoding is the same for both > > so the same implementation can be used. > > > > Suggested-by: Mauro Carvalho Chehab > > Signed-off-by: Sakari Ailus > > Andy, Rasmus, > > the last version looks fine to me. I am going to push it. > Please, speak up if you are against it. My concerns are: - not so standard format of representation (why not to use string_escape_mem() helper?) or is it? - no compatibility with generic 4cc (I would rather have an additional specifier here for v4l2 cases. OTOH generic %p4cc to me sounds like an equivalent to %4pEh (but we have similar cases with MAC where %6ph is the same as %pM). But I'm not insisting on them, consider it like just my 2 cents to the discussion. -- With Best Regards, Andy Shevchenko