From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4ED6C4338F for ; Thu, 19 Aug 2021 17:24:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A4DE61075 for ; Thu, 19 Aug 2021 17:24:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232918AbhHSRZ3 (ORCPT ); Thu, 19 Aug 2021 13:25:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230058AbhHSRZ1 (ORCPT ); Thu, 19 Aug 2021 13:25:27 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E754C061575; Thu, 19 Aug 2021 10:24:51 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id e7so6519240pgk.2; Thu, 19 Aug 2021 10:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UYd2dapw2LMwvOwjrvllB89XLpc87giCIS2NMpFO4KE=; b=c60+UAjN01E/MyS6qz7JtawFf1HTe4XNk03E930VEgOBPRVjBDqBVsklwYJuniYGs1 LGe9Fo/Kv+y7utUO1bkuePODvr28k5c0B7ThjmTWITZ0yjKvazUzVvjc63g8y7PO0KJX z2Q6s9b91XIlSkvT4TFBoV4hCfk7XQNOyCyDoOjMeOgJFoSXToxHGl2zf3ZglwXNHILA 5nBX9cKXyOadqOmLtqSJwqYV05VbMa04EIULWevIDHDlifn5mbnvs1dWl40gadZ4xbM2 6a7eoSJwbBNdl0qdG8FUhC1/pAIuyY1GF34qEcVjx1qmi6IJ7IuG+LTd+ftkXYv/zakr fe6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UYd2dapw2LMwvOwjrvllB89XLpc87giCIS2NMpFO4KE=; b=OERfVJjzZbz7nEwDyGnUWjpWPCL6hAl3GPYewqBfQh9gpXwXOyXQdrdz7w4Awq9GaF dWdvzyiT+8rswZ7WQ5LtaiS01eRGIAOTtHopiZ5pWLKNgdkXsApjWmF8t5/VmRrO3/df qIymz+FdC5QsZPpzFuPtsUkXbdjqXLIuRloXXwsmHFeV5G1pmLbAEXZrXsxqIVV+jLKy vbpWftyeilQqQs82WuNm0Sjw3+xNFBVLYCHz6TZNgVutHEOoDkyi0VE9tmWphMXGtSEL GvLGPsHXzpZyXKAWlaX9TzLaM62lqLZtUXBO0WB+lvnaOgVNcHXy87+FQxxmxTf2m0vT tNVg== X-Gm-Message-State: AOAM530jbqSrI1E7ZfOw82GXoZ03p/HURuY+PcHoz7sClVe+MS9B7pzH Hqk1zVd5E99rBxE+q8Lp4UCJa7jHlf/0iojyCY8= X-Google-Smtp-Source: ABdhPJysYPrZmoa4UFLdVe+0TKMVAoZZGvmIcU6EffmYwkLJhVyd3WbKXreA9JSgPXu/YBIo/JraQJfnWgEJoSnO5CY= X-Received: by 2002:aa7:9618:0:b0:3e2:1bc3:aa93 with SMTP id q24-20020aa79618000000b003e21bc3aa93mr15746883pfg.73.1629393890934; Thu, 19 Aug 2021 10:24:50 -0700 (PDT) MIME-Version: 1.0 References: <20210802143820.1150099-1-arnd@kernel.org> <202108130937.7848F6B318@keescook> In-Reply-To: <202108130937.7848F6B318@keescook> From: Andy Shevchenko Date: Thu, 19 Aug 2021 20:24:11 +0300 Message-ID: Subject: Re: [PATCH] media: atomisp: restore missing 'return' statement To: Kees Cook Cc: Arnd Bergmann , Mauro Carvalho Chehab , Greg Kroah-Hartman , Pavel Skripkin , Arnd Bergmann , Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Aug 13, 2021 at 7:39 PM Kees Cook wrote: > > On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The input_system_configure_channel_sensor() function lost its final > > return code in a previous patch: > > > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor': > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type] > > > > Restore what was there originally. > > > > Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code") > > Signed-off-by: Arnd Bergmann > > I hit this too. Thanks! > > Reviewed-by: Kees Cook Me too, Tested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Pavel, how have you tested it? -- With Best Regards, Andy Shevchenko