From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Daniel Scally" <djrscally@gmail.com>,
"Daniel Scally" <dan.scally@ideasonboard.com>,
bingbu.cao@linux.intel.com, platform-driver-x86@vger.kernel.org,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, "Bingbu Cao" <bingbu.cao@intel.com>,
"Hao Yao" <hao.yao@intel.com>
Subject: Re: [PATCH v2] platform/x86: int3472: Evaluate device's _DSM method to control imaging clock
Date: Tue, 6 Jun 2023 14:29:25 +0300 [thread overview]
Message-ID: <CAHp75Vdm-srbyTXmR_g_FziVGOdUaWskHVFW=gOet_YyEY2HAQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vc7fq=PK5vN5Ya6yMRG3VCFhfwBVobxsSKYwKUyWnDq3g@mail.gmail.com>
On Tue, Jun 6, 2023 at 2:26 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, Jun 6, 2023 at 12:23 PM Hans de Goede <hdegoede@redhat.com> wrote:
> > On 5/31/23 19:56, Andy Shevchenko wrote:
...
> > Ack, I've squashed a fix for this into this patch while merging it into
> > my review-hans branch.
>
> Now you have two different checks for the same, I would suggest that
> you switch to check clk->cl in the skl_int3472_enable_clk()
> as it's done in the skl_int3472_register_dsm_clock() instead of GPIO.
> Other way around is also possible but it seems to me that checking for
> clock existence has better guarantees than just checking for GPIO
> availability.
That said it might make sense to also introduce
struct ... *clk = &int3472->clock;
in skl_int3472_register_dsm_clock() so the above mentioned checks will
be the same and actually code in the latter will look neater (?).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-06 11:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 13:44 [PATCH v2] platform/x86: int3472: Evaluate device's _DSM method to control imaging clock Hans de Goede
2023-05-31 14:45 ` Dan Scally
2023-06-06 9:20 ` Hans de Goede
[not found] ` <CAHp75VfZN5M8LiP3nw0NT5p3WyJJJJm6w2OZKgm28b6aokzopQ@mail.gmail.com>
2023-06-06 9:23 ` Hans de Goede
2023-06-06 11:26 ` Andy Shevchenko
2023-06-06 11:29 ` Andy Shevchenko [this message]
2023-06-06 13:13 ` Hans de Goede
2023-06-06 13:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vdm-srbyTXmR_g_FziVGOdUaWskHVFW=gOet_YyEY2HAQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=djrscally@gmail.com \
--cc=hao.yao@intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).