From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Tsuchiya Yuto <kitakar@gmail.com>,
Bingbu Cao <bingbu.cao@intel.com>, Yong Zhi <yong.zhi@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>
Subject: Re: [PATCH 2/3] ipu3-cio2: Serialise access to pad format
Date: Fri, 9 Oct 2020 19:17:25 +0300 [thread overview]
Message-ID: <CAHp75VeUWd0g7Yyd8wXOrPbwGHsKHS+=+UMPBdhcup4fUVsn+Q@mail.gmail.com> (raw)
In-Reply-To: <20201008204747.26320-3-sakari.ailus@linux.intel.com>
On Fri, Oct 9, 2020 at 12:44 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> Pad format can be accessed from user space. Serialise access to it.
...
> /* Initialize miscellaneous variables */
> mutex_init(&q->lock);
> + mutex_init(&q->subdev_lock);
...
> mutex_destroy(&q->lock);
> + mutex_destroy(&q->subdev_lock);
A nit: perhaps reversed order?
> mutex_destroy(&q->lock);
> + mutex_destroy(&q->subdev_lock);
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-09 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 20:47 [PATCH 0/3] ipu3-cio2 format fixes Sakari Ailus
2020-10-08 20:47 ` [PATCH 1/3] ipu3-cio2: Return actual subdev format Sakari Ailus
2020-10-09 0:39 ` Laurent Pinchart
2020-10-08 20:47 ` [PATCH 2/3] ipu3-cio2: Serialise access to pad format Sakari Ailus
2020-10-09 0:44 ` Laurent Pinchart
2020-10-09 9:43 ` Sakari Ailus
2020-10-09 10:39 ` Laurent Pinchart
2020-10-09 16:17 ` Andy Shevchenko [this message]
2020-10-08 20:47 ` [PATCH 3/3] ipu3-cio2: Only allow setting valid mbus codes Sakari Ailus
2020-10-09 0:49 ` Laurent Pinchart
2020-10-09 9:44 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeUWd0g7Yyd8wXOrPbwGHsKHS+=+UMPBdhcup4fUVsn+Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).