From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 463E7C388F7 for ; Thu, 22 Oct 2020 13:39:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D023020790 for ; Thu, 22 Oct 2020 13:39:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uuzbSiMI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502123AbgJVNji (ORCPT ); Thu, 22 Oct 2020 09:39:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2444217AbgJVNjh (ORCPT ); Thu, 22 Oct 2020 09:39:37 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D57DC0613CE; Thu, 22 Oct 2020 06:39:37 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id o1so1045363pjt.2; Thu, 22 Oct 2020 06:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b3AVo2emPLkcZF8hW3nQ46IEFziYrCYUxWf0tqXrKb4=; b=uuzbSiMIqbW4lrdsO5PXIzxsvCt/uxlqrBpaQ1b8FLTBQYLFDsNfYey2hRinJQp2FH IoL4UG+O9do4Wr0hLc3LO3xAKMyEzONxuocxYYfGoMZ1xWUXGWSTegnUY0YOPaan4uyt FhAMGAylucQbDRT+vZjrSspmz5lmG4FtSSXekAxd0KIXMXqeXp7js+g7EENQVpznCK99 P70k/RZvRkfm8FJu2+5g5N6xgOG8XY+r5ZCxDMljHLqSmKQhYpA6pgJXvtRloi6Z8Pqi A9zS0CngtsnNoRz6X9FUoKIaYIameFxKlVxeX2XKrUJFxE2s41ffqVnqsN+v3tQelkKf FX6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b3AVo2emPLkcZF8hW3nQ46IEFziYrCYUxWf0tqXrKb4=; b=QnI18eRM6QYSgiF2rt4P+TeBpyyj0XDWMv96cEWHYUJAQGkalvJz/GKBuG/uzIdp+K YaYRbKbadxrI2GDjbu23l47ytyTvHm7mCPrIX6OqH9DXAfX0uhKu/9UjNxTsbbNJ0IPx PEUOmluc+dhn66PlLNyzCz5SqKU0urILcqEdQQeYClU8vYfFBV3oSf9LqlBsILFjg/Pr Y1Trh0/46Ae9zXaS6CtWjGrh3dpiaYnlPWgRc0uSGYYaizY6gnIIBz9FEtKpnQSfaqor SbNLqBuLQudlC1wxyUCXanX5JAoOnewNQsxotGcoexOhpQ/ME4OoOwF2tDy0bswbaNOf ucSw== X-Gm-Message-State: AOAM530/29b65hzgQvzpKxJHi7sxMZsvy8E2G1uByVT6GT6YwnqN3T3d 7f+IhvrRQx0W98tRY0dnLH4X5ufMyNtBSgC/308= X-Google-Smtp-Source: ABdhPJwUPybuMxgPq8dMoHqmmBjU6A75kvif4dG6aK5EaG1sAwDerRoIr5JrRgv4UmK8xFGVjML4nPKdLllGXgzu6Go= X-Received: by 2002:a17:90b:305:: with SMTP id ay5mr2468573pjb.129.1603373976635; Thu, 22 Oct 2020 06:39:36 -0700 (PDT) MIME-Version: 1.0 References: <20201019225903.14276-1-djrscally@gmail.com> <20201019225903.14276-10-djrscally@gmail.com> <20201020094113.GG4077@smile.fi.intel.com> <4ce5b55f-f492-2b52-5571-86ee346db795@gmail.com> In-Reply-To: <4ce5b55f-f492-2b52-5571-86ee346db795@gmail.com> From: Andy Shevchenko Date: Thu, 22 Oct 2020 16:40:25 +0300 Message-ID: Subject: Re: [RFC PATCH v3 9/9] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows To: Daniel Scally Cc: Andy Shevchenko , Linux Kernel Mailing List , Linux Media Mailing List , linux.walleij@linaro.org, prabhakar.mahadev-lad.rj@bp.renesas.com, "Krogerus, Heikki" , Dmitry Torokhov , laurent.pinchart+renesas@ideasonboard.com, kieran.bingham+renesas@ideasonboard.com, Jacopo Mondi , Rob Herring , "David S. Miller" , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Petr Mladek , Mauro Carvalho Chehab , Tian Shu Qiu , Bingbu Cao , Sakari Ailus , Yong Zhi , "Rafael J. Wysocki" , Greg Kroah-Hartman , Tsuchiya Yuto , dan.carpenter@oracle.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Oct 22, 2020 at 3:59 PM Daniel Scally wrote: > On 20/10/2020 10:41, Andy Shevchenko wrote: ... > >> +static const char * const port_names[] = { > >> + "port0", "port1", "port2", "port3" > > + comma. > I think 4 ports is the maximum for CIO2 device, so this shouldn't ever > get extended? It's better for at least teaching purposes (if anybody takes this driver as an example for anything) if you have really believe that no new generation will have more than that. ... > >> + if (is_software_node(dev_fwnode(&pci_dev->dev))) > > Can we use the same check as for _build call above? > > And just set a flag in struct cio2? sure. I meant can we use exact conditional w/o any additional flags added? -- With Best Regards, Andy Shevchenko