From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C44C433E0 for ; Thu, 24 Dec 2020 12:25:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37D33223DB for ; Thu, 24 Dec 2020 12:25:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728128AbgLXMZM (ORCPT ); Thu, 24 Dec 2020 07:25:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbgLXMZJ (ORCPT ); Thu, 24 Dec 2020 07:25:09 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4231FC061794; Thu, 24 Dec 2020 04:24:29 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id lb18so1038976pjb.5; Thu, 24 Dec 2020 04:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7ioVoN+TtUwUxRFG1jMfrbYZ/LUETYJIEopRnDFJTwU=; b=GGxybWc9TGDh5iNw2yoesDsF9L3oYSFLZpZVSMM/Z0IEEjzfTVSBLg+9zweFaqgYgi q3h+syVE+LX+ASe/povghGdFNzeNTL38tePh2wxy6N0TgtBF74RB2bz+Fo4Xx71bZSUQ neF4OwbXvoqsYJUgELrFlvenYJ0EW0+mOP3MHwX8Co5M5bkhS6sA8dTxnkqHSZ7JUhsI tR3z88AGxl0Um+RXioAHIPUOZFN/FJAdC9udZZP+6YgFMZypUvEnZStPPiWsdkcfWt8t hZK46R3F5jNiwp77ey0IZm26Q4N793bB1DyVIzVfskUxu8JRjVXndQ7xyFcwFRxo3PqV oR7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7ioVoN+TtUwUxRFG1jMfrbYZ/LUETYJIEopRnDFJTwU=; b=nq70kzvkR4p5OBAZWfEXlGFxdDYyydxshShbrG5kAsSf9saiJ1o/vw9xmc67zLD16q r7n1kzCPufQcQ2lkOwuaKUztFy3VVqIHMtOFjjGmO/Cf/P6/FFngnaSkCGB+90f2AsAq v3hJW2RahQ+bAGfan9PH7HrPmL3MWkOHSJvYyfYkz7hiyzDSGiuah++6XvMmIfpWvk1G Qvd4I1LsHmFUHuLDZKVUl6q+UUmX+GyVANITXp/Rx7C6kPGFzmaVkYsYhwEIyaoNGH/3 LpdlV9/zqpzXmptGha7EvgNE19KSScrd8Tq1CY43ATL8TKfUcaNxmbGaJeJoOaT3w4Jz f+EA== X-Gm-Message-State: AOAM531elhYai1diktp6CYE1Ie0f7SAp2uuAW/xzH2eKGK5HDXd1gN/8 ujvONo7k5uqHXH46306BU2L191DNCbK/DyCkunE= X-Google-Smtp-Source: ABdhPJwYo8Ew2cKK7fzwUbVqNe3b02Vu4fjijplekSl9eUb5S6AHsFuXwTuDdxQYFq+jq1paQ6PPyzg9EvLPeFE7tFs= X-Received: by 2002:a17:90a:c592:: with SMTP id l18mr4246668pjt.228.1608812668603; Thu, 24 Dec 2020 04:24:28 -0800 (PST) MIME-Version: 1.0 References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-8-djrscally@gmail.com> In-Reply-To: <20201224010907.263125-8-djrscally@gmail.com> From: Andy Shevchenko Date: Thu, 24 Dec 2020 14:24:12 +0200 Message-ID: Subject: Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions To: Daniel Scally Cc: Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Sakari Ailus , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Dec 24, 2020 at 3:14 AM Daniel Scally wrote: > > From: Heikki Krogerus > > This implements the remaining .graph_* callbacks in the .graph_* ==> ->graph_*() ? > fwnode operations structure for the software nodes. That makes > the fwnode_graph*() functions available in the drivers also graph*() -> graph_*() ? > when software nodes are used. > > The implementation tries to mimic the "OF graph" as much as > possible, but there is no support for the "reg" device > property. The ports will need to have the index in their > name which starts with "port@" (for example "port@0", "port@1", > ...) Looks not good, perhaps move to the previous line, or move port@1 example here? > and endpoints will use the index of the software node > that is given to them during creation. The port nodes can > also be grouped under a specially named "ports" subnode, > just like in DT, if necessary. > > The remote-endpoints are reference properties under the > endpoint nodes that are named "remote-endpoint". Few nitpicks here and there, after addressing them, Reviewed-by: Andy Shevchenko > Signed-off-by: Heikki Krogerus > Co-developed-by: Daniel Scally > Signed-off-by: Daniel Scally > --- > Changes in v3 > - Changed software_node_get_next_endpoint() to drop the variable > named "old" > - Used the macros defined in 06/14 instead of magic numbers > - Added some comments to explain behaviour a little where it's unclear > > drivers/base/swnode.c | 112 +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 111 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index 2d07eb04c6c8..ff690029060d 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -540,6 +540,112 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode, > return 0; > } > > +static struct fwnode_handle * > +swnode_graph_find_next_port(const struct fwnode_handle *parent, > + struct fwnode_handle *port) > +{ > + struct fwnode_handle *old = port; > + > + while ((port = software_node_get_next_child(parent, old))) { > + /* > + * ports have naming style "port@n", so we search for children > + * that follow that convention (but without assuming anything > + * about the index number) > + */ > + if (!strncmp(to_swnode(port)->node->name, "port@", You may use here corresponding _FMT macro. > + FWNODE_GRAPH_PORT_NAME_PREFIX_LEN)) > + return port; > + old = port; > + } > + > + return NULL; > +} > + > +static struct fwnode_handle * > +software_node_graph_get_next_endpoint(const struct fwnode_handle *fwnode, > + struct fwnode_handle *endpoint) > +{ > + struct swnode *swnode = to_swnode(fwnode); > + struct fwnode_handle *parent; > + struct fwnode_handle *port; > + > + if (!swnode) > + return NULL; > + > + if (endpoint) { > + port = software_node_get_parent(endpoint); > + parent = software_node_get_parent(port); > + } else { > + parent = software_node_get_named_child_node(fwnode, "ports"); > + if (!parent) > + parent = software_node_get(&swnode->fwnode); > + > + port = swnode_graph_find_next_port(parent, NULL); > + } > + > + for (; port; port = swnode_graph_find_next_port(parent, port)) { > + endpoint = software_node_get_next_child(port, endpoint); > + if (endpoint) { > + fwnode_handle_put(port); > + break; > + } > + } > + > + fwnode_handle_put(parent); > + > + return endpoint; > +} > + > +static struct fwnode_handle * > +software_node_graph_get_remote_endpoint(const struct fwnode_handle *fwnode) > +{ > + struct swnode *swnode = to_swnode(fwnode); > + const struct software_node_ref_args *ref; > + const struct property_entry *prop; > + > + if (!swnode) > + return NULL; > + > + prop = property_entry_get(swnode->node->properties, "remote-endpoint"); > + if (!prop || prop->type != DEV_PROP_REF || prop->is_inline) > + return NULL; > + > + ref = prop->pointer; > + > + return software_node_get(software_node_fwnode(ref[0].node)); > +} > + > +static struct fwnode_handle * > +software_node_graph_get_port_parent(struct fwnode_handle *fwnode) > +{ > + struct swnode *swnode = to_swnode(fwnode); > + > + swnode = swnode->parent; > + if (swnode && !strcmp(swnode->node->name, "ports")) > + swnode = swnode->parent; > + > + return swnode ? software_node_get(&swnode->fwnode) : NULL; > +} > + > +static int > +software_node_graph_parse_endpoint(const struct fwnode_handle *fwnode, > + struct fwnode_endpoint *endpoint) > +{ > + struct swnode *swnode = to_swnode(fwnode); > + int ret; > + > + /* Ports have naming style "port@n", we need to select the n */ > + ret = kstrtou32(swnode->parent->node->name + FWNODE_GRAPH_PORT_NAME_PREFIX_LEN, Maybe a temporary variable? unsigned int prefix_len = FWNODE_GRAPH_PORT_NAME_PREFIX_LEN; ... ret = kstrtou32(swnode->parent->node->name + prefix_len, > + 10, &endpoint->port); > + if (ret) > + return ret; > + > + endpoint->id = swnode->id; > + endpoint->local_fwnode = fwnode; > + > + return 0; > +} > + > static const struct fwnode_operations software_node_ops = { > .get = software_node_get, > .put = software_node_put, > @@ -551,7 +657,11 @@ static const struct fwnode_operations software_node_ops = { > .get_parent = software_node_get_parent, > .get_next_child_node = software_node_get_next_child, > .get_named_child_node = software_node_get_named_child_node, > - .get_reference_args = software_node_get_reference_args > + .get_reference_args = software_node_get_reference_args, > + .graph_get_next_endpoint = software_node_graph_get_next_endpoint, > + .graph_get_remote_endpoint = software_node_graph_get_remote_endpoint, > + .graph_get_port_parent = software_node_graph_get_port_parent, > + .graph_parse_endpoint = software_node_graph_parse_endpoint, > }; > > /* -------------------------------------------------------------------------- */ > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko