From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:39725 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932593AbdKOSbR (ORCPT ); Wed, 15 Nov 2017 13:31:17 -0500 Received: by mail-wm0-f68.google.com with SMTP id l8so4808390wmg.4 for ; Wed, 15 Nov 2017 10:31:16 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20171115155204.yhqjocdm32qunllx@rob-hp-laptop> References: <1510253136-14153-1-git-send-email-tharvey@gateworks.com> <1510253136-14153-4-git-send-email-tharvey@gateworks.com> <20171115155204.yhqjocdm32qunllx@rob-hp-laptop> From: Tim Harvey Date: Wed, 15 Nov 2017 10:31:14 -0800 Message-ID: Subject: Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver To: Rob Herring Cc: linux-media , alsa-devel@alsa-project.org, "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Shawn Guo , Steve Longerbeam , Philipp Zabel , Hans Verkuil , Mauro Carvalho Chehab , Hans Verkuil Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, Nov 15, 2017 at 7:52 AM, Rob Herring wrote: > On Thu, Nov 09, 2017 at 10:45:34AM -0800, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. >> >> Cc: Hans Verkuil >> Signed-off-by: Tim Harvey >> --- >> v3: >> - use V4L2_DV_BT_FRAME_WIDTH/HEIGHT macros >> - fixed missing break >> - use only hdmi_infoframe_log for infoframe logging >> - simplify tda1997x_s_stream error handling >> - add delayed work proc to handle hotplug enable/disable >> - fix set_edid (disable HPD before writing, enable after) >> - remove enabling edid by default >> - initialize timings >> - take quant range into account in colorspace conversion >> - remove vendor/product tracking (we provide this in log_status via infoframes) >> - add v4l_controls >> - add more detail to log_status >> - calculate vhref generator timings >> - timing detection fixes (rounding errors, hswidth errors) >> - rename configure_input/configure_conv functions >> >> v2: >> - implement dv timings enum/cap >> - remove deprecated g_mbus_config op >> - fix dv_query_timings >> - add EDID get/set handling >> - remove max-pixel-rate support >> - add audio codec DAI support >> - change audio bindings >> --- >> drivers/media/i2c/Kconfig | 9 + >> drivers/media/i2c/Makefile | 1 + >> drivers/media/i2c/tda1997x.c | 3485 ++++++++++++++++++++++++++++++++++ >> include/dt-bindings/media/tda1997x.h | 78 + > > This belongs with the binding documentation patch. > Rob, Thanks - missed that. I will move it for v4. Regarding your previous comment to the v2 series: > The rest of the binding looks fine, but I have some reservations about > this. I think this should be common probably. There's been a few > bindings for display recently that deal with the interface format. Maybe > some vendor property is needed here to map a standard interface format > back to pin configuration. I take it this is not an 'Ack' for the bindings? Which did you feel should be made common? I admit I was surprised there wasn't a common binding for audio bus format (i2s|spdif) but if you were referring to the video data that would probably be much more complicated. I was hoping one of the media/driver maintainers would respond to your comment with thoughts as I'm not familiar with a very wide variety of receivers. Best regards, Tim