From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 159DEC2BBD4 for ; Fri, 18 Dec 2020 10:00:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3D26233A2 for ; Fri, 18 Dec 2020 10:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733156AbgLRKAn (ORCPT ); Fri, 18 Dec 2020 05:00:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:48314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733012AbgLRKAn (ORCPT ); Fri, 18 Dec 2020 05:00:43 -0500 X-Gm-Message-State: AOAM533Q3QTHEi11MgQAX1dLn/tzkyMxR41ESdvSQuXvU3X4ejE84WF5 pX3qWyGsiGHKWdLDZagQijVL4q4EBGJcI6oyuEk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608285602; bh=Yv4ehNWrxhpZcvfC+h8QoKTm11DudEJN27fvhSVn57o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WurfVnPrYSZY5vv4EOmWqSNbyP47kxGrj380USxOOKWsCaoN83IVMuNssozp3DWY4 H7hN79TZaEdh4qpW4k/VZAHAJ54sHE/FGB5f+zfuyf7zY8ekCyH6rd0z6tfmc4L5KH RfF3SPasU0TItrvRRm1NqbuFofsUU/z+kqHdjgnZESpIHj+MMHjM/mmzwdGyv84Nqm tubA4kz/uxZDfiVB29bSrOcCjO+ITTnCWNglyfw9ZZJcRVkuHdcv7SVAUoK0039Uad QJaH8niuZUyG+RU0jgftC7AdCPgZp1tjAgDngMgeYz+N9cTW7qocxoxitWYbaTjMug qY6g0peszyqTQ== X-Google-Smtp-Source: ABdhPJxkDlRRJAF7ZQwc5naGuJKcxES24HLh+ph9YFONqtW/bBULM8erNl5wUccYIOpBpFSPBFu+cizSLRfJRbHTIZs= X-Received: by 2002:a17:906:9588:: with SMTP id r8mr3170102ejx.148.1608285600737; Fri, 18 Dec 2020 02:00:00 -0800 (PST) MIME-Version: 1.0 References: <20201206172720.9406-1-michael.srba@seznam.cz> <20201207055952.GB14307@pengutronix.de> <222f5118-72ac-d291-f8d9-743d5c45c4ea@seznam.cz> In-Reply-To: <222f5118-72ac-d291-f8d9-743d5c45c4ea@seznam.cz> From: Krzysztof Kozlowski Date: Fri, 18 Dec 2020 10:59:48 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/3] media: i2c: imx219: add support for specifying clock-frequencies To: Michael Srba Cc: Sascha Hauer , Dave Stevenson , Mauro Carvalho Chehab , Rob Herring , Shawn Guo , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Geert Uytterhoeven , Magnus Damm , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, 10 Dec 2020 at 21:56, Michael Srba wrote: > > Hi, > > sorry for late reply. > > I copied this approach from looking at other camera sensor drivers, > and it seemed less "ugly" to me than using assigned-rates (I will be > upstreaming required dts changes for Samsung Galaxy A3 (2015), so the > dts feeling "proper" is important to me). The clean solution is the assigned-clock properties. It's handled by the core. Duplicating the same feature to every driver is not "cleaner", but the opposite - ugly one. > I however am not qualified to make that decision, so if you believe > that the assigned-rates approach is cleaner and more suitable for mainline, > I will try to adjust my internal filter for what is "more proper" :) More proper is handling stuff in the core, not implementing the same thing in every driver, one more time. Therefore, the assigned-clock properties. Best regards, Krzysztof Best regards, Krzysztof