From: Arnd Bergmann <arnd@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Dmitry Vyukov <dvyukov@google.com>,
syzbot <syzbot+142888ffec98ab194028@syzkaller.appspotmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] media: v4l2-core: ignore native time32 ioctls on 64-bit
Date: Thu, 18 Mar 2021 16:24:57 +0100 [thread overview]
Message-ID: <CAK8P3a2VQaz4rLqSeEVu4V-RJ6W3nimo=6PbVymEWAKkEQCDOg@mail.gmail.com> (raw)
In-Reply-To: <YFNrF5ebp9QUvKQh@pendragon.ideasonboard.com>
On Thu, Mar 18, 2021 at 4:00 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Thu, Mar 18, 2021 at 02:43:18PM +0100, Arnd Bergmann wrote:
>
> v4l2_event vs. v4l2_event32 vs. v4l2_event_time32 vs.
> v4l2_event32_time32 is a bit confusing. Do I understand correctly that
> the code below runs for the non-compat path, thus native userspace
> (32-bit on 32-bit machines, 64-bit on 64-bit machines), and handles the
> case of a native userspace using a 32-bit time ? If so it indeed doesn't
> make sense for 64-bit machines.
Yes, that's correct. The way the structures are defined, we have
all four combinations of native/compat pointer and time64/time32
timestamps, but the combination of native pointer with time32
stamps only makes sense for 32-bit users.
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks,
Arnd
next prev parent reply other threads:[~2021-03-18 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 13:43 [PATCH 1/2] media: v4l2-core: ignore native time32 ioctls on 64-bit Arnd Bergmann
2021-03-18 13:43 ` [PATCH 2/2] media: v4l2-core: explicitly clear ioctl input data Arnd Bergmann
2021-03-18 15:07 ` Laurent Pinchart
2021-03-18 15:00 ` [PATCH 1/2] media: v4l2-core: ignore native time32 ioctls on 64-bit Laurent Pinchart
2021-03-18 15:24 ` Arnd Bergmann [this message]
2021-03-21 8:50 ` Hans Verkuil
2021-03-25 7:41 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a2VQaz4rLqSeEVu4V-RJ6W3nimo=6PbVymEWAKkEQCDOg@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=dvyukov@google.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=syzbot+142888ffec98ab194028@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).