From: Ilia Mirkin <imirkin@alum.mit.edu>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] edid-decode: add function to enable usage as a library
Date: Wed, 12 Feb 2020 19:48:03 -0500 [thread overview]
Message-ID: <CAKb7Uvh7XGK+y5rXdFVSA+JkYYNW7Pp1P1=0x0Yy6L0hgv0Rhg@mail.gmail.com> (raw)
In-Reply-To: <CAKb7Uvj2XV0+tr48EetVE1e_Vqpr-2zQCnR7NCWagWnbCEcyeQ@mail.gmail.com>
On Mon, Feb 10, 2020 at 9:58 AM Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> On Mon, Feb 10, 2020 at 6:23 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
> > > + for (unsigned i = 0; i < EDID_MAX_BLOCKS + 1; i++) {
> > > + s_msgs[i][0].clear();
> > > + s_msgs[i][1].clear();
> > > + }
> >
> > I'm pretty sure that this for loop is not necessary. Can you drop this
> > for loop and see if it works?
>
> The current code has:
>
> static void show_msgs(bool is_warn)
> {
> printf("\n%s:\n\n", is_warn ? "Warnings" : "Failures");
> for (unsigned i = 0; i < state.num_blocks; i++) {
> if (s_msgs[i][is_warn].empty())
> continue;
> print-the-error
>
> What would prevent an error from a previous run to appear without an
> explicit clearing of s_msgs?
Hi Hans,
Do you agree with my assessment above?
-ilia
next prev parent reply other threads:[~2020-02-13 0:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 17:49 [PATCH 0/2] edid-decode: add emscripten support Ilia Mirkin
2020-02-09 17:49 ` [PATCH 1/2] edid-decode: add function to enable usage as a library Ilia Mirkin
2020-02-10 11:23 ` Hans Verkuil
2020-02-10 14:58 ` Ilia Mirkin
2020-02-13 0:48 ` Ilia Mirkin [this message]
2020-02-13 7:16 ` Hans Verkuil
2020-02-09 17:49 ` [PATCH 2/2] edid-decode: add build rule for emscripten output Ilia Mirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKb7Uvh7XGK+y5rXdFVSA+JkYYNW7Pp1P1=0x0Yy6L0hgv0Rhg@mail.gmail.com' \
--to=imirkin@alum.mit.edu \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).