From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A985C4361B for ; Wed, 16 Dec 2020 00:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5568722D75 for ; Wed, 16 Dec 2020 00:34:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726167AbgLPAer (ORCPT ); Tue, 15 Dec 2020 19:34:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbgLPAel (ORCPT ); Tue, 15 Dec 2020 19:34:41 -0500 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BDC0C0613D6 for ; Tue, 15 Dec 2020 16:34:00 -0800 (PST) Received: by mail-lf1-x141.google.com with SMTP id o17so41124588lfg.4 for ; Tue, 15 Dec 2020 16:34:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zj2YPVQKRFQs32LNLuK0mWD4evn16vjxArTvNU8xCYE=; b=zmi7gRMEKq3pV/lgDugpVABkbjYGunfv3IE8jzEnAbsXbf+Ejg0wFe38PkWiNxIzat UcNrSUrSe1p2sIBdGyWDONBu3AH8Kbk0NiodFDicgrBdvK70sr0gakQF29ML95jAragV 8N13doCOA/pfONzJVu9hq8B426nbEKWVwEaZb7OphLLkthsF5Ta4dsKZ5Ek4hjMnrraY DGHF1s2bdcFGIUxhc8PsQ4bFHAmzraOeLADbxbYfaGcYzobyIX+X8coA5ijWWy005Ds+ wAdnfLQ7eT6rJMO+AIq+vVrl6HWY5W3uz0vRd5Gt6zRcBSNLXP04+FjmrPL01+CWxnu5 qKVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zj2YPVQKRFQs32LNLuK0mWD4evn16vjxArTvNU8xCYE=; b=s+GjBJ9PMakqILSNA3gmgNHAPnuud3cgHj+JXBiuyfr6yr7yOlAR63JAcLyyqG/y1S f8jBYOOJwSs5tmUMhHOZXFC3AsH1DM4GIjHvRBXq3ebp09FgsVW2iQPwnnFUZ/khSEML nBGy1Gpk7pcTOd1v4eVHe1BqHzuU2zpVXMuiya6OtY+18CH18MhEVITZLtDj5heqbXEY jpEQEBrYRMi0VafGqPnN86lR9qYJZtipYKX0xlCd6PcpVnbtHLxhYNQ3mR1arzag7I5i P0gP6AiM07fM1Xp23hAg48of4DzCKF1rCmmwZNp+K2a55MxEGyJXvNUz3P6BQIgc+01V XpWA== X-Gm-Message-State: AOAM531KFB13E3VbuRCOOP+yobz5sm2LTSWhL6NnHSak8WgDc5lXiXgd VCZVRib7sbYsjPAq/xw/iYCSJ9rfujGvYaN9efnl7g== X-Google-Smtp-Source: ABdhPJyOHjNYEs+MlipEezrk74D7gW0AbcHrqq8ll/2YJyrpydKCzWHi1oI7l8bwkRbDoPAAlJpvejRCo7btrJ0F78U= X-Received: by 2002:a2e:8e38:: with SMTP id r24mr7092267ljk.333.1608078838907; Tue, 15 Dec 2020 16:33:58 -0800 (PST) MIME-Version: 1.0 References: <20201121235002.69945-1-john.stultz@linaro.org> <20201121235002.69945-3-john.stultz@linaro.org> <20201215235334.GA227480@roeck-us.net> In-Reply-To: <20201215235334.GA227480@roeck-us.net> From: John Stultz Date: Tue, 15 Dec 2020 16:33:45 -0800 Message-ID: Subject: Re: [PATCH v7 2/5] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation To: Guenter Roeck Cc: lkml , Sumit Semwal , Liam Mark , Laura Abbott , Brian Starkey , Hridya Valsaraju , Suren Baghdasaryan , Sandeep Patil , Daniel Mentz , Chris Goldsworthy , =?UTF-8?Q?=C3=98rjan_Eide?= , Robin Murphy , Ezequiel Garcia , Simon Ser , James Jones , linux-media , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Dec 15, 2020 at 3:53 PM Guenter Roeck wrote: > > On Sat, Nov 21, 2020 at 11:49:59PM +0000, John Stultz wrote: > > Since the heap-helpers logic ended up not being as generic as > > hoped, move the heap-helpers dma_buf_ops implementations into > > the cma_heap directly. > > > > This will allow us to remove the heap_helpers code in a following > > patch. > > > > mips:allmodconfig: > > drivers/dma-buf/heaps/cma_heap.c: In function 'cma_heap_do_vmap': > drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of function 'vmap' > Ah. Looks like we need to explicitly include linux/vmalloc.h. Thanks for the report! I'll spin up a patch, validate it and send it out here shortly. thanks -john