linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dariusz Marcinkiewicz <darekm@google.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH v3 3/9] dw-hdmi-cec: use cec_notifier_cec_adap_(un)register
Date: Tue, 16 Jul 2019 14:38:53 +0200	[thread overview]
Message-ID: <CALFZZQF4W42LDz0ux9cmDoVdrojO3+uMK4uD63aUEwb2Q3ebjQ@mail.gmail.com> (raw)
In-Reply-To: <7055d5ca-95cd-2cae-9d88-fff16a51285c@xs4all.nl>

On Tue, Jul 16, 2019 at 10:48 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
...
> > @@ -297,8 +298,6 @@ static int dw_hdmi_cec_probe(struct platform_device *pdev)
> >        */
> >       devm_remove_action(&pdev->dev, dw_hdmi_cec_del, cec);
>
> I have to say that I find this remove action very confusing since it is
> not obvious that this deletes the adapter on error. I would prefer that
> the action is dropped and the normal 'goto' pattern is used for error
> handling. Much easier to review.
>
> What do you think?
>
This pattern indeed seems uncommon - there are only a couple of
references to devm_remove_action in the kernel, if I am counting this
right. I am not sure, though, if this patch is the right place to make
changes to the way resources are unwound.

Regards.

  reply	other threads:[~2019-07-16 12:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16  7:58 [PATCH v3 0/9] drm: cec: convert DRM drivers to the new notifier API Dariusz Marcinkiewicz
2019-07-16  7:58 ` [PATCH v3 1/9] drm_dp_cec: add connector info support Dariusz Marcinkiewicz
2019-07-16  7:58 ` [PATCH v3 2/9] drm/i915/intel_hdmi: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-07-16  7:58 ` [PATCH v3 3/9] dw-hdmi-cec: use cec_notifier_cec_adap_(un)register Dariusz Marcinkiewicz
2019-07-16  8:48   ` Hans Verkuil
2019-07-16 12:38     ` Dariusz Marcinkiewicz [this message]
2019-07-16  8:50   ` Hans Verkuil
2019-07-16  7:58 ` [PATCH v3 4/9] tda9950: " Dariusz Marcinkiewicz
2019-07-16  7:58 ` [PATCH v3 5/9] drm: tda998x: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-07-16  7:58 ` [PATCH v3 6/9] drm: sti: " Dariusz Marcinkiewicz
2019-07-16  7:58 ` [PATCH v3 7/9] drm: tegra: " Dariusz Marcinkiewicz
2019-07-16  7:58 ` [PATCH v3 8/9] drm: dw-hdmi: " Dariusz Marcinkiewicz
2019-07-16  7:58 ` [PATCH v3 9/9] drm: exynos: exynos_hdmi: " Dariusz Marcinkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALFZZQF4W42LDz0ux9cmDoVdrojO3+uMK4uD63aUEwb2Q3ebjQ@mail.gmail.com \
    --to=darekm@google.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --subject='Re: [PATCH v3 3/9] dw-hdmi-cec: use cec_notifier_cec_adap_(un)register' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).