From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6FA9C04AAF for ; Tue, 21 May 2019 11:02:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D8A1217D4 for ; Tue, 21 May 2019 11:02:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZvRBIPtf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbfEULCP (ORCPT ); Tue, 21 May 2019 07:02:15 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45836 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727659AbfEULCO (ORCPT ); Tue, 21 May 2019 07:02:14 -0400 Received: by mail-lj1-f193.google.com with SMTP id r76so15393351lja.12 for ; Tue, 21 May 2019 04:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JiOuebsbWgjEjp0a4XhtJdVmmGWnCnRTxg69qCcOtsY=; b=ZvRBIPtfv2tQxLEbXHDCKUrcnh/NVGQfK3ADpUqQQBHq1gYARpxa+eRJtDdzIgJu00 kldlfPB4RQNBEqY7t9xCcYTx60nZQBUNINx3FuZLkV4uQquWRRo0ZPQVLb4Gmk2L8dfh USl8OwxlE0Lwfu33/W2BA31HSvaLTnOEeLrf1CWKLuutF2ytufBEwqs16ms8qN0neyLc +KOZj1m8EZx3foz/XKFg3yT3ele5AQZCLu7ZTBo9lCedes1ZgP7k8FK8ofFAumM/oNfz MuSoRVwe5VBd9AnIjHJGGJFnPOxeYVrX8VYOq1+YDhFfQguqeHkycLU5DZGaPjTGM2s/ c3LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JiOuebsbWgjEjp0a4XhtJdVmmGWnCnRTxg69qCcOtsY=; b=eo9gtGwEE/T8pjw/oX8Ak5WHkdoJ9PconI/B+ee/cPgvCJ7kF4wLeai0zatktRM/LQ VdalRjxo64f6JOC3BGQXugrrBYl/RG2LhTYbBbZ5H0OEqycgmw2HC/tjtTsOxuEPOVAf 94GeyOtu/7d2mxgNla6Hq1IrMORRebffCSZTTBtKTW+tRnPk6pn5LRg9eyOttdjgPZ8j ntUyB1uSE8mi6iC0Zf8KHjKSqZPsh5lOxK6jyKNGa0xY1hzV1zfzgsNyy5wHTLTUSdK3 /fpf6wNc7sKB/YyjUqE6MjxfaSMAsFOhtMuVCn7aDwA/2ScF4yXzU049ukP6Oeylh5lA l0Gg== X-Gm-Message-State: APjAAAXHsBT7aJWPT7s8wGaH8md/4RVl9KewjvFiJuMeQ3VkH9TRMRS7 H6d47Z4S6nJC5/Isv1mj7JUxoLv10fGNcXEup1ZKNRvdfJQ= X-Google-Smtp-Source: APXvYqwWehMJJXjGsP0Bc9f4SddpS0xg17Ozs3s2XazkB+UlZqZ2pxY6LcgfzktZnCGe51S0yfCdqoJ2EF6kI7Lo3Ns= X-Received: by 2002:a2e:2b58:: with SMTP id q85mr41770277lje.179.1558436532542; Tue, 21 May 2019 04:02:12 -0700 (PDT) MIME-Version: 1.0 References: <20190517154256.255696-1-darekm@google.com> In-Reply-To: From: Dariusz Marcinkiewicz Date: Tue, 21 May 2019 13:02:01 +0200 Message-ID: Subject: Re: [PATCH v6 1/3] media: cec: expose HDMI connector to CEC dev mapping To: Hans Verkuil Cc: linux-media@vger.kernel.org, hans.verkuil@cisco.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, May 20, 2019 at 12:25 PM Hans Verkuil wrote: > > It's a bit unusual since it uses the Synopsys bridge, but not the Synopsys > CEC driver (it has its own meson cec driver). > > The first thing I noticed is that I did not get any connector info. > I think that the root cause of that is that you forgot that there are > several drm drivers that call cec_notifier_get() instead of cec_notifier_get_conn(). > > I think all those calls to cec_notifier_get() in drm drivers should be replaced > by cec_notifier_get_conn() where the second argument is NULL, but the third argument > should contain valid connector info. > > A quick grep gives me the following drivers that need work: > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > drivers/gpu/drm/exynos/exynos_hdmi.c > drivers/gpu/drm/i2c/tda998x_drv.c > drivers/gpu/drm/sti/sti_hdmi.c > drivers/gpu/drm/tegra/output.c > I am afraid that just replacing cec_notifier_get with cec_notifier_get_conn won't necessarily make this information available, as, e.g. looking at tegra, those would also require some reshuffling of the code so that notifier is created once connector is initialized. Btw. I've updated dw-hdmi.c and tda998x_drv.c to use cec_notifier_get_conn, so at least those 2 will be covered. > The second thing I noticed is that patch 2 gave me a new kernel warning, but > I'll do some more testing for that and reply to patch 2/3 once I know more. > I hope this is fixed in v7. Thank you for your testing and best regards!