From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D60EC04AB4 for ; Fri, 17 May 2019 22:22:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C1882173C for ; Fri, 17 May 2019 22:22:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558131776; bh=wy3tUZPJTfjLA6B2iSkaBZEFlBpyvFUKCy44GXr0yjI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Na33RWYBYPf9Txi8QwuQ41kCl+2umtDN47MUeyvgcYi4ceLUlPqtpek0WV5zITs8z 3YCppLtirbcsUlYzhWpLufms0IKbkx2SG8dh1lk0d8fPs5dQZuDZaYTwii2mUHWBS7 4tJFsXBOCNqC+T+Yi4DVxuvAM/QiOiBYi6JfoFqQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727594AbfEQWWz (ORCPT ); Fri, 17 May 2019 18:22:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:37850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727133AbfEQWWz (ORCPT ); Fri, 17 May 2019 18:22:55 -0400 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6901B216C4; Fri, 17 May 2019 22:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558131773; bh=wy3tUZPJTfjLA6B2iSkaBZEFlBpyvFUKCy44GXr0yjI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=1H8AXHsM/HDg4uE/AoRizeknctHuF4pbibpUykeWsjQrOTs0uwSaNYbA+O6l/2Xs9 Ov6lBU00JS8+Tb8R+N/06VtXt0SHNrz52/TeDKk0D6sLF58BZTsWtnjdtblWRqqJie R2I4HibvqDOpWRkqITAOovENVOXUYTjn/z18L03w= Received: by mail-qt1-f174.google.com with SMTP id j53so9804579qta.9; Fri, 17 May 2019 15:22:53 -0700 (PDT) X-Gm-Message-State: APjAAAVxQRzce+j9C6tMR+j5k4kG4Xe2D49TVTd3BgInhpmy7/M5J3yw BGSuGN9ddJ6wWdnC5Il3+uTY6OFxbT6TJtKHDQ== X-Google-Smtp-Source: APXvYqxCG14RTMkHi4AFjCOBJ2jDfMBdP6IR9Yo55aGoXHKbHkWK52ZrzIrGRx1VvIDs46fF56pwC87n9mQ89Qff9Qc= X-Received: by 2002:a0c:f350:: with SMTP id e16mr48812969qvm.72.1558131772630; Fri, 17 May 2019 15:22:52 -0700 (PDT) MIME-Version: 1.0 References: <20190417104511.21514-1-frederic.chen@mediatek.com> <20190417104511.21514-2-frederic.chen@mediatek.com> <20190430011506.GA8514@bogus> <1557238925.11663.21.camel@mtksdccf07> In-Reply-To: From: Rob Herring Date: Fri, 17 May 2019 17:22:41 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH V1 1/6] dt-bindings: mt8183: Add binding for DIP shared memory To: Tomasz Figa Cc: Frederic Chen , Hans Verkuil , Laurent Pinchart , Matthias Brugger , Mauro Carvalho Chehab , yuzhao@chromium.org, zwisler@chromium.org, "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , Sj Huang , =?UTF-8?B?Q2hyaXN0aWUgWXUgKOa4uOmbheaDoCk=?= , =?UTF-8?B?SG9sbWVzIENoaW91ICjpgrHmjLop?= , Jerry-ch Chen , =?UTF-8?B?SnVuZ28gTGluICjmnpfmmI7kv4op?= , =?UTF-8?B?UnlubiBXdSAo5ZCz6IKy5oGpKQ==?= , Linux Media Mailing List , srv_heupstream , devicetree@vger.kernel.org, Shik Chen , suleiman@chromium.org Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, May 16, 2019 at 1:12 AM Tomasz Figa wrote: > > On Wed, May 15, 2019 at 1:19 AM Rob Herring wrote: > > > > On Tue, May 7, 2019 at 9:22 AM Frederic Chen wrote: > > > > > > Dear Rob, > > > > > > I appreciate your comments. > > > > > > On Mon, 2019-04-29 at 20:15 -0500, Rob Herring wrote: > > > > On Wed, Apr 17, 2019 at 06:45:06PM +0800, Frederic Chen wrote: > > > > > This patch adds the binding for describing the shared memory > > > > > used to exchange configuration and tuning data between the > > > > > co-processor and Digital Image Processing (DIP) unit of the > > > > > camera ISP system on Mediatek SoCs. > > > > > > > > > > Signed-off-by: Frederic Chen > > > > > --- > > > > > .../mediatek,reserve-memory-dip_smem.txt | 45 +++++++++++++++++++ > > > > > 1 file changed, 45 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > > > > new file mode 100644 > > > > > index 000000000000..64c001b476b9 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > > > > @@ -0,0 +1,45 @@ > > > > > +Mediatek DIP Shared Memory binding > > > > > + > > > > > +This binding describes the shared memory, which serves the purpose of > > > > > +describing the shared memory region used to exchange data between Digital > > > > > +Image Processing (DIP) and co-processor in Mediatek SoCs. > > > > > + > > > > > +The co-processor doesn't have the iommu so we need to use the physical > > > > > +address to access the shared buffer in the firmware. > > > > > + > > > > > +The Digital Image Processing (DIP) can access memory through mt8183 IOMMU so > > > > > +it can use dma address to access the memory region. > > > > > +(See iommu/mediatek,iommu.txt for the detailed description of Mediatek IOMMU) > > > > > + > > > > > + > > > > > +Required properties: > > > > > + > > > > > +- compatible: must be "mediatek,reserve-memory-dip_smem" > > > > > > > > Don't use '_'. > > > > > > I got it. I will use "mediatek,reserve-memory-dip-smem" instead in next > > > version of the patch > > > > > > > > > > > > + > > > > > +- reg: required for static allocation (see reserved-memory.txt for > > > > > + the detailed usage) > > > > > + > > > > > +- alloc-range: required for dynamic allocation. The range must > > > > > + between 0x00000400 and 0x100000000 due to the co-processer's > > > > > + addressing limitation > > > > > > > > Generally, you should pick either static or dynamic allocation for a > > > > given binding. Static if there's some address restriction or sharing, > > > > dynamic if not. > > > > > > > > Sounds like static in this case. > > > > > > > > > > DIP reserved memory has address restriction so it is the static case. I > > > would like to remove the dynamic allocation part and modify the > > > description as following: > > > > > > - reg: required for DIP. The range must be between 0x00000400 and > > > 0x100000000 due to the co-processor's addressing limitation. > > > The size must be 26MB. Please see reserved-memory.txt for the > > > detailed usage. > > > > You can use dma-ranges to define addressing translations and > > restrictions like this. That will in turn set the device's dma-mask to > > ensure allocations are done in a region that is addressable. > > > > But if you have a known, fixed size, then a carve out with > > reserved-memory is fine. > > There is also another aspect here. The coprocessor that we're > allocating the memory for is behind an MPU that must be programmed > completely in one go and locked for security reasons to ensure that > the coprocessor itself doesn't rewrite the MPU settings. That means > that we need to have all the allocations completed before booting that > coprocessor. > > To be honest, I'd adopt a completely different design here. > > We're going to have a driver for that coprocessor (SCP) and IMHO any > shared memory areas should belong to it. Then, any specific drivers > talking to the firmware running on SCP should ask the SCP driver to > allocate some memory from its fixed pool. WDYT? That's more than just an address restriction, so yeah, use a reserved-memory area. Rob