From: Rob Herring <robh@kernel.org>
To: "Stefan Riedmüller" <S.Riedmueller@phytec.de>
Cc: "mchehab@kernel.org" <mchehab@kernel.org>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 5/6] media: dt-bindings: mt9p031: Convert bindings to yaml
Date: Wed, 14 Jul 2021 08:19:10 -0600 [thread overview]
Message-ID: <CAL_Jsq+xJsmae3cu1oVdiUPnUWPb+61UYzMYMq4FaQ1M9Su-sQ@mail.gmail.com> (raw)
In-Reply-To: <99b0b3ad4eac3a5653e0e4630bf59fc63eef114d.camel@phytec.de>
On Wed, Jul 14, 2021 at 4:01 AM Stefan Riedmüller
<S.Riedmueller@phytec.de> wrote:
>
> Hi Rob,
>
> On Tue, 2021-07-13 at 20:19 -0600, Rob Herring wrote:
> > On Mon, Jul 12, 2021 at 10:55:34AM +0200, Stefan Riedmueller wrote:
> > > Convert mt9p031 sensor bindings to yaml schema. Also update the
> > > MAINTAINERS entry.
> > >
> > > Although input-clock-frequency and pixel-clock-frequency have not been
> > > definded as endpoint propierties in the textual bindings, the sensor
> > > does parse them from the endpoint. Thus move these properties to the
> > > endpoint in the new yaml bindings.
> > >
> > > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> > > ---
> > > .../bindings/media/i2c/aptina,mt9p031.yaml | 75 +++++++++++++++++++
> > > .../devicetree/bindings/media/i2c/mt9p031.txt | 40 ----------
> > > MAINTAINERS | 1 +
> > > 3 files changed, 76 insertions(+), 40 deletions(-)
> > > create mode 100644
> > > Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml
> > > delete mode 100644
> > > Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml
> > > b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml
> > > new file mode 100644
> > > index 000000000000..ad9a2db73d86
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml
> > > @@ -0,0 +1,75 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/media/i2c/aptina,mt9p031.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Aptina 1/2.5-Inch 5Mp CMOS Digital Image Sensor
> > > +
> > > +maintainers:
> > > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > +
> > > +description: |
> > > + The Aptina MT9P031 is a 1/2.5-inch CMOS active pixel digital image
> > > sensor
> > > + with an active array size of 2592H x 1944V. It is programmable through
> > > a
> > > + simple two-wire serial interface.
> > > +
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - aptina,mt9p031
> > > + - aptina,mt9p031m
> > > +
> > > + reg:
> > > + description: I2C device address
> > > + maxItems: 1
> > > +
> > > + reset-gpios:
> > > + maxItems: 1
> > > + description: Chip reset GPIO
> > > +
> > > + port:
> > > + $ref: /schemas/graph.yaml#/$defs/port-base
> > > + additionalProperties: false
> > > +
> > > + properties:
> > > + endpoint:
> > > + $ref: /schemas/media/video-interfaces.yaml#
> >
> > Doesn't look like you use any properties from video-interfaces.yaml. You
> > should just reference graph.yaml#/$defs/endpoint-base instead.
>
> Thanks for your comment. It made me realize, that I have something wrong. The
> driver does use properties from the video interface as it parses the bus
> configuration from the endpoint. But I thought these properties were
> implicitly used by referencing the video-interfaces schema. Now I assume that
> I have to mention them here explicitly. Correct?
Yes, because presumably you only support some subset of possible values.
Rob
next prev parent reply other threads:[~2021-07-14 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 8:55 [PATCH v5 0/6] media: mt9p031: Read back the real clock rate Stefan Riedmueller
2021-07-12 8:55 ` [PATCH v5 1/6] " Stefan Riedmueller
2021-07-12 8:55 ` [PATCH v5 2/6] media: mt9p031: Make pixel clock polarity configurable by DT Stefan Riedmueller
2021-07-12 8:55 ` [PATCH v5 3/6] media: mt9p031: Fix corrupted frame after restarting stream Stefan Riedmueller
2021-07-12 8:55 ` [PATCH v5 4/6] media: mt9p031: Use BIT macro Stefan Riedmueller
2021-07-12 8:55 ` [PATCH v5 5/6] media: dt-bindings: mt9p031: Convert bindings to yaml Stefan Riedmueller
2021-07-14 2:19 ` Rob Herring
2021-07-14 10:01 ` Stefan Riedmüller
2021-07-14 14:19 ` Rob Herring [this message]
2021-07-12 8:55 ` [PATCH v5 6/6] media: dt-bindings: mt9p031: Add missing required properties Stefan Riedmueller
2021-07-14 2:19 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+xJsmae3cu1oVdiUPnUWPb+61UYzMYMq4FaQ1M9Su-sQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=S.Riedmueller@phytec.de \
--cc=devicetree@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).