From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF066C3A5A0 for ; Mon, 19 Aug 2019 23:02:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FD2A20644 for ; Mon, 19 Aug 2019 23:02:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QNGqQBLe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728545AbfHSXC2 (ORCPT ); Mon, 19 Aug 2019 19:02:28 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:35420 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728123AbfHSXC1 (ORCPT ); Mon, 19 Aug 2019 19:02:27 -0400 Received: by mail-qt1-f194.google.com with SMTP id u34so3859164qte.2; Mon, 19 Aug 2019 16:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ch4jA9pONjtk/Z4LqeHHWiGHsq1WXCAfEIg/BkBMJiY=; b=QNGqQBLece/JlbbZf3creWkGeaYh7AvYT7t0EHJK1oab8rX45BQRjiWbeP6jFnElJy iW9NKOwdKvdI18OXNbwhCFrALBoSxibgAlsyTJsivjw+XAsAvEuddcDCf59TC4EBzfgf cevSWkwEbWEVKegmjnQf/c3D+Vy2ewv086huz7cOvAIo+ZGp1sWJGI8WegldTrkeG/rB Wr0MaaU+bfrTjXO2f9+Z9kbskqLX/v1tuzb5I/PrkMqd5VBwM57yOVYBb/TjXYPhkYZ6 pWBflUwl55dFJKLl7PUYbMvYyzq0fgh0JUx0g0yuTWzmITEWXw/HKlkyNzDbLutAcJ9K CGbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ch4jA9pONjtk/Z4LqeHHWiGHsq1WXCAfEIg/BkBMJiY=; b=XTac4m8YjgjwnpSNxHmTmUxENRwu02rLzNIm6V+NGvVwJQHprti+j4GddpV7LyS4DH Uta8vc/3rUoW4wJ79D2QaxGjhlNLuj3f/hFeFE4G/iP14uxw6Cwm4KtlesddqvUck+Tn jshK/FnYV3PESYL4DfywAfP4Hctw9cSi50NZcmKyaRK7X4/hbrVP6IDbp+eeVYpW+k7I UkM2JPMk/Y0MDYU0wH0ODjr2V4GqT/U2fq3IGVb5ewRLl+tbQNhVHL1QT7QB0fg5m8CC 0KhEsGI+ED7es1GwQ1fVdVRywIgsAOCtxtYKkass49GYjSb7vNYXMP3pcATNvXcI7hih ft5w== X-Gm-Message-State: APjAAAVpJnZDENzHOiumzVdHtIRSfsSZAtWPVEsMQFx3mRefwPXyQk60 2jcOfNrsXl2lbNu/TnZwqj/RxztOEiHha0rOCs8= X-Google-Smtp-Source: APXvYqz0oKtLKKMVCnayxkA0wWDlCeW2p/EMH+Dzj4XF0YauoZ24YMthjhbaevwUoelJizSQg1A1J69+Y+/onCzojeY= X-Received: by 2002:ac8:1605:: with SMTP id p5mr23151806qtj.79.1566255746695; Mon, 19 Aug 2019 16:02:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nathan Royce Date: Mon, 19 Aug 2019 18:02:18 -0500 Message-ID: Subject: Re: Kernel 5.2.8 - au0828 - Tuner Is Busy To: shuah Cc: Brad Love , sean@mess.org, Mauro Carvalho Chehab , Hans Verkuil , Greg Kroah-Hartman , Thomas Gleixner , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org (resubmitting due to non "reply-to-all"): Bugger, I just sent a reply to your last message, but it bounced back with: ***** 550 5.7.1 Content-Policy reject msg: The message contains HTML subpart, therefore we consider it SPAM or Outlook Virus. TEXT/PLAIN is accepted.! BF:; S1728494AbfHSVzk ***** I just switched this email to plain-text and will resubmit my previous email as plain-text. Anyway, yeah, all I did in au0828-cards.c was add my 0x0400 like: ***** { USB_DEVICE(0x2040, 0x7281), .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL }, { USB_DEVICE(0x05e1, 0x0400), .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY }, { USB_DEVICE(0x05e1, 0x0480), .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY }, { USB_DEVICE(0x2040, 0x8200), .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY }, ***** That's all I've ever had to do. I never knew about the quirks-table.h. I'll take a look. I saw in the log the 0x05e1 addition was made in 2016, but maybe it only applies to the Media Controller API change requirement now (thus, not having caused any problems in the past since the API wasn't being used). I've never sent in a patch before (anywhere. I just point out a problem and let the dev code it in their style). Also I don't want to be a bother in case something even that small could somehow break something else, especially for something "off-brand"(?). I never really minded building the module by itself. I've just now started the build for linux-5.2.y with the quirks-table.h change along with au0828-cards.c. Thanks for that heads-up. Hopefully that does the trick (whatever the trick/quirk is). On Mon, Aug 19, 2019 at 4:44 PM shuah wrote: > > On 8/19/19 2:49 PM, shuah wrote: > > Hi Nathan, > > > > Just catching up with this thread. Let me know what you find. Can you > > build your own kernel and see what you can find? > > > > You said you make changes to the > > "Whenever I update my kernel, I edit the > ./drivers/media/usb/au0828/au0828-cards.c file adding an entry for my > 0x400 device. > I've been doing it for years and it's been working fine... until now..." > > Please send me the changes you make to the file. I see the following > WOODBURY devices. I am assuming you add 0x400 entry. > > { USB_DEVICE(0x05e1, 0x0480), > .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY }, > { USB_DEVICE(0x2040, 0x8200), > .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY }, > > > There is another table in sound/usb/quirks-table.h for AU0828 > devices. In addition to 812658d88d26, 66354f18fe5f makes change > to this table to add a flag. I see two entries in that table: > > AU0828_DEVICE(0x05e1, 0x0480, "Hauppauge", "Woodbury"), > AU0828_DEVICE(0x2040, 0x8200, "Hauppauge", "Woodbury"), > > Since these drivers are now coupled doing resource sharing, > could it be that with your change to au02828 device table, > your changes are bow incomplete. > > I don't have a Woodbury device though. This is something to > try. > > Did you consider sending patch to add your device variant, > so you don't have to keep making this change whenever you > go to a new kernel? > > thanks, > -- Shuah