From: Jagan Teki <jagan@amarulasolutions.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Yong Deng <yong.deng@magewell.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
linux-media <linux-media@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
linux-amarula@amarulasolutions.com,
Michael Trimarchi <michael@amarulasolutions.com>
Subject: Re: [PATCH v3 3/6] media: sun6i: Set 300MHz mod clock for A64
Date: Tue, 11 Dec 2018 21:20:40 +0530 [thread overview]
Message-ID: <CAMty3ZBA9W0MA7BR=Cn73KbE-fSs=WXe_47c_69JpizhbsXa-g@mail.gmail.com> (raw)
In-Reply-To: <20181211154427.uekytnmp2wlgxwm2@flea>
On Tue, Dec 11, 2018 at 9:14 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Mon, Dec 10, 2018 at 05:22:43PM +0530, Jagan Teki wrote:
> > The default CSI_SCLK seems unable to drive the sensor to capture
> > the image, so update it to working clock rate 300MHz for A64.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> > index bbe45e893722..4b872800b244 100644
> > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> > @@ -822,6 +822,11 @@ static int sun6i_csi_resource_request(struct sun6i_csi_dev *sdev,
> > return PTR_ERR(sdev->clk_mod);
> > }
> >
> > + /* A64 need 300MHz mod clock to operate properly */
> > + if (of_device_is_compatible(pdev->dev.of_node,
> > + "allwinner,sun50i-a64-csi"))
> > + clk_set_rate_exclusive(sdev->clk_mod, 300000000);
> > +
>
> Where is that 300MHz coming from? You claim in your comment that it
from BSP, even "Chen-Yu Tsai" mentioned the same. (Chen-Yu, can you
comment here)
> "operates properly", yet in your previous mail about this, you were
> saying that 1080p @30Hz is broken. Which one is it?
1080p is broken from sensor end, ie what I mentioned on the respective mail.
next prev parent reply other threads:[~2018-12-11 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 11:52 [PATCH v3 0/6] media/sun6i: Allwinner A64 CSI support Jagan Teki
2018-12-10 11:52 ` [PATCH v3 1/6] dt-bindings: media: sun6i: Add A64 CSI compatible Jagan Teki
2018-12-10 23:24 ` Rob Herring
2018-12-10 11:52 ` [PATCH v3 2/6] media: sun6i: Add A64 compatible support Jagan Teki
2018-12-11 15:43 ` Maxime Ripard
2018-12-10 11:52 ` [PATCH v3 3/6] media: sun6i: Set 300MHz mod clock for A64 Jagan Teki
2018-12-11 15:44 ` Maxime Ripard
2018-12-11 15:50 ` Jagan Teki [this message]
2018-12-10 11:52 ` [PATCH v3 4/6] arm64: dts: allwinner: a64: Add A64 CSI controller Jagan Teki
2018-12-10 11:52 ` [PATCH v3 5/6] arm64: dts: allwinner: a64: Add pinmux setting for CSI MCLK on PE1 Jagan Teki
2018-12-10 11:52 ` [PATCH v3 6/6] arm64: dts: allwinner: a64-amarula-relic: Add OV5640 camera node Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMty3ZBA9W0MA7BR=Cn73KbE-fSs=WXe_47c_69JpizhbsXa-g@mail.gmail.com' \
--to=jagan@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).