From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Ramesh Shanmugasundaram <rashanmu@gmail.com>,
Vinod <vkoul@kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] media: rcar_drif: Use dma_request_chan() instead dma_request_slave_channel()
Date: Mon, 20 Jan 2020 13:05:09 +0100 [thread overview]
Message-ID: <CAMuHMdUPhabZrXJ3UqSVTdy2aWf6VG27q287MizKJ5q5tyRnwA@mail.gmail.com> (raw)
In-Reply-To: <20191217104025.23318-1-peter.ujfalusi@ti.com>
On Tue, Dec 17, 2019 at 11:41 AM Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
One comment below.
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -275,10 +275,10 @@ static int rcar_drif_alloc_dmachannels(struct rcar_drif_sdr *sdr)
> for_each_rcar_drif_channel(i, &sdr->cur_ch_mask) {
> struct rcar_drif *ch = sdr->ch[i];
>
> - ch->dmach = dma_request_slave_channel(&ch->pdev->dev, "rx");
> - if (!ch->dmach) {
> + ch->dmach = dma_request_chan(&ch->pdev->dev, "rx");
> + if (IS_ERR(ch->dmach)) {
> rdrif_err(sdr, "ch%u: dma channel req failed\n", i);
Now there is an error code, you might (1) want to print it, and (2) only
do so when it is not due to probe deferral:
if (PTR_ERR(ch->dmach) != -EPROBE_DEFER)
rdrif_err(sdr, "ch%u: dma channel req failed %pe\n",
i, ch->dmach);
> - ret = -ENODEV;
> + ret = PTR_ERR(ch->dmach);
> goto dmach_error;
> }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-01-20 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 10:40 [PATCH] media: rcar_drif: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2020-01-20 12:05 ` Geert Uytterhoeven [this message]
2020-01-20 12:10 ` Peter Ujfalusi
2020-01-20 12:36 ` Geert Uytterhoeven
2020-01-20 12:43 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUPhabZrXJ3UqSVTdy2aWf6VG27q287MizKJ5q5tyRnwA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rashanmu@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).