From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] media: dt-bindings: media: renesas,csi2: Node port@0 is not mandatory
Date: Mon, 19 Apr 2021 11:06:11 +0200 [thread overview]
Message-ID: <CAMuHMdUzX0JgcBixX0X9JoZQkZ_aVQ1YCuUz-QKyTr4OLfsjWA@mail.gmail.com> (raw)
In-Reply-To: <YHlFWvVBps2vYnPM@oden.dyn.berto.se>
Hi Niklas,
On Fri, Apr 16, 2021 at 10:08 AM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> On 2021-04-15 22:09:12 +0300, Laurent Pinchart wrote:
> > On Tue, Apr 13, 2021 at 05:53:46PM +0200, Niklas Söderlund wrote:
> > > When converting the binding to use the video-interfaces schemas the node
> > > port@0 was incorrectly made a mandatory property.
> > >
> > > The port@0 node describes which CSI-2 transmitter the R-Car CSI-2
> > > receiver is connected too. Not all boards connects all CSI-2 receivers
> > > to an CSI-2 transmitter.
> >
> > Ports are properties of the device, they should always be there,
> > regardless of connections. It's the endpoints that describe connections.
>
> I understand what you are saying and if that is the way things are done
> I'm fine with it. As this was brought to light by a recent change in the
> bindings I wish to understand if this was always the case the bindings
> have been wrong all along or not.
>
> I only ask as because if we keep the port@0 mandatory there will be
> board files that needs to add empty port@0 nodes as we know they are not
s/board/SoC .dtsi/
> used. And as the media bindings are already quiet large for some Renesas
> boards I want to understand this before spewing out a lot of patches
> adding empty nodes ;-)
>
> >
> > > Fixes: 066a94e28a23e04c ("media: dt-bindings: media: Use graph and video-interfaces schemas")
> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > > ---
> > > Documentation/devicetree/bindings/media/renesas,csi2.yaml | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/renesas,csi2.yaml b/Documentation/devicetree/bindings/media/renesas,csi2.yaml
> > > index 20396f1be9993461..395484807dd5ed47 100644
> > > --- a/Documentation/devicetree/bindings/media/renesas,csi2.yaml
> > > +++ b/Documentation/devicetree/bindings/media/renesas,csi2.yaml
> > > @@ -78,7 +78,6 @@ properties:
> > > modules connected the CSI-2 receiver.
> > >
> > > required:
> > > - - port@0
> > > - port@1
> > >
> > > required:
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-04-19 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 15:53 [PATCH] media: dt-bindings: media: renesas,csi2: Node port@0 is not mandatory Niklas Söderlund
2021-04-15 19:09 ` Laurent Pinchart
2021-04-16 8:05 ` Niklas Söderlund
2021-04-19 9:06 ` Geert Uytterhoeven [this message]
2021-04-21 9:43 ` Laurent Pinchart
2021-04-21 12:31 ` Niklas Söderlund
2021-04-21 12:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUzX0JgcBixX0X9JoZQkZ_aVQ1YCuUz-QKyTr4OLfsjWA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).