From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6AD7C43331 for ; Mon, 30 Mar 2020 08:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACD3C2073B for ; Mon, 30 Mar 2020 08:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729683AbgC3Ic7 (ORCPT ); Mon, 30 Mar 2020 04:32:59 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:41144 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729623AbgC3Ic7 (ORCPT ); Mon, 30 Mar 2020 04:32:59 -0400 Received: by mail-ot1-f65.google.com with SMTP id f52so17129875otf.8; Mon, 30 Mar 2020 01:32:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Gel9b97+smELIFrYMFWtxb4iAAaZuDZrq93k+9Vr7r4=; b=NlYBAmp1jCwwq1vNfI79j7ng4FcxAiexvVZEYP2mDRgxOkLDSvs70CgV3w0O13Z7s5 qA8i66eoOYXxKm1z1lqoe39p//KwKVg+IsMBc2RrVmQVzTShaKtXr/c1xEtp+wgiynDR JHn5fEXNaehKrfw+eR95Mn0VBeTv0WgvlFxHBZ8ZlmmcYRIAdSlr2Ci7MIDUf0lblLhG Tr2c5zRwFF3qvfVd51IkW4Tg+aCboIL2bmCQBn0Ejylil9qAeQO0w0QqggNIpYDuKTUn X0K7qkjdKE82hvYKpl76ZXmsQKCtMsPfQ1r1t6y7s2/NXO02b2+XkJuqd6Bgw30nZKZk 9FdQ== X-Gm-Message-State: ANhLgQ1HGqvKIlJ77VdfwD0i6Jnfq7dIRUBF9TuV/xpq8/KMXq3fzB87 s/TX9WYs/ElzJnp0N7rVRDqwP8r5z2S9Hn/3YN8= X-Google-Smtp-Source: ADFU+vsqb9g7ydmxPiqUUnhhqa6SbE8Ps8XkrQDmUFKt73Iz/YKOQFjnoHB8Y6abBUc6tZj75G8C2+Fn3ZS8XPvCGPY= X-Received: by 2002:a05:6830:15c2:: with SMTP id j2mr7847135otr.107.1585557178365; Mon, 30 Mar 2020 01:32:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Mon, 30 Mar 2020 10:32:47 +0200 Message-ID: Subject: Re: [PATCH v4 9/9] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC To: Alex Riesen , Kieran Bingham , Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Alex, On Thu, Mar 26, 2020 at 11:55 AM Alex Riesen wrote: > As all known variants of the Salvator board have the HDMI decoder > chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482 > endpoint and the connection definitions are placed in the common board > file. > > For the same reason, the CLK_C clock line and I2C configuration (similar > to the ak4613, on the same interface) are added into the common file. > > Signed-off-by: Alexander Riesen Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > @@ -460,7 +460,7 @@ pca9654: gpio@20 { > #gpio-cells = <2>; > }; > > - video-receiver@70 { > + adv7482_hdmi_in: video-receiver@70 { > compatible = "adi,adv7482"; > reg = <0x70 0x71 0x72 0x73 0x74 0x75 > 0x60 0x61 0x62 0x63 0x64 0x65>; > @@ -469,6 +469,7 @@ video-receiver@70 { > > #address-cells = <1>; > #size-cells = <0>; > + #clock-cells = <0>; /* the MCLK for I2S output */ > > interrupt-parent = <&gpio6>; > interrupt-names = "intrq1", "intrq2"; > @@ -510,6 +511,15 @@ adv7482_txb: endpoint { > remote-endpoint = <&csi20_in>; > }; > }; > + > + port@c { > + reg = <12>; > + > + adv7482_i2s: endpoint { > + remote-endpoint = <&rsnd_endpoint3>; > + system-clock-direction-out; > + }; > + }; As the adv748x driver just ignores "invalid" endpoints... > @@ -733,8 +744,8 @@ &rcar_sound { > pinctrl-0 = <&sound_pins &sound_clk_pins>; > pinctrl-names = "default"; > > - /* Single DAI */ > - #sound-dai-cells = <0>; > + /* multi DAI */ > + #sound-dai-cells = <1>; > > /* audio_clkout0/1/2/3 */ > #clock-cells = <1>; > @@ -758,8 +769,19 @@ &rcar_sound { > <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, > <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, > <&audio_clk_a>, <&cs2000>, > - <&audio_clk_c>, > + <&adv7482_hdmi_in>, > <&cpg CPG_CORE CPG_AUDIO_CLK_I>; ... and the rsnd driver ignores nonexistent-clocks, the DT change has no hard dependency on the driver change, and won't introduce regressions when included, right? > @@ -777,6 +799,21 @@ rsnd_endpoint0: endpoint { > capture = <&ssi1 &src1 &dvc1>; > }; > }; > + rsnd_port3: port@3 { > + reg = <3>; > + rsnd_endpoint3: endpoint { > + remote-endpoint = <&adv7482_i2s>; > + > + dai-tdm-slot-num = <8>; > + dai-tdm-slot-width = <32>; > + dai-format = "left_j"; > + mclk-fs = <256>; > + bitclock-master = <&adv7482_i2s>; > + frame-master = <&adv7482_i2s>; > + > + capture = <&ssi4>; > + }; > + }; > }; > }; However, as salvator-common.dtsi is shared by all Salvator-X(S) variants, you'll have to add a dummy ssi4 node to r8a77961.dtsi first. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds