Linux-Media Archive on lore.kernel.org
 help / color / Atom feed
From: Ricardo Ribalda <ribalda@chromium.org>
To: kieran.bingham+renesas@ideasonboard.com
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH] media: staging/intel-ipu3 : Do not zero reserved fields
Date: Tue, 12 Jan 2021 13:14:42 +0100
Message-ID: <CANiDSCsao8=gpSg_1sBdso97iLCPcGD4GM3jcMEQGB2mOcghaQ@mail.gmail.com> (raw)
In-Reply-To: <8fb0c69c-bf17-328e-1b08-ab6316b65b83@ideasonboard.com>

Hi Kieran

On Tue, Jan 12, 2021 at 12:59 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
>
> Hi Ricardo,
>
> On 11/01/2021 14:54, Ricardo Ribalda wrote:
> > Core code already clears reserved fields of struct
> > v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
> > v4l2_plane_pix_format reserved fields").
> >
> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>
> This is just 9/9 of the series right ? ;-)

I was just testing that you were doing a good review :P

My bad, I sent the mails with git email-send 00* and I forgot to clean
before :(. I already marked the patch as obsolete in patchwork. Sorry
for wasting your time

Best regards!

> --
> Kieran
>
> > ---
> >  drivers/staging/media/ipu3/ipu3-v4l2.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> > index 4dc8d9165f63..60aa02eb7d2a 100644
> > --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> > +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> > @@ -773,9 +773,6 @@ static int imgu_try_fmt(struct file *file, void *fh, struct v4l2_format *f)
> >
> >       pixm->pixelformat = fmt->fourcc;
> >
> > -     memset(pixm->plane_fmt[0].reserved, 0,
> > -            sizeof(pixm->plane_fmt[0].reserved));
> > -
> >       return 0;
> >  }
> >
> >
>


-- 
Ricardo Ribalda

  reply index

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 14:54 [PATCH 1/9] media: ipu3-cio2: " Ricardo Ribalda
2021-01-11 14:54 ` [PATCH] media: staging/intel-ipu3 : " Ricardo Ribalda
2021-01-12 11:59   ` Kieran Bingham
2021-01-12 12:14     ` Ricardo Ribalda [this message]
2021-01-11 14:54 ` [PATCH 2/9] media: mtk-mdp: " Ricardo Ribalda
2021-01-12 12:01   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 3/9] media: mtk-vcodec: " Ricardo Ribalda
2021-01-12 12:09   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 4/9] media: fdp1: " Ricardo Ribalda
2021-01-12 10:58   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 5/9] media: jpu: " Ricardo Ribalda
2021-01-12 11:07   ` Kieran Bingham
2021-01-21  9:53     ` Hans Verkuil
2021-01-11 14:54 ` [PATCH 6/9] media: sum4i-csi: " Ricardo Ribalda
2021-01-11 18:11   ` Ezequiel Garcia
2021-01-12 11:10   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 7/9] media: ti-vpe: " Ricardo Ribalda
2021-01-12 11:12   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 8/9] media: vicodec: " Ricardo Ribalda
2021-01-12 11:44   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 9/9] media: staging/intel-ipu3 : " Ricardo Ribalda
2021-01-12 11:55   ` Kieran Bingham
2021-01-12 11:58 ` [PATCH 1/9] media: ipu3-cio2: " Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiDSCsao8=gpSg_1sBdso97iLCPcGD4GM3jcMEQGB2mOcghaQ@mail.gmail.com' \
    --to=ribalda@chromium.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Media Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \
		linux-media@vger.kernel.org
	public-inbox-index linux-media

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git