From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7705FC433DB for ; Tue, 12 Jan 2021 12:15:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3902823109 for ; Tue, 12 Jan 2021 12:15:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732838AbhALMPf (ORCPT ); Tue, 12 Jan 2021 07:15:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732818AbhALMPf (ORCPT ); Tue, 12 Jan 2021 07:15:35 -0500 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E61B0C061794 for ; Tue, 12 Jan 2021 04:14:54 -0800 (PST) Received: by mail-io1-xd34.google.com with SMTP id w18so3504420iot.0 for ; Tue, 12 Jan 2021 04:14:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qJL4JUyVXMfbMHqv+BM1N6i62BH9jhBqq5i/XcID/Eo=; b=II8D82E6AzHZZLtAWQVebainBcvHg800YO6VLekfQ2TUR6KefyDr9x97Gvi/tYJKJ8 5rKNZT6/FZhfegQbsQQnS1wJWc8aXgi6O8V4fD0Qj7lsr5IM/yYn2krgnXKrxhwi5dT0 2f9VZUV9GwdPDsCxHBEAqhzbCchtmJabRI7+A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qJL4JUyVXMfbMHqv+BM1N6i62BH9jhBqq5i/XcID/Eo=; b=UIn1kd71xxJ1wsbb+n69YkkNtnOEKnPRqYozzWouNNr6OcYGRKhCOSsM6R/JlRHCAv ujUN1VxM4wRhokJXXgRKn7FD6sPhr8Pm3TKvj2NT0fd3BYItySZbzAGnzrGC/thBSXEG Pq5Y0Ogb57ENVyL6PWm0IbAmcXEqqB5gK8mzXvLi6Yb5rtBmLb+Pf4uxouocaEzepUW3 VBeTchplG2mPx+QjiOYaYpc9X/n/NSUj1pHBQd7SnSAWpsiUGv9RnEn/VnYwWiUoLlG8 pEshyJ0MwS3fM4Nf/xs553Ru+8oHzSBa2h8a36lTnDXEEgtMvAhO+heR/u66eLWzn4nr qJ7w== X-Gm-Message-State: AOAM532NShxT2TIItNYNoXK8Waz3LADFJcXLJhDs+Jruo+xjyFcAF5Av oitTJSv+TZ05KhwZTGaRHpegxXc1+8gsb9Dy X-Google-Smtp-Source: ABdhPJw3dc2+0sJmrIGOzqlqMedra+rNnwgFBF1UEKs7LV4URRc7O/byH/LH8jibsNMYUrxmketEOA== X-Received: by 2002:a92:cb82:: with SMTP id z2mr3592072ilo.195.1610453694080; Tue, 12 Jan 2021 04:14:54 -0800 (PST) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com. [209.85.166.43]) by smtp.gmail.com with ESMTPSA id q2sm552221ioh.36.2021.01.12.04.14.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jan 2021 04:14:53 -0800 (PST) Received: by mail-io1-f43.google.com with SMTP id 81so3412236ioc.13 for ; Tue, 12 Jan 2021 04:14:53 -0800 (PST) X-Received: by 2002:a05:6638:2243:: with SMTP id m3mr3857184jas.115.1610453692875; Tue, 12 Jan 2021 04:14:52 -0800 (PST) MIME-Version: 1.0 References: <20210111145445.28854-1-ribalda@chromium.org> <20210111145445.28854-2-ribalda@chromium.org> <8fb0c69c-bf17-328e-1b08-ab6316b65b83@ideasonboard.com> In-Reply-To: <8fb0c69c-bf17-328e-1b08-ab6316b65b83@ideasonboard.com> From: Ricardo Ribalda Date: Tue, 12 Jan 2021 13:14:42 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] media: staging/intel-ipu3 : Do not zero reserved fields To: kieran.bingham+renesas@ideasonboard.com Cc: Linux Media Mailing List , Linux Kernel Mailing List , Sakari Ailus Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Kieran On Tue, Jan 12, 2021 at 12:59 PM Kieran Bingham wrote: > > Hi Ricardo, > > On 11/01/2021 14:54, Ricardo Ribalda wrote: > > Core code already clears reserved fields of struct > > v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero > > v4l2_plane_pix_format reserved fields"). > > > > Cc: Sakari Ailus > > Signed-off-by: Ricardo Ribalda > > This is just 9/9 of the series right ? ;-) I was just testing that you were doing a good review :P My bad, I sent the mails with git email-send 00* and I forgot to clean before :(. I already marked the patch as obsolete in patchwork. Sorry for wasting your time Best regards! > -- > Kieran > > > --- > > drivers/staging/media/ipu3/ipu3-v4l2.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c > > index 4dc8d9165f63..60aa02eb7d2a 100644 > > --- a/drivers/staging/media/ipu3/ipu3-v4l2.c > > +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c > > @@ -773,9 +773,6 @@ static int imgu_try_fmt(struct file *file, void *fh, struct v4l2_format *f) > > > > pixm->pixelformat = fmt->fourcc; > > > > - memset(pixm->plane_fmt[0].reserved, 0, > > - sizeof(pixm->plane_fmt[0].reserved)); > > - > > return 0; > > } > > > > > -- Ricardo Ribalda