linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Steve Longerbeam <slongerbeam@gmail.com>
Cc: linux-media <linux-media@vger.kernel.org>,
	"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	open list <linux-kernel@vger.kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH 1/2] media: imx: csi: Disable CSI immediately after last EOF
Date: Thu, 17 Jan 2019 18:20:30 -0200	[thread overview]
Message-ID: <CAOMZO5BtS_iLcUH0zO1u_L+jVCena-WzRJgR3NUif7UoxQAYVw@mail.gmail.com> (raw)
In-Reply-To: <20190117201347.27347-2-slongerbeam@gmail.com>

Hi Steve,

On Thu, Jan 17, 2019 at 6:15 PM Steve Longerbeam <slongerbeam@gmail.com> wrote:
>
> Disable the CSI immediately after receiving the last EOF before stream
> off (and thus before disabling the IDMA channel).
>
> This fixes a complete system hard lockup on the SabreAuto when streaming
> from the ADV7180, by repeatedly sending a stream off immediately followed
> by stream on:
>
> while true; do v4l2-ctl  -d4 --stream-mmap --stream-count=3; done
>
> Eventually this either causes the system lockup or EOF timeouts at all
> subsequent stream on, until a system reset.
>
> The lockup occurs when disabling the IDMA channel at stream off. Disabling
> the CSI before disabling the IDMA channel appears to be a reliable fix for
> the hard lockup.
>
> Reported-by: Gaël PORTAY <gael.portay@collabora.com>
> Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>

Thanks. Since this fixes a lockup, maybe it is worth adding a Fixes
tag and Cc stable?

> ---
>  drivers/staging/media/imx/imx-media-csi.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index e18f58f56dfb..9218372cb997 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -681,6 +681,8 @@ static void csi_idmac_stop(struct csi_priv *priv)
>         if (ret == 0)
>                 v4l2_warn(&priv->sd, "wait last EOF timeout\n");
>
> +       ipu_csi_disable(priv->csi);
> +
>         devm_free_irq(priv->dev, priv->eof_irq, priv);
>         devm_free_irq(priv->dev, priv->nfb4eof_irq, priv);
>
> @@ -793,11 +795,10 @@ static void csi_stop(struct csi_priv *priv)
>                 /* stop the frame interval monitor */
>                 if (priv->fim)
>                         imx_media_fim_set_stream(priv->fim, NULL, false);
> +       } else {
> +               ipu_csi_disable(priv->csi);
>         }
> -
> -       ipu_csi_disable(priv->csi);
>  }
> -

Unneeded line removal.

  reply	other threads:[~2019-01-17 20:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 20:13 [PATCH 0/2] media: imx: Disable CSI immediately after last EOF Steve Longerbeam
2019-01-17 20:13 ` [PATCH 1/2] media: imx: csi: " Steve Longerbeam
2019-01-17 20:20   ` Fabio Estevam [this message]
2019-01-17 20:22     ` Steve Longerbeam
2019-01-17 20:13 ` [PATCH 2/2] media: imx: prpencvf: " Steve Longerbeam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5BtS_iLcUH0zO1u_L+jVCena-WzRJgR3NUif7UoxQAYVw@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).