From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59897C43461 for ; Thu, 10 Sep 2020 08:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E78F42078B for ; Thu, 10 Sep 2020 08:45:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="INguoyub" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730233AbgIJIpn (ORCPT ); Thu, 10 Sep 2020 04:45:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730127AbgIJIoN (ORCPT ); Thu, 10 Sep 2020 04:44:13 -0400 Received: from mail-oo1-xc41.google.com (mail-oo1-xc41.google.com [IPv6:2607:f8b0:4864:20::c41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEB65C061798 for ; Thu, 10 Sep 2020 01:43:38 -0700 (PDT) Received: by mail-oo1-xc41.google.com with SMTP id q34so1238343ooi.13 for ; Thu, 10 Sep 2020 01:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RM+6YCueDPy1nkorG5jfOVGfbj1m5UCHBF4PF2PU/iI=; b=INguoyube130+8WwnXu/RYMh/Ju9WC30cNYDrviHqjIJBbZccMMVak/rSrOZ3ijhHR OmyS41tmWGU9bUjUr28yjCNpFgi3MHy2KYoaUXyZmwIZPZiIiwAojnfIKdvrGosGbjPA JydJiXyNitT7guWnNfOTvv7Z4wIAc2T/tudn8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RM+6YCueDPy1nkorG5jfOVGfbj1m5UCHBF4PF2PU/iI=; b=RBZsozyixY/DLIqSISPWG4og7z1foetjwztfQ/3V8I/I+qlhNN9H3xR92wwmBZ/WJR JPYh1PIq31wVNu1rgcHGc/weg0HmEYnkn57ku+1rQK1Vt9OYhsskaKV/FjwHtdLZiil4 CgRMRMhT14MC+fZNGqA3Br5IG3MKpwuGBRCg8kTLx5nFON0knwzq/39nDS57iSmyFXH0 xOXkFLDEIY4hjcFheWvDCrxny4SPc4dKKMRXxhVrddJcCqKyIlicm4pBAmJ1lHP6e5OK wzrJ72CBpEU4i6JHn16+yv00COntUOpqV403qzI+OmiVp+apsjixDiLtOF7duk1G2/IN 75NQ== X-Gm-Message-State: AOAM530u3flI7a0AXh53nLvSZLYuOU0+IaMG0EoghCDMG+vEtQ0k+1ej erT5YUSeznJ3t0w8NdytFzfBYYswDfGv6g== X-Google-Smtp-Source: ABdhPJy1QBjFrYlzxZavtv330ziyF2jgtDwzc1sWTqFNa1QbsVecpcCs6jCSzTFGHpXOe0zfXP747g== X-Received: by 2002:a4a:5258:: with SMTP id d85mr3620201oob.72.1599727417965; Thu, 10 Sep 2020 01:43:37 -0700 (PDT) Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com. [209.85.167.173]) by smtp.gmail.com with ESMTPSA id l63sm817040oia.56.2020.09.10.01.43.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2020 01:43:37 -0700 (PDT) Received: by mail-oi1-f173.google.com with SMTP id a3so5205854oib.4 for ; Thu, 10 Sep 2020 01:43:36 -0700 (PDT) X-Received: by 2002:aca:1209:: with SMTP id 9mr2982017ois.94.1599727416353; Thu, 10 Sep 2020 01:43:36 -0700 (PDT) MIME-Version: 1.0 References: <20200518174011.15543-1-ezequiel@collabora.com> <20200518174011.15543-3-ezequiel@collabora.com> In-Reply-To: From: Alexandre Courbot Date: Thu, 10 Sep 2020 17:43:24 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/3] media: uapi: Add VP9 stateless decoder controls To: Ezequiel Garcia Cc: Linux Media Mailing List , linux-rockchip@lists.infradead.org, LKML , Tomasz Figa , kernel@collabora.com, Jonas Karlman , Heiko Stuebner , Hans Verkuil , Jeffrey Kardatzke , Gustavo Padovan , Nicolas Dufresne , Boris Brezillon Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Sep 10, 2020 at 3:04 PM Alexandre Courbot wrote: > > Hi Ezequiel, sorry for the late review! > > On Tue, May 19, 2020 at 2:40 AM Ezequiel Garcia wrote: > > > > From: Boris Brezillon > > > > Add the VP9 stateless decoder controls plus the documentation that goes > > with it. > > > > Signed-off-by: Boris Brezillon > > Signed-off-by: Ezequiel Garcia > > --- > > .../userspace-api/media/v4l/biblio.rst | 10 + > > .../media/v4l/ext-ctrls-codec.rst | 550 ++++++++++++++++++ > > drivers/media/v4l2-core/v4l2-ctrls.c | 239 ++++++++ > > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > > include/media/v4l2-ctrls.h | 1 + > > include/media/vp9-ctrls.h | 485 +++++++++++++++ Also another thing I missed: shouldn't the new pointer controls be added to union v4l2_ctrl_ptr in v4l2-ctrls.h?