From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 899F9C2BBCF for ; Fri, 18 Dec 2020 14:31:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D75A23AC1 for ; Fri, 18 Dec 2020 14:31:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726436AbgLRObI (ORCPT ); Fri, 18 Dec 2020 09:31:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbgLRObI (ORCPT ); Fri, 18 Dec 2020 09:31:08 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 731BEC0617A7 for ; Fri, 18 Dec 2020 06:30:27 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id c133so2525647wme.4 for ; Fri, 18 Dec 2020 06:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cSf/A3KMFP7l6dKoCFldn4orJN3Li1SRGvRFJDZdZBk=; b=FAxD2Y0NbqFM3ObrBbKO1uzFTAkuZkfq4nO0/y02pStuULzcEQVJ++qE6xjAOWSiMJ Z+zJK/11O7gH7sBtClCoRC44Lu5RNjqID1MNzTa4s/odoqiMyCdQE7nRSDhOIstJf1nv GoaY7I4IJDvHuiglAV1NWAN18RRDFPmabOcytUignipoOKlOQkMbQ+WDk0oqEuda5C8P eqDwlymwP/5kXCAkXMbeuU6nLmgGm8gdBKksDocR0F6Her14FIhXm+vqz+vCxEWde6iH Ui7oJC4E7fWuKt027IzbeCK6dw/U1rS3uFhcgxG/51fn3oVXly8LPUrMCwOpXTcbwavv jreg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cSf/A3KMFP7l6dKoCFldn4orJN3Li1SRGvRFJDZdZBk=; b=O+b3SgNRP+EWO7Gre5jhdcf8Oub/Qe6a9IOKd26rUmaHRoHAX235fU2Z4jVycq7swr F8y2kfIFK4kgukK0QeDpvw302WUe/gPiTtcZcuoXgUdPcO58Q9zq58cJauTQAG7eEV93 PfcUJJf58ctE+/3pJ+fBwm/upSk8AqbmEpk5daGHweBVxj46y/m3lq6kKbWn6U1YvfUK YgTR5g06GkR7oo8DKJjxd6+Zrq+oSAZti5rus7mcZkJiwJSzrrwZJ3dpvJL1QMLfI7jf 0heWvrn6b65zvF/yexBdiaUsLO1fQ2UmT6ITNaGgZkkq1GXDNyRXSYWJfD9/ZFHNfl+G z7pg== X-Gm-Message-State: AOAM530bvGVWfSJ/F0pY2cc+btOWrzcti0D01+yDmLq4j0NTBwSxykJm ql1w4Mhv73RsbO0ipoVbzVM3ESk/Tn8DwMz/1HJE3w== X-Google-Smtp-Source: ABdhPJwZPxE2hgQD4zqrk0QkQvmTF5EOdTM22UN833i/JzSn6RMW16hnmxGVt7Jtvfucob2k4gTUusWtU/lA6XrmCQw= X-Received: by 2002:a1c:9a57:: with SMTP id c84mr4329681wme.183.1608301826242; Fri, 18 Dec 2020 06:30:26 -0800 (PST) MIME-Version: 1.0 References: <20201210134648.272857-1-maxime@cerno.tech> <20201210134648.272857-12-maxime@cerno.tech> In-Reply-To: <20201210134648.272857-12-maxime@cerno.tech> From: Dave Stevenson Date: Fri, 18 Dec 2020 14:30:09 +0000 Message-ID: Subject: Re: [PATCH 11/15] drm/vc4: hdmi: Remove cec_available flag To: Maxime Ripard Cc: Eric Anholt , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , Jason Cooper , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Linux Media Mailing List , Hans Verkuil , LKML , Mauro Carvalho Chehab , Thomas Gleixner , linux-rpi-kernel@lists.infradead.org, DRI Development , Dom Cobley Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Dom & Maxime On Thu, 10 Dec 2020 at 13:47, Maxime Ripard wrote: > > From: Dom Cobley > > Now that our HDMI controller supports CEC for the BCM2711, let's remove > that flag. > > Signed-off-by: Dom Cobley > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ---- > drivers/gpu/drm/vc4/vc4_hdmi.h | 3 --- > 2 files changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index d208b7d1d937..327638d93032 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -1658,9 +1658,6 @@ static int vc4_hdmi_cec_init(struct vc4_hdmi *vc4_hdmi) > u32 value; > int ret; > > - if (!vc4_hdmi->variant->cec_available) > - return 0; > - > vc4_hdmi->cec_adap = cec_allocate_adapter(&vc4_hdmi_cec_adap_ops, > vc4_hdmi, "vc4", > CEC_CAP_DEFAULTS | > @@ -2074,7 +2071,6 @@ static const struct vc4_hdmi_variant bcm2835_variant = { > .debugfs_name = "hdmi_regs", > .card_name = "vc4-hdmi", > .max_pixel_clock = 162000000, > - .cec_available = true, > .registers = vc4_hdmi_fields, > .num_registers = ARRAY_SIZE(vc4_hdmi_fields), > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.h b/drivers/gpu/drm/vc4/vc4_hdmi.h > index 27352827f70c..c93ada62f429 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.h > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.h > @@ -42,9 +42,6 @@ struct vc4_hdmi_variant { > /* Filename to expose the registers in debugfs */ > const char *debugfs_name; > > - /* Set to true when the CEC support is available */ > - bool cec_available; > - > /* Maximum pixel clock supported by the controller (in Hz) */ > unsigned long long max_pixel_clock; > > -- > 2.28.0 >