From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 162D5C3A59E for ; Wed, 21 Aug 2019 16:40:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF828206BA for ; Wed, 21 Aug 2019 16:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566405637; bh=eLVhmjLNhIMLZZjdqWDukswrRlkV0kuXO3dS9QrC/aU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=CM8qemk41BzUAoXCwHWyoEaG1GHJaztJMjYDPUlHIMTQNRZXUizKFqyTSfCtwYm00 Slj9Q1W7JhZbue31nT4ycVkindvtVFMWmj6C0UTi3cR+XLlpNFvfX2FaTC4j/q2kXg P/zi9EvBKPB83ws0pT7IqCKSkRhcNEv+Bzd5cMf4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729643AbfHUQkd (ORCPT ); Wed, 21 Aug 2019 12:40:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:57608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728806AbfHUQkd (ORCPT ); Wed, 21 Aug 2019 12:40:33 -0400 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 27AE22339F; Wed, 21 Aug 2019 16:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566405632; bh=eLVhmjLNhIMLZZjdqWDukswrRlkV0kuXO3dS9QrC/aU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IdqhTaUrH8ylMxq2eaVChVjp1DLFMiNAP91pxJOzldiPcbNQ1FLreYnx8wWl5YtIK EsjjJj69ldHa/PgtAsQw7+NgLs1xqf+0XnGGTYXRfNPLdAe/N9vPCppd6gVvMRllRD weTqJ/6/+iGvy6EpFqWFjL3xf2DxzQ8EnzjwjnY0= Received: by mail-lf1-f48.google.com with SMTP id b17so2292799lff.7; Wed, 21 Aug 2019 09:40:32 -0700 (PDT) X-Gm-Message-State: APjAAAX3xqocWgcOf5RgBzc13tgMYxSN2beSrRi5rwfyqzQTmAUqnuii J/e1znW5SMdLX4HLNwojn1tqOOiJKhaoftn8jkY= X-Google-Smtp-Source: APXvYqwT/36UbVBX6mo7+xkO8e2JanFOODu9B3xjLG9XlzyxH4yIuiugMn/CvKnM9WXnCEWyDwVmzXHNJGzCDTOl6Lg= X-Received: by 2002:a19:82c3:: with SMTP id e186mr18643045lfd.18.1566405630317; Wed, 21 Aug 2019 09:40:30 -0700 (PDT) MIME-Version: 1.0 References: <20190820094027.4144-1-ribalda@kernel.org> <20190820094027.4144-2-ribalda@kernel.org> <1566315769.3030.20.camel@pengutronix.de> In-Reply-To: <1566315769.3030.20.camel@pengutronix.de> From: Ricardo Ribalda Delgado Date: Wed, 21 Aug 2019 18:40:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/3] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE To: Philipp Zabel Cc: Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , linux-media , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Philipp On Tue, Aug 20, 2019 at 5:42 PM Philipp Zabel wrote: > > On Tue, 2019-08-20 at 11:40 +0200, Ricardo Ribalda Delgado wrote: > > New control to pass to userspace the width/height of a pixel. Which is > > needed for calibration and lens selection. > > > > Signed-off-by: Ricardo Ribalda Delgado > > --- > > Documentation/media/uapi/v4l/ext-ctrls-camera.rst | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst > > index 51c1d5c9eb00..b43047d4e7a1 100644 > > --- a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst > > +++ b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst > > @@ -510,6 +510,14 @@ enum v4l2_scene_mode - > > value down. A value of zero stops the motion if one is in progress > > and has no effect otherwise. > > > > +``V4L2_CID_UNIT_CELL_SIZE (struct)`` > > + This control returns the unit cell size in nanometres. The struct provides > > + the width and the height in separated fields to take into consideration > > + asymmetric pixels and/or hardware binning. > > + The unit cell consist on the whole area of the pixel, sensitive and > > + non-sensitive. > > "consists of", otherwise this looks unambiguous to me. > Thanks, fixing on v3. Will send after I get more feedback > I'm not sure if it is required to add a table for struct v4l2_area, > similarly to the other compound controls. > > > + This control is required for automatic calibration sensors/cameras. > > + > > .. [#f1] > > This control may be changed to a menu control in the future, if more > > options are required. > > regards > Philipp