linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anil Kumar Mamidala <amamidal@xilinx.com>
To: "sakari.ailus@iki.fi" <sakari.ailus@iki.fi>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	Naveen Kumar Gaddipati <naveenku@xilinx.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Stefan Hladnik <stefan.hladnik@gmail.com>,
	Florian Rebaudo <frebaudo@witekio.com>
Subject: RE: [PATCH v2 1/2] media: i2c: Add ON Semiconductor AP1302 ISP driver
Date: Tue, 7 Sep 2021 15:16:19 +0000	[thread overview]
Message-ID: <SJ0PR02MB85140E02562D8C4B5B4CD738B7D39@SJ0PR02MB8514.namprd02.prod.outlook.com> (raw)
In-Reply-To: <SJ0PR02MB851440739434B1C101FC8BE2B7F89@SJ0PR02MB8514.namprd02.prod.outlook.com>

Hi Sakari,

Can you please review the patches and provide your valuable feedback.

Please find the change list w.r.to v1 patch below.
1.  Updated code with the review comments from you for patch v1.
	- Add check for firmware size
	- Remove hardcoding of MIPI lanes
	- Use fwnode_graph_get_endpoint_by_id() API instead of fwnode_graph_get_next_endpoint
2.  Add streaming flag to avoid multiple times calling of stream on/off functionality if already in that state. 
3.  Add v4l2_ctrls for setting brightness, saturation, AE metering mode, contrast, gain ctrls.

Thanks and regards,
 Anil.

-----Original Message-----
From: Anil Kumar Mamidala 
Sent: Wednesday, August 11, 2021 3:52 PM
To: sakari.ailus@iki.fi
Cc: linux-media@vger.kernel.org; Naveen Kumar Gaddipati <naveenku@xilinx.com>; Laurent Pinchart <laurent.pinchart@ideasonboard.com>; Stefan Hladnik <stefan.hladnik@gmail.com>; Florian Rebaudo <frebaudo@witekio.com>
Subject: RE: [PATCH v2 1/2] media: i2c: Add ON Semiconductor AP1302 ISP driver

Hi Sakari,

Please find my reply inline.

Thanks and regards,
Anil
-----Original Message-----
From: sakari.ailus@iki.fi <sakari.ailus@iki.fi> 
Sent: Tuesday, August 10, 2021 8:56 PM
To: Anil Kumar Mamidala <amamidal@xilinx.com>
Cc: linux-media@vger.kernel.org; Naveen Kumar Gaddipati <naveenku@xilinx.com>; Laurent Pinchart <laurent.pinchart@ideasonboard.com>; Stefan Hladnik <stefan.hladnik@gmail.com>; Florian Rebaudo <frebaudo@witekio.com>
Subject: Re: [PATCH v2 1/2] media: i2c: Add ON Semiconductor AP1302 ISP driver

Hi Anil,

On Wed, Aug 04, 2021 at 06:05:54AM +0000, Anil Kumar Mamidala wrote:
> Hi Sakari,
> 
> Can you please review ap1302 ISP driver patch. Sorry for the delay in pushing the changes.

No worries.

Could you elaborate what has changed here since v1?
<Anil> Please find the changes list below.
1.  Updated code with the review comments from you for patch v1.
	- Add check for firmware size
	- Remove hardcoding of MIPI lanes
	- Use fwnode_graph_get_endpoint_by_id() API instead of fwnode_graph_get_next_endpoint

2.  Add streaming flag to avoid multiple times calling of stream on/off functionality if already in that state. 
3.  Add v4l2_ctrls for setting brightness, saturation, AE metering mode, contrast, gain ctrls.

-- 
Sakari Ailus

  reply	other threads:[~2021-09-07 15:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 12:11 [PATCH v2 1/2] media: i2c: Add ON Semiconductor AP1302 ISP driver Anil Kumar Mamidala
2021-07-29 12:11 ` [PATCH v2 2/2] media: dt-bindings: media: i2c: Add bindings for AP1302 Anil Kumar Mamidala
2021-08-04  6:05 ` [PATCH v2 1/2] media: i2c: Add ON Semiconductor AP1302 ISP driver Anil Kumar Mamidala
2021-08-10 15:26   ` sakari.ailus
2021-08-11 10:22     ` Anil Kumar Mamidala
2021-09-07 15:16       ` Anil Kumar Mamidala [this message]
2021-09-07 21:42         ` sakari.ailus
2021-09-08  8:56 Anil Kumar Mamidala
2021-10-06 11:32 Anil Kumar Mamidala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR02MB85140E02562D8C4B5B4CD738B7D39@SJ0PR02MB8514.namprd02.prod.outlook.com \
    --to=amamidal@xilinx.com \
    --cc=frebaudo@witekio.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=naveenku@xilinx.com \
    --cc=sakari.ailus@iki.fi \
    --cc=stefan.hladnik@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).