From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Daniel Scally <djrscally@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
devel@acpica.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yong Zhi <yong.zhi@intel.com>, Bingbu Cao <bingbu.cao@intel.com>,
Tian Shu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Erik Kaneda <erik.kaneda@intel.com>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
kieran.bingham+renesas@ideasonboard.com,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Marco Felsch <m.felsch@pengutronix.de>,
niklas.soderlund+renesas@ragnatech.se,
Steve Longerbeam <slongerbeam@gmail.com>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jordan Hand <jorhand@linux.microsoft.com>
Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver
Date: Tue, 29 Dec 2020 02:07:04 +0200 [thread overview]
Message-ID: <X+pzKDNWpiQWenHy@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAHp75Vdzk7i+QzkTxLJUUkw3xZot9F7QT8pyu6b5yjkCVzMXEA@mail.gmail.com>
Hi Andy,
On Tue, Dec 29, 2020 at 01:54:59AM +0200, Andy Shevchenko wrote:
> On Tue, Dec 29, 2020 at 1:08 AM Laurent Pinchart wrote:
> >
> > On Tue, Dec 29, 2020 at 12:55:44AM +0200, Andy Shevchenko wrote:
> > > On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote:
> > > > On 28/12/2020 17:05, Sakari Ailus wrote:
>
> ...
>
> > > > Which do you prefer?
> > >
> > > Actually ipu3-cio2.h misses a lot of inclusions (like mutex.h which I
> > > immediately noticed when scrolled over data types).
> >
> > Then ipu3-cio2.h should be fixed :-)
>
> Below is a draft patch (it is possible mangled, due to Gmail). Can you
> look at it and tell me what you think?
Thank you for the patch.
> I believe some headers can be removed, but I have no idea about header
> inclusion guarantees that v4l2 provides.
>
> From 10fa6c7ff66ded35a246677ffe20c677e8453f5b3 Mon Sep 17 00:00:00 2001
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date: Tue, 29 Dec 2020 01:42:03 +0200
> Subject: [PATCH 1/1] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct
> user of
>
> Add headers that ipu3-cio2.h is direct user of.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.h | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> index ccf0b85ae36f..9ea154c50ba1 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> @@ -4,8 +4,25 @@
> #ifndef __IPU3_CIO2_H
> #define __IPU3_CIO2_H
>
> +#include <linux/bits.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/kernel.h>
> +#include <linux/mutex.h>
> #include <linux/types.h>
>
> +#include <asm/page.h>
> +
> +#include <linux/videodev2.h>
I think this can be dropped.
> +
> +#include <media/media-device.h>
> +#include <media/media-entity.h>
> +#include <media/v4l2-async.h>
> +#include <media/v4l2-dev.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-subdev.h>
> +#include <media/videobuf2-core.h>
> +#include <media/videobuf2-v4l2.h>
> +
> #define CIO2_NAME "ipu3-cio2"
> #define CIO2_DEVICE_NAME "Intel IPU3 CIO2"
> #define CIO2_ENTITY_NAME "ipu3-csi2"
> @@ -325,6 +342,8 @@ struct csi2_bus_info {
> u32 lanes;
> };
>
> +struct cio2_fbpt_entry;
> +
> struct cio2_queue {
> /* mutex to be used by vb2_queue */
> struct mutex lock;
> @@ -355,6 +374,8 @@ struct cio2_queue {
> atomic_t bufs_queued;
> };
>
> +struct pci_dev;
> +
How about grouping all forward declarations at the top ?
Otherwise this looks good,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
If I was maintaining this driver I would likely move the structure
definitions to ipu3-cio2.c though.
> struct cio2_device {
> struct pci_dev *pci_dev;
> void __iomem *base;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-12-29 0:08 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 1:08 [PATCH v3 00/14] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows Daniel Scally
2020-12-24 1:08 ` [PATCH v3 01/14] software_node: Fix refcounts in software_node_get_next_child() Daniel Scally
2020-12-24 1:08 ` [PATCH v3 02/14] property: Return true in fwnode_device_is_available for NULL ops Daniel Scally
2020-12-24 1:08 ` [PATCH v3 03/14] property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary Daniel Scally
2020-12-24 1:08 ` [PATCH v3 04/14] software_node: Enforce parent before child ordering of nodes arrays Daniel Scally
2020-12-24 1:08 ` [PATCH v3 05/14] software_node: unregister software_nodes in reverse order Daniel Scally
2020-12-24 12:13 ` Andy Shevchenko
2020-12-24 14:00 ` Daniel Scally
2020-12-24 14:12 ` Andy Shevchenko
2020-12-24 14:14 ` Daniel Scally
2020-12-24 18:36 ` David Laight
2020-12-28 10:15 ` Andy Shevchenko
2020-12-28 21:17 ` Daniel Scally
2020-12-28 16:34 ` Sakari Ailus
2020-12-28 17:47 ` Andy Shevchenko
2020-12-24 1:08 ` [PATCH v3 06/14] include: fwnode.h: Define format macros for ports and endpoints Daniel Scally
2020-12-24 12:17 ` Andy Shevchenko
2020-12-24 12:41 ` Laurent Pinchart
2020-12-28 16:30 ` Sakari Ailus
2020-12-28 17:11 ` Sakari Ailus
2020-12-28 21:36 ` Daniel Scally
2020-12-24 1:09 ` [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions Daniel Scally
2020-12-24 12:24 ` Andy Shevchenko
2020-12-24 12:55 ` Laurent Pinchart
2020-12-24 13:03 ` Andy Shevchenko
2020-12-24 14:21 ` Daniel Scally
2020-12-28 16:41 ` Sakari Ailus
2020-12-28 21:37 ` Daniel Scally
2020-12-26 23:47 ` Daniel Scally
2020-12-24 12:53 ` Laurent Pinchart
2020-12-24 14:24 ` Daniel Scally
2020-12-24 1:09 ` [PATCH v3 08/14] lib/test_printf.c: Use helper function to unwind array of software_nodes Daniel Scally
2020-12-24 1:09 ` [PATCH v3 09/14] ipu3-cio2: Add T: entry to MAINTAINERS Daniel Scally
2020-12-24 1:09 ` [PATCH v3 10/14] ipu3-cio2: Rename ipu3-cio2.c Daniel Scally
2020-12-24 1:09 ` [PATCH v3 11/14] media: v4l2-core: v4l2-async: Check sd->fwnode->secondary in match_fwnode() Daniel Scally
2020-12-24 1:09 ` [PATCH v3 12/14] acpi: Add acpi_dev_get_next_match_dev() and helper macro Daniel Scally
2020-12-24 1:09 ` [PATCH v3 13/14] include: media: v4l2-fwnode: Include v4l2_fwnode_bus_type Daniel Scally
2020-12-24 12:32 ` Andy Shevchenko
2020-12-26 23:14 ` Daniel Scally
2020-12-24 12:58 ` Laurent Pinchart
2020-12-24 1:09 ` [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Daniel Scally
2020-12-24 12:54 ` Andy Shevchenko
2020-12-26 23:23 ` Daniel Scally
2020-12-28 17:05 ` Sakari Ailus
2020-12-28 22:37 ` Daniel Scally
2020-12-28 22:55 ` Andy Shevchenko
2020-12-28 22:56 ` Andy Shevchenko
2020-12-28 23:07 ` Laurent Pinchart
2020-12-28 23:54 ` Andy Shevchenko
2020-12-29 0:07 ` Laurent Pinchart [this message]
2020-12-30 20:47 ` Andy Shevchenko
2020-12-28 23:30 ` Daniel Scally
2020-12-28 23:47 ` Andy Shevchenko
2021-01-02 17:07 ` Sakari Ailus
2021-01-02 17:12 ` Daniel Scally
2021-01-02 17:21 ` Sakari Ailus
2021-01-02 17:24 ` Sakari Ailus
2021-01-02 21:23 ` Daniel Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+pzKDNWpiQWenHy@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=andy.shevchenko@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=devel@acpica.org \
--cc=djrscally@gmail.com \
--cc=erik.kaneda@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=jorhand@linux.microsoft.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=m.felsch@pengutronix.de \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pmladek@suse.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=slongerbeam@gmail.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).