From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/16] media: i2c: rdacm2x: Fix wake up delay
Date: Mon, 22 Feb 2021 03:18:53 +0200 [thread overview]
Message-ID: <YDMGfQFKWUq9hyDv@pendragon.ideasonboard.com> (raw)
In-Reply-To: <3e759da5-9bba-54ae-fe39-a7db2cbbb31c@ideasonboard.com>
Hi Jacopo,
Thank you for the patch.
On Wed, Feb 17, 2021 at 01:33:01PM +0000, Kieran Bingham wrote:
> On 16/02/2021 17:41, Jacopo Mondi wrote:
> > The MAX9271 chip manual prescribes a delay of 5 milliseconds
> > after the chip exists from low power state.
> >
> > Adjust the required delay in the rdacm21 camera module and add it
> > to the rdacm20 that currently doesn't implement one.
>
> This sounds to me like it should be a common function in the max9271 module:
>
> > /* Verify communication with the MAX9271: ping to wakeup. */
> > dev->serializer.client->addr = MAX9271_DEFAULT_ADDR;
> > i2c_smbus_read_byte(dev->serializer.client);
> > usleep_range(5000, 8000);
>
> Especially as that MAX9271_DEFAULT_ADDR should probably be handled
> directly in the max9271.c file too, and the RDACM's shouldn't care about it.
I think this is a good idea. With this addressed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> If we end up moving the max9271 'library' into more of a module/device
> then this would have to be done in it's 'probe' anyway, so it's likely
> better handled down there...?
>
> But ... it's not essential at this point in the series, so if you want
> to keep this patch as is,
>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > ---
> > drivers/media/i2c/rdacm20.c | 1 +
> > drivers/media/i2c/rdacm21.c | 2 +-
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
> > index ea30cc936531..39e4b4241870 100644
> > --- a/drivers/media/i2c/rdacm20.c
> > +++ b/drivers/media/i2c/rdacm20.c
> > @@ -460,6 +460,7 @@ static int rdacm20_initialize(struct rdacm20_device *dev)
> > /* Verify communication with the MAX9271: ping to wakeup. */
> > dev->serializer.client->addr = MAX9271_DEFAULT_ADDR;
> > i2c_smbus_read_byte(dev->serializer.client);
> > + usleep_range(5000, 8000);
> >
> > /* Serial link disabled during config as it needs a valid pixel clock. */
> > ret = max9271_set_serial_link(&dev->serializer, false);
> > diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
> > index 179d107f494c..b22a2ca5340b 100644
> > --- a/drivers/media/i2c/rdacm21.c
> > +++ b/drivers/media/i2c/rdacm21.c
> > @@ -453,7 +453,7 @@ static int rdacm21_initialize(struct rdacm21_device *dev)
> > /* Verify communication with the MAX9271: ping to wakeup. */
> > dev->serializer.client->addr = MAX9271_DEFAULT_ADDR;
> > i2c_smbus_read_byte(dev->serializer.client);
> > - usleep_range(3000, 5000);
> > + usleep_range(5000, 8000);
> >
> > /* Enable reverse channel and disable the serial link. */
> > ret = max9271_set_serial_link(&dev->serializer, false);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-02-22 1:20 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 17:41 [PATCH 00/16] media: i2c: GMSL reliability improvements Jacopo Mondi
2021-02-16 17:41 ` [PATCH 01/16] media: i2c: rdacm20: Enable noise immunity Jacopo Mondi
2021-02-17 12:55 ` Kieran Bingham
2021-02-22 0:49 ` Laurent Pinchart
2021-02-22 14:59 ` Jacopo Mondi
2021-02-24 20:35 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 02/16] media: i2c: rdacm20: Embedded 'serializer' field Jacopo Mondi
2021-02-17 12:56 ` Kieran Bingham
2021-02-22 0:58 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 03/16] media: i2c: rdacm20: Replace goto with a loop Jacopo Mondi
2021-02-17 13:01 ` Kieran Bingham
2021-02-22 1:05 ` Laurent Pinchart
2021-02-22 15:06 ` Jacopo Mondi
2021-02-24 20:27 ` Laurent Pinchart
2021-02-25 8:56 ` Kieran Bingham
2021-02-16 17:41 ` [PATCH 04/16] media: i2c: rdacm20: Report camera module name Jacopo Mondi
2021-02-17 13:02 ` Kieran Bingham
2021-02-22 1:06 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 05/16] media: i2c: rdacm20: Check return values Jacopo Mondi
2021-02-17 13:08 ` Kieran Bingham
2021-02-22 1:09 ` Laurent Pinchart
2021-02-22 15:08 ` Jacopo Mondi
2021-02-16 17:41 ` [PATCH 06/16] media: i2c: rdacm20: Re-work ov10635 reset Jacopo Mondi
2021-02-17 13:22 ` Kieran Bingham
2021-02-22 1:15 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 07/16] media: i2c: rdacm2x: Fix wake up delay Jacopo Mondi
2021-02-17 8:02 ` Geert Uytterhoeven
2021-02-17 13:33 ` Kieran Bingham
2021-02-22 1:18 ` Laurent Pinchart [this message]
2021-02-22 15:11 ` Jacopo Mondi
2021-02-24 20:29 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 08/16] media: i2c: max9286: Adjust parameters indent Jacopo Mondi
2021-02-17 13:36 ` Kieran Bingham
2021-02-22 1:20 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 09/16] media: i2c: rdacm21: Re-work OV10640 initialization Jacopo Mondi
2021-02-17 8:06 ` Geert Uytterhoeven
2021-02-17 13:55 ` Kieran Bingham
2021-02-22 1:27 ` Laurent Pinchart
2021-02-22 15:19 ` Jacopo Mondi
2021-02-24 20:30 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 10/16] media: i2c: max9286: Rename reverse_channel_mv Jacopo Mondi
2021-02-17 8:07 ` Geert Uytterhoeven
2021-02-18 15:06 ` Kieran Bingham
2021-02-22 1:29 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 11/16] media: i2c: max9286: Cache channel amplitude Jacopo Mondi
2021-02-17 8:08 ` Geert Uytterhoeven
2021-02-18 15:39 ` Kieran Bingham
2021-02-22 1:33 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 12/16] media: i2c: max9286: Define high " Jacopo Mondi
2021-02-18 15:39 ` Kieran Bingham
2021-02-22 1:35 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 13/16] media: i2c: rdacm2x: Implement .init() subdev op Jacopo Mondi
2021-02-17 8:17 ` Geert Uytterhoeven
2021-02-18 16:13 ` Kieran Bingham
2021-02-22 1:52 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 14/16] media: i2c: max9286: Initialize remotes when bound Jacopo Mondi
2021-02-17 8:19 ` Geert Uytterhoeven
2021-02-18 16:00 ` Kieran Bingham
2021-02-22 2:03 ` Laurent Pinchart
2021-02-16 17:41 ` [PATCH 15/16] media: i2c: max9286: Rework comments in .bound() Jacopo Mondi
2021-02-18 16:03 ` Kieran Bingham
2021-02-16 17:41 ` [PATCH 16/16] media: i2c: gmsl: Use 339Kbps I2C bit-rate Jacopo Mondi
2021-02-17 8:19 ` Geert Uytterhoeven
2021-02-18 16:07 ` Kieran Bingham
2021-02-22 2:06 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDMGfQFKWUq9hyDv@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).