From: Dan Carpenter <dan.carpenter@oracle.com>
To: mchehab+huawei@kernel.org
Cc: linux-media@vger.kernel.org
Subject: [bug report] Revert "media: staging: atomisp: Remove driver"
Date: Fri, 12 Mar 2021 09:43:44 +0300 [thread overview]
Message-ID: <YEsNoNRz40DSq/4k@mwanda> (raw)
Hello Mauro Carvalho Chehab,
The patch ad85094b293e: "Revert "media: staging: atomisp: Remove
driver"" from Apr 19, 2020, leads to the following static checker
warning:
drivers/staging/media/atomisp/pci/atomisp_fops.c:261 atomisp_q_video_buffers_to_css()
error: buffer overflow 'asd->stream_env[stream_id]->pipes' 6 <= 6
drivers/staging/media/atomisp/pci/atomisp_fops.c
234 list_del_init(&vb->queue);
235 vb->state = VIDEOBUF_ACTIVE;
236 spin_unlock_irqrestore(&pipe->irq_lock, irqflags);
237
238 /*
239 * If there is a per_frame setting to apply on the buffer,
240 * do it before buffer en-queueing.
241 */
242 vm_mem = vb->priv;
243
244 param = pipe->frame_params[vb->i];
245 if (param) {
246 atomisp_makeup_css_parameters(asd,
247 &asd->params.css_param.update_flag,
248 ¶m->params);
249 atomisp_apply_css_parameters(asd, ¶m->params);
250
251 if (param->params.update_flag.dz_config &&
252 asd->run_mode->val != ATOMISP_RUN_MODE_VIDEO) {
253 err = atomisp_calculate_real_zoom_region(asd,
254 ¶m->params.dz_config, css_pipe_id);
255 if (!err)
256 asd->params.config.dz_config = ¶m->params.dz_config;
257 }
258 atomisp_css_set_isp_config_applied_frame(asd,
259 vm_mem->vaddr);
260 atomisp_css_update_isp_params_on_pipe(asd,
261 asd->stream_env[stream_id].pipes[css_pipe_id]);
^^^^^^^^^^^
Can this be IA_CSS_PIPE_ID_NUM? It looks that way. The concern is
about the last caller in atomisp_qbuffers_to_css().
262 asd->params.dvs_6axis = (struct ia_css_dvs_6axis_config *)
263 param->params.dvs_6axis;
264
265 /*
266 * WORKAROUND:
267 * Because the camera halv3 can't ensure to set zoom
268 * region to per_frame setting and global setting at
269 * same time and only set zoom region to pre_frame
regards,
dan carpenter
next reply other threads:[~2021-03-12 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 6:43 Dan Carpenter [this message]
2021-03-12 7:24 ` [bug report] Revert "media: staging: atomisp: Remove driver" Mauro Carvalho Chehab
2021-03-12 10:08 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-06-26 10:42 Dan Carpenter
2020-05-29 10:41 Dan Carpenter
2020-05-29 15:36 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEsNoNRz40DSq/4k@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).