From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sebastian Fricke <sebastian.fricke@posteo.net>
Cc: linux-media@vger.kernel.org, dafna.hirschfeld@collabora.com,
helen.koike@collabora.com, heiko@sntech.de
Subject: Re: [PATCH 1/2] media: rkisp1: Increase ISP input resolution limit
Date: Fri, 26 Mar 2021 06:14:59 +0200 [thread overview]
Message-ID: <YF1fw75lCud3Akxg@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210325192700.21393-2-sebastian.fricke@posteo.net>
Hi Sebastian,
Thank you for the patch.
On Thu, Mar 25, 2021 at 08:27:01PM +0100, Sebastian Fricke wrote:
> The incentive for this patch was to overcome the inability of the
> ISP device to work with resolutions greater than 4032x3024.
> Increase the limit to 4416x3312 to allow higher input resolutions.
> Use the old resolution to crop the input resolution down to the maximum
> size for the ISP to process frames.
>
> Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> index 038c303a8aed..553effda4d5e 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> @@ -30,10 +30,12 @@
> #define RKISP1_ISP_SD_SINK BIT(1)
>
> /* min and max values for the widths and heights of the entities */
> -#define RKISP1_ISP_MAX_WIDTH 4032
> -#define RKISP1_ISP_MAX_HEIGHT 3024
> -#define RKISP1_ISP_MIN_WIDTH 32
> -#define RKISP1_ISP_MIN_HEIGHT 32
> +#define RKISP1_ISP_MAX_WIDTH 4416
> +#define RKISP1_ISP_MAX_HEIGHT 3312
> +#define RKISP1_ISP_MAX_WIDTH_PROCESSING 4032
> +#define RKISP1_ISP_MAX_HEIGHT_PROCESSING 3024
Maybe s/_PROCESSING/_CROP/, or a name more descriptive ?
I would also squash this patch with 2/2, as otherwise you'll introduce a
bisection breakage (applying 1/2 only will leave the driver in an
incorrect state).
> +#define RKISP1_ISP_MIN_WIDTH 32
> +#define RKISP1_ISP_MIN_HEIGHT 32
>
> #define RKISP1_RSZ_MP_SRC_MAX_WIDTH 4416
> #define RKISP1_RSZ_MP_SRC_MAX_HEIGHT 3312
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-03-26 4:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 19:26 [PATCH 0/2] Allow higher sink pad resolutions for the RkISP1 Sebastian Fricke
2021-03-25 19:27 ` [PATCH 1/2] media: rkisp1: Increase ISP input resolution limit Sebastian Fricke
2021-03-26 4:14 ` Laurent Pinchart [this message]
2021-03-26 5:55 ` Sebastian Fricke
2021-03-25 19:27 ` [PATCH 2/2] media: rkisp1: Limit the sink pad crop size Sebastian Fricke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF1fw75lCud3Akxg@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=linux-media@vger.kernel.org \
--cc=sebastian.fricke@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).