From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Edgar Thier <info@edgarthier.net>
Cc: sakari.ailus@iki.fi,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] uvc: Add 12-bit raw bayer linear packed formats
Date: Mon, 22 Mar 2021 15:31:25 +0200 [thread overview]
Message-ID: <YFicLYz76uuW6gzE@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190708060431.5249-1-info@edgarthier.net>
Hi Edgar,
Thank you for the patch.
On Mon, Jul 08, 2019 at 08:04:31AM +0200, Edgar Thier wrote:
> These formats are compressed 12-bit raw bayer formats with four different
> pixel orders. The pixel follow one another without any padding,
> thus are packed in a 'linear' fashion.
>
> Signed-off-by: Edgar Thier <info@edgarthier.net>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 21 ++++++++++++++++++++-
> drivers/media/usb/uvc/uvcvideo.h | 12 ++++++++++++
> 2 files changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 10cfe8e51626..d12298d18406 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -179,6 +179,26 @@ static struct uvc_format_desc uvc_fmts[] = {
> .guid = UVC_GUID_FORMAT_RW10,
> .fcc = V4L2_PIX_FMT_SRGGB10P,
> },
> + {
> + .name = "Bayer 12-bit linear packed (SBGGR12LP)",
> + .guid = UVC_GUID_FORMAT_BGCP,
> + .fcc = V4L2_PIX_FMT_SBGGR12LP,
> + },
> + {
> + .name = "Bayer 12-bit linear packed (SGBRG12LP)",
> + .guid = UVC_GUID_FORMAT_GBCP,
> + .fcc = V4L2_PIX_FMT_SGBRG12LP,
> + },
> + {
> + .name = "Bayer 12-bit linear packed (SRGGB12LP)",
> + .guid = UVC_GUID_FORMAT_RGCP,
> + .fcc = V4L2_PIX_FMT_SRGGB12LP,
> + },
> + {
> + .name = "Bayer 12-bit linear packed (SGRBG12LP)",
> + .guid = UVC_GUID_FORMAT_GRCP,
> + .fcc = V4L2_PIX_FMT_SGRBG12LP,
> + },
> {
> .name = "Bayer 16-bit (SBGGR16)",
> .guid = UVC_GUID_FORMAT_BG16,
> @@ -2924,4 +2944,3 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
> MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL");
> MODULE_VERSION(DRIVER_VERSION);
> -
Unrelated change, but it's a good one, and not worth a separate patch.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
> index c7c1baa90dea..f5be00fb9a73 100644
> --- a/drivers/media/usb/uvc/uvcvideo.h
> +++ b/drivers/media/usb/uvc/uvcvideo.h
> @@ -108,6 +108,18 @@
> #define UVC_GUID_FORMAT_RGGB \
> { 'R', 'G', 'G', 'B', 0x00, 0x00, 0x10, 0x00, \
> 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> +#define UVC_GUID_FORMAT_BGCP \
> + { 'B', 'G', 'C', 'p', 0x00, 0x00, 0x10, 0x00, \
> + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> +#define UVC_GUID_FORMAT_GBCP \
> + { 'G', 'B', 'C', 'p', 0x00, 0x00, 0x10, 0x00, \
> + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> +#define UVC_GUID_FORMAT_RGCP \
> + { 'R', 'G', 'C', 'p', 0x00, 0x00, 0x10, 0x00, \
> + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> +#define UVC_GUID_FORMAT_GRCP \
> + { 'G', 'R', 'C', 'p', 0x00, 0x00, 0x10, 0x00, \
> + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> #define UVC_GUID_FORMAT_BG16 \
> { 'B', 'G', '1', '6', 0x00, 0x00, 0x10, 0x00, \
> 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-03-22 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 6:02 [PATCH v2 1/2] v4l: Add 12-bit raw bayer linear packed formats Edgar Thier
2019-07-08 6:04 ` [PATCH v2 2/2] uvc: " Edgar Thier
2021-03-22 13:31 ` Laurent Pinchart [this message]
2021-03-22 13:29 ` [PATCH v2 1/2] v4l: " Laurent Pinchart
2021-04-09 10:39 ` Sakari Ailus
2021-05-05 6:27 ` Edgar Thier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFicLYz76uuW6gzE@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=info@edgarthier.net \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).