From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B55B8C433DB for ; Wed, 24 Mar 2021 02:23:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83F2D619E5 for ; Wed, 24 Mar 2021 02:23:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231990AbhCXCWt (ORCPT ); Tue, 23 Mar 2021 22:22:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231858AbhCXCWZ (ORCPT ); Tue, 23 Mar 2021 22:22:25 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39ECEC061765 for ; Tue, 23 Mar 2021 19:22:25 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id 11so16250468pfn.9 for ; Tue, 23 Mar 2021 19:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=24qmeKyq+RHas/0nWkzkV/yI24iW9xTstvjT8SYVV4E=; b=Z/cYUHiAg1doJjTTL9i5pzxTGBcMOwSFHfvXzdWI360hIUuuL+l/4Itd0NqBwrVq3m JpNg1TbeLRgZx7/VHCob/VRq2QxVsDTWRa7GlmDMKrGrYSzi+hdtqb10NhgvShPeSiWS HOQyDu00aY3ueYqPJ6vocPlj9PM+p5LpE4gjQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=24qmeKyq+RHas/0nWkzkV/yI24iW9xTstvjT8SYVV4E=; b=ELm2MhVM8REMIIf9DuKjMuQ0JijyPXuRuWldE3sPwLi7yfvvjmGvAyiXf9gyYENqiR Kww+LkZkvHwtV/hQUu1NrFTJovsZIROYbk00NdL+Vu5ePwrKyNYIIoy+1I2UqI1RSj8Q PtXEmx68PuXEcSUyqH6s/ozjix9XfoqE7iI6QSoKaRHleI+Q1QgHwEILf4RGsgOis2Lh IxpUANVGUnXz7Fr+CbS+uL2olnFREmH97KgnnOm5ee2dQnACHUeTH5KtdSRBMl7TqCUB 647aVJk6ArET/xUeJTUuMthKdKDxxL5y17ku0DNDVJqSLNzUEqLeADBh72ZWX4ks1KSI iDPg== X-Gm-Message-State: AOAM530GoLe0bYYbeJKrwjVhGAl1izy3EiBEJ1aSgUOZV3StnKQ16+/x bQ8uPrCvezhxtID1RdBYEOq6Dw== X-Google-Smtp-Source: ABdhPJxnk/W0wD4yXUfVCUeih3TUIWGMrPaANeh6c9Cpau3Dqf9YRsDnOkp2GPsr2Rbg8zwwigZIQg== X-Received: by 2002:a63:43c2:: with SMTP id q185mr993479pga.41.1616552544705; Tue, 23 Mar 2021 19:22:24 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:bcf2:e05a:a993:9494]) by smtp.gmail.com with ESMTPSA id j3sm439947pfi.74.2021.03.23.19.22.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 19:22:23 -0700 (PDT) Date: Wed, 24 Mar 2021 11:22:18 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Sergey Senozhatsky , Laurent Pinchart , Tomasz Figa , Mauro Carvalho Chehab , Hans Verkuil , Linux Media Mailing List , Linux Kernel Mailing List Subject: Re: [PATCHv3 3/6] media: v4l UAPI: add ROI auto-controls flags Message-ID: References: <20210319055342.127308-1-senozhatsky@chromium.org> <20210319055342.127308-4-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On (21/03/23 17:04), Ricardo Ribalda wrote: > On Fri, Mar 19, 2021 at 6:53 AM Sergey Senozhatsky > wrote: > > > > UVC 1.5 defines the following Region Of Interest auto controls: > > > > D0: Auto Exposure > > D1: Auto Iris > > D2: Auto White Balance > > D3: Auto Focus > > D4: Auto Face Detect > > D5: Auto Detect and Track > > D6: Image Stabilization > > D7: Higher Quality > > D8 – D15: Reserved, set to zero > > > > Signed-off-by: Sergey Senozhatsky > > --- > > include/uapi/linux/v4l2-common.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/uapi/linux/v4l2-common.h b/include/uapi/linux/v4l2-common.h > > index 3651ebb8cb23..34f1c262d6aa 100644 > > --- a/include/uapi/linux/v4l2-common.h > > +++ b/include/uapi/linux/v4l2-common.h > > @@ -92,6 +92,16 @@ > > #define V4L2_SEL_FLAG_LE (1 << 1) > > #define V4L2_SEL_FLAG_KEEP_CONFIG (1 << 2) > > > > Are you sure that you do not want to start with 1<<3, there might be > some hardware that support LE/SE How the hardware's going to support this? There is simply no way to pass these flags to the firmware, the values already overlap with auto-controls. So I guess these flags are for the driver (C code). uvcvideo driver is not doing any "lesser or equal rectangle" magic for ROI. No such thing is defined by UVC spec. I can move these flags to entirely different value range and do remapping to uvc auto-controls values in uvcvideo.