From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9330BC433DB for ; Wed, 24 Mar 2021 13:56:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63CEF619FF for ; Wed, 24 Mar 2021 13:56:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235696AbhCXNzf (ORCPT ); Wed, 24 Mar 2021 09:55:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235767AbhCXNzB (ORCPT ); Wed, 24 Mar 2021 09:55:01 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2790BC061763 for ; Wed, 24 Mar 2021 06:55:01 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id v15so1919040lfq.5 for ; Wed, 24 Mar 2021 06:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=PgS7FYres3Xdyh8t09n3C+beyG2Bh2b8GepXqA+1xpY=; b=lCBHY8BB8T063LXXZ9vRbvvMUhIK0JGAWl71h3B+u9/v5t8MsH4ySiXzlx2ofgl0g+ /iDVrelvuS64bRKRLFCEwyrpPVCz3hWAdSHkT5f2vDrr9tL3DtcDh1a4EkSGGkVXgwNX FG6trWltSICW9BD5xmZwY7QcDXxDVImMEJoVN1ifXJPWbCnBM+xRj2mv5UXr4lR+mlY9 au+cEqrdEHjf/aypETGW6PIJxUiwstzzZRq5tRn0CsDqvBHNwXKyDdlSxwjY2JuZkXVE 2SZYBE4LfVnWHjsS/vrDyk6TJ5fqYezlQvk+zRbcThlXzxpdmvWWf4+EBAHsFjqVTgNk r0nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PgS7FYres3Xdyh8t09n3C+beyG2Bh2b8GepXqA+1xpY=; b=itxjK0s91GtB5Z2WPcrcpNW3igv9SEHgvXEFTRDlgsLrfoSi3fSRftP+Ka4D9nBB9g eVkKr6mF8Y1MTw4XjyR+bKkqMs/wR0NEZ+MHq1ELr9pEwNBi4yi7ee4Rf4BwkFX1Y85F Vdsrd2GoO/jXNk6h5PQcm59whJGTqHErC/A7wXPAD+coj1oTxst0sZcafeJBAnn7iaVY gx7/3PDegoK68z2FrwV/oIaUS1Jbmvn7Lkh5u3CBAutG7ef54GexJ/mLCigkvvZHpMZv 7nWCmhf8R/If9A3HB9UkOoG9Rnrmnyekc2UK247otkK3aobMmmmXhbJuYViNuZJd2JsC liIA== X-Gm-Message-State: AOAM532MmaO8F4Wbuy+lKUiXVkPCi/8GRR1+4Ks55jPO7YBbGQFO+f7n mKXd1nXOqNXVfYznLVBjDAUW1w== X-Google-Smtp-Source: ABdhPJyGomK7csxLo/rj12Rh8zselonGvFz3iTpxlOJdH6lROKzCr+X4NiCtWKdchY7aEEo3BfUkBQ== X-Received: by 2002:a05:6512:1044:: with SMTP id c4mr2054177lfb.198.1616594099652; Wed, 24 Mar 2021 06:54:59 -0700 (PDT) Received: from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203]) by smtp.gmail.com with ESMTPSA id f13sm319571ljm.25.2021.03.24.06.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 06:54:55 -0700 (PDT) Date: Wed, 24 Mar 2021 14:54:55 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Geert Uytterhoeven Cc: Hans Verkuil , Linux Media Mailing List , Linux-Renesas Subject: Re: [PATCH] media: rcar-csi2: Enable support for r8a77961 Message-ID: References: <20210312132459.1754782-1-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Geert, Thanks for your feedback. On 2021-03-23 15:53:27 +0100, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, Mar 12, 2021 at 2:26 PM Niklas Söderlund > wrote: > > Enable support for M3-W+ (r8a77961). > > > > Signed-off-by: Niklas Söderlund > > Thanks for your patch! > > > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c > > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c > > @@ -1164,6 +1164,10 @@ static const struct of_device_id rcar_csi2_of_table[] = { > > .compatible = "renesas,r8a7796-csi2", > > .data = &rcar_csi2_info_r8a7796, > > }, > > + { > > + .compatible = "renesas,r8a77961-csi2", > > + .data = &rcar_csi2_info_r8a7796, > > Hence CSI2 on R-Car M3-W+ is handled the same way as R-Car M3-W. > I don't know what this means for the driver, but according to Technical > Update TN-RCT-S0359A/E, R-Car M3-W+ supports lane settings 4/2/1 on > CSI40/41 (like most other R-Car Gen3 SoCs), while R-Car M3-W supports > only lane setting 4 on CSI40/41. This is a great find. The table TN-RCT-S0359A/E correct was not present in datasheets before v0.80 so it have completely been missed. The trouble is that the current driver does the wrong thing for M3-W (and allows 4/2/1 lanes) and this this patch would be correct for M3-W+ while still leaving M3-W incorrect. I will resping this series to first correct the M3-W behavior and then add M3-W on-top. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Regards, Niklas Söderlund