From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
niklas.soderlund+renesas@ragnatech.se,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH v5 05/24] media: entity: Add iterator helper for entity pads
Date: Sun, 18 Apr 2021 20:52:50 +0300 [thread overview]
Message-ID: <YHxx8hv1Am4K9kq6@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210415130450.421168-6-tomi.valkeinen@ideasonboard.com>
Hi Tomi and Jacopo,
Thank you for the patch.
On Thu, Apr 15, 2021 at 04:04:31PM +0300, Tomi Valkeinen wrote:
> From: Jacopo Mondi <jacopo+renesas@jmondi.org>
>
> Add an iterator helper to easily cycle through all pads in an entity and
> use it in media-entity and media-device code where appropriate.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> drivers/media/mc/mc-device.c | 13 ++++++-------
> drivers/media/mc/mc-entity.c | 11 ++++++-----
> include/media/media-entity.h | 12 ++++++++++++
> 3 files changed, 24 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
> index 9e56d2ad6b94..704ef1360eba 100644
> --- a/drivers/media/mc/mc-device.c
> +++ b/drivers/media/mc/mc-device.c
> @@ -581,7 +581,7 @@ static void __media_device_unregister_entity(struct media_entity *entity)
> struct media_device *mdev = entity->graph_obj.mdev;
> struct media_link *link, *tmp;
> struct media_interface *intf;
> - unsigned int i;
> + struct media_pad *iter;
>
> ida_free(&mdev->entity_internal_idx, entity->internal_idx);
>
> @@ -597,8 +597,8 @@ static void __media_device_unregister_entity(struct media_entity *entity)
> __media_entity_remove_links(entity);
>
> /* Remove all pads that belong to this entity */
> - for (i = 0; i < entity->num_pads; i++)
> - media_gobj_destroy(&entity->pads[i].graph_obj);
> + media_entity_for_each_pad(entity, iter)
> + media_gobj_destroy(&iter->graph_obj);
>
> /* Remove the entity */
> media_gobj_destroy(&entity->graph_obj);
> @@ -617,7 +617,7 @@ int __must_check media_device_register_entity(struct media_device *mdev,
> struct media_entity *entity)
> {
> struct media_entity_notify *notify, *next;
> - unsigned int i;
> + struct media_pad *iter;
> int ret;
>
> if (entity->function == MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN ||
> @@ -646,9 +646,8 @@ int __must_check media_device_register_entity(struct media_device *mdev,
> media_gobj_create(mdev, MEDIA_GRAPH_ENTITY, &entity->graph_obj);
>
> /* Initialize objects at the pads */
> - for (i = 0; i < entity->num_pads; i++)
> - media_gobj_create(mdev, MEDIA_GRAPH_PAD,
> - &entity->pads[i].graph_obj);
> + media_entity_for_each_pad(entity, iter)
> + media_gobj_create(mdev, MEDIA_GRAPH_PAD, &iter->graph_obj);
>
> /* invoke entity_notify callbacks */
> list_for_each_entry_safe(notify, next, &mdev->entity_notify, list)
> diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
> index 401fddf320e7..830841e0cd28 100644
> --- a/drivers/media/mc/mc-entity.c
> +++ b/drivers/media/mc/mc-entity.c
> @@ -198,7 +198,8 @@ int media_entity_pads_init(struct media_entity *entity, u16 num_pads,
> struct media_pad *pads)
> {
> struct media_device *mdev = entity->graph_obj.mdev;
> - unsigned int i;
> + struct media_pad *iter;
> + unsigned int i = 0;
>
> if (num_pads >= MEDIA_ENTITY_MAX_PADS)
> return -E2BIG;
> @@ -209,12 +210,12 @@ int media_entity_pads_init(struct media_entity *entity, u16 num_pads,
> if (mdev)
> mutex_lock(&mdev->graph_mutex);
>
> - for (i = 0; i < num_pads; i++) {
> - pads[i].entity = entity;
> - pads[i].index = i;
> + media_entity_for_each_pad(entity, iter) {
> + iter->entity = entity;
> + iter->index = i++;
> if (mdev)
> media_gobj_create(mdev, MEDIA_GRAPH_PAD,
> - &entity->pads[i].graph_obj);
> + &iter->graph_obj);
> }
>
> if (mdev)
> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> index 2d45344ca527..52b1a1cab57a 100644
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -1102,3 +1102,15 @@ void media_remove_intf_links(struct media_interface *intf);
> (entity)->ops->operation((entity) , ##args) : -ENOIOCTLCMD)
>
> #endif
> +
> +/**
> + * media_entity_for_each_pad - Iterate on all pads in an entity
> + * @entity: The entity the pads belong to
> + * @iter: The iterator pad
I would name the variable pad, here and in the code above.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + *
> + * Iterate on all pads in a media entity.
> + */
> +#define media_entity_for_each_pad(entity, iter) \
> + for (iter = (entity)->pads; \
> + iter < &(entity)->pads[(entity)->num_pads]; \
> + ++iter)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-04-18 17:52 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 13:04 [PATCH v5 00/24] v4l: subdev internal routing Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 01/24] media: entity: Use pad as a starting point for graph walk Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 02/24] media: entity: Use pads instead of entities in the media graph walk stack Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 03/24] media: entity: Walk the graph based on pads Tomi Valkeinen
2021-04-18 17:47 ` Laurent Pinchart
2021-04-20 11:30 ` Sakari Ailus
2021-04-15 13:04 ` [PATCH v5 04/24] v4l: mc: Start walk from a specific pad in use count calculation Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 05/24] media: entity: Add iterator helper for entity pads Tomi Valkeinen
2021-04-18 17:52 ` Laurent Pinchart [this message]
2021-04-22 12:04 ` Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 06/24] media: entity: Move the pipeline from entity to pads Tomi Valkeinen
2021-04-18 18:00 ` Laurent Pinchart
2021-04-20 11:38 ` Sakari Ailus
2021-04-15 13:04 ` [PATCH v5 07/24] media: entity: Use pad as the starting point for a pipeline Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 08/24] media: entity: Add has_route entity operation Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 09/24] media: entity: Add media_entity_has_route() function Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 10/24] media: entity: Use routing information during graph traversal Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 11/24] media: entity: Skip link validation for pads to which there is no route to Tomi Valkeinen
2021-04-18 18:06 ` Laurent Pinchart
2021-04-20 11:41 ` Sakari Ailus
2021-04-23 12:37 ` Tomi Valkeinen
2021-04-29 12:06 ` Sakari Ailus
2021-04-29 14:10 ` Laurent Pinchart
2021-04-15 13:04 ` [PATCH v5 12/24] media: entity: Add an iterator helper for connected pads Tomi Valkeinen
2021-04-18 18:20 ` Laurent Pinchart
2021-04-20 11:48 ` Sakari Ailus
2021-04-29 1:33 ` Laurent Pinchart
2021-04-29 11:56 ` Sakari Ailus
2021-04-29 12:04 ` Tomi Valkeinen
2021-04-29 12:07 ` Sakari Ailus
2021-04-29 12:14 ` Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 13/24] media: entity: Add only connected pads to the pipeline Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 14/24] media: entity: Add debug information in graph walk route check Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 15/24] v4l: Add bus type to frame descriptors Tomi Valkeinen
2021-04-18 19:23 ` Laurent Pinchart
2021-04-20 11:50 ` Sakari Ailus
2021-04-22 12:30 ` Tomi Valkeinen
2021-04-29 11:58 ` Sakari Ailus
2021-04-29 14:09 ` Laurent Pinchart
2021-04-15 13:04 ` [PATCH v5 16/24] v4l: Add CSI-2 bus configuration " Tomi Valkeinen
2021-04-18 19:24 ` Laurent Pinchart
2021-04-20 16:32 ` Sakari Ailus
2021-04-15 13:04 ` [PATCH v5 17/24] v4l: Add stream to frame descriptor Tomi Valkeinen
2021-04-18 19:27 ` Laurent Pinchart
2021-04-22 12:47 ` Tomi Valkeinen
2021-04-22 16:18 ` Laurent Pinchart
2021-04-15 13:04 ` [PATCH v5 18/24] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations Tomi Valkeinen
2021-04-18 18:32 ` Laurent Pinchart
2021-04-22 11:16 ` Tomi Valkeinen
2021-04-22 16:20 ` Laurent Pinchart
2021-04-22 16:58 ` Tomi Valkeinen
2021-04-20 16:35 ` Sakari Ailus
2021-04-15 13:04 ` [PATCH v5 19/24] media: Documentation: Add GS_ROUTING documentation Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 20/24] v4l: mc: Add an S_ROUTING helper function for power state changes Tomi Valkeinen
2021-04-18 18:55 ` Laurent Pinchart
2021-04-20 16:41 ` Sakari Ailus
2021-04-15 13:04 ` [PATCH v5 21/24] v4l: subdev: routing kernel helper functions Tomi Valkeinen
2021-04-18 19:18 ` Laurent Pinchart
2021-04-15 13:04 ` [PATCH v5 22/24] v4l: subdev: add v4l2_subdev_get_format_dir() Tomi Valkeinen
2021-04-18 19:04 ` Laurent Pinchart
2021-04-21 13:04 ` Tomi Valkeinen
2021-04-29 1:43 ` Laurent Pinchart
2021-05-04 6:49 ` Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 23/24] v4l: subdev: Take routing information into account in link validation Tomi Valkeinen
2021-04-15 13:04 ` [PATCH v5 24/24] v4l: subdev: increase V4L2_FRAME_DESC_ENTRY_MAX to 8 Tomi Valkeinen
2021-04-18 19:06 ` Laurent Pinchart
2021-04-16 8:38 ` [PATCH v5 00/24] v4l: subdev internal routing Niklas Söderlund
2021-04-16 8:47 ` Tomi Valkeinen
2021-04-16 8:56 ` Niklas Söderlund
2021-04-18 17:32 ` Laurent Pinchart
2021-04-21 12:57 ` Tomi Valkeinen
2021-04-29 1:27 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHxx8hv1Am4K9kq6@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).